💥 [RUM-10952] Make allowedTrackingOrigins required in Browser Extensions #3708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ironment and no allowedTrackingOrigins is provided
BeltranBulbarellaDD
changed the title
BeltranBulbarellaDD
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After incident-40275 where a customer's Extensions API Key was exposed. There was a security concern that this API would allow unauthorized data submission to Datadog from the customer's chrome extension.
Changes
When there is no
allowedTrackingOriginsconfigured andisUnsupportedExtensionEnvironmentis true we throw a console error and prevent the start of the SDK.Test instructions
Previous
unitande2etest should suffice.If not, run locally a browser extension without
allowedTrackingOrigins, the SDK should throw a console error and not initiate.Add the parameter with a valid url and everything should work as normal.
Checklist