-
Notifications
You must be signed in to change notification settings - Fork 162
♻️ improve browser extension e2e tests #3823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ improve browser extension e2e tests #3823
Conversation
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: 0395dae | Docs | Was this helpful? Give us feedback! |
ffb354b
to
6812024
Compare
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
test/e2e/scenario/browser-extensions/browserExtensions.scenario.ts
Outdated
Show resolved
Hide resolved
test/e2e/scenario/browser-extensions/browserExtensions.scenario.ts
Outdated
Show resolved
Hide resolved
` | ||
}) | ||
.run(async ({ withBrowserLogs, flushEvents, intakeRegistry }) => { | ||
test.fail() // TODO: remove this once the issue is fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This ensure the test is failing but mark the test as passed. When we fix the implementation of allowTrackingOrigin
we will be able to remove this.
Co-authored-by: beltran.bulbarella <[email protected]>
Motivation
Testing browser extensions in e2e was not working the same way as other tests, this PR refactor this to simplify and harmonize
It also fixes the e2e test for the browser extension that were not working properly
Changes
popup
andbackground-script
from the test browser extension as we don't do any test on themwithExtension()
will now get anExtension
object that can contain a separate rum configurationcreateExtension(path)
to use withwithExtension()
. It's rum configuration is configured separately from the base page rum config, allowing to test our different use-cases.DEFAULT_RUM_CONFIGURATION
as other tests, including the intake proxy config so we can now do assertion on the request send to the intake and the data will be send to datadog with the proper context and api keyswithSetup()
in order to run some test with a unique setup.Test instructions
Checklist