Skip to content
Closed
Changes from all commits
Commits
Show all changes
76 commits
Select commit Hold shift + click to select a range
5336f9e
sign on nightly instead of main
aiuto Apr 13, 2026
8e85c0a
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 13, 2026
a41ced7
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 13, 2026
648e72f
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 14, 2026
1bd0a6c
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 14, 2026
1790e51
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 14, 2026
b6b4ef5
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 14, 2026
d14080a
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 14, 2026
2c0920f
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 14, 2026
2121931
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 15, 2026
a336077
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 16, 2026
4040491
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 16, 2026
0cea440
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 16, 2026
7d20ec8
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 17, 2026
daac748
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 17, 2026
f174c13
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 17, 2026
b0ee7a8
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 17, 2026
4d86a4f
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 18, 2026
ce2c899
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 19, 2026
d6acef1
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 20, 2026
d871964
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 20, 2026
bd0e712
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 20, 2026
3ae588a
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 20, 2026
5cf6877
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 20, 2026
e49320d
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 20, 2026
fcc8190
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 20, 2026
23f39b0
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 20, 2026
2c85cdd
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 21, 2026
a3b86a5
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 21, 2026
45ea058
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 21, 2026
b03eefd
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 21, 2026
e9ea5f1
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 21, 2026
272b04d
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 21, 2026
7e88ace
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 22, 2026
1ff0a81
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 22, 2026
96040a6
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 22, 2026
9baaa31
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 22, 2026
c1c4bbe
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 22, 2026
c99a09e
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 22, 2026
c5dc433
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 23, 2026
00059e3
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 23, 2026
79f436f
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 23, 2026
d9aedd7
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 24, 2026
2955e53
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 26, 2026
202b190
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 27, 2026
9363569
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 27, 2026
ddad6aa
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 28, 2026
e72e6e0
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 29, 2026
485de42
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto Apr 30, 2026
d01b40c
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto May 1, 2026
7cf5862
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto May 1, 2026
f0a4d51
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto May 2, 2026
b7ba47f
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto May 4, 2026
d37311e
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto May 4, 2026
e570c21
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto May 7, 2026
ecbe842
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto May 8, 2026
e445de5
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto May 8, 2026
1063220
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto May 9, 2026
19f843a
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto May 10, 2026
a967f8d
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto May 11, 2026
543f175
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto May 11, 2026
75527eb
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto May 11, 2026
b08c5df
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto May 11, 2026
c21a4ce
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto May 11, 2026
19c63da
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto May 11, 2026
2285a1b
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto May 12, 2026
574c8c0
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto May 12, 2026
f8328d8
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto May 12, 2026
c2eea67
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto May 12, 2026
b3fbe9b
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto May 13, 2026
6d1b22f
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto May 14, 2026
41f71b4
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto May 15, 2026
1a28b52
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto May 15, 2026
f932190
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto May 18, 2026
13861d2
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto May 18, 2026
d904db0
Merge branch 'main' into aiuto/no_mac_sign_main
aiuto May 18, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitlab/build/package_build/dmg.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
stage: package_build
needs: ["go_mod_tidy_check"]
rules:
- if: $CI_COMMIT_BRANCH == "main" || $CI_COMMIT_BRANCH =~ /^[0-9]+\.[0-9]+\.x$/
- if: $CI_COMMIT_BRANCH == "nightly" || $CI_COMMIT_BRANCH =~ /^[0-9]+\.[0-9]+\.x$/

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Match nightly signing rule on BUCKET_BRANCH

This rule switches signing to CI_COMMIT_BRANCH == "nightly", but in this repo nightly runs are scheduled on main and identified via BUCKET_BRANCH (see .gitlab-ci.yml .if_scheduled_main at lines 441-443 and .on_deploy_nightly_repo_branch at 591-595). In that common nightly context, this condition is false, so SIGN=true is never set and DMG signing/notarization is skipped entirely until release branches.

Useful? React with 👍 / 👎.

@rdesgroppes rdesgroppes Apr 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codex is right.

I see the intent to limit Apple notarization to nightly builds, which makes sense from a cost/perf perspective. That said, since this has already been scoped down to only main and release branches through #45439, we’ve already moved away from Continuous Integration.

At this point, I think it’s important we stop reducing coverage further, otherwise we risk missing issues earlier in the development cycle. Keeping notarization on main at least gives us a reasonable (frequent enough) safety net before releases.

Instead please consider the following effort on optimization:

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been discussing this with Florent and the devx team.
We have all agreed this is sufficient.
It will both save CI time and reduce the number of fully signed images that we should never ship to customers.

@rdesgroppes rdesgroppes Apr 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I think on-call engineers should be consulted when the safety net has weakened to the point where all changes made throughout the day get integrated at once, because that makes it harder to narrow down the source of any regression.

  2. @codex is still right on the P1 issue it flagged.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss this off line.

variables:
SIGN: true # for `main` and release branches
- if: $CI_COMMIT_TAG =~ /^[0-9]+\.[0-9]+\.[0-9]+(-rc\.[0-9]+)?$/
Expand Down
Loading