[AGNTLOG-568] Fix flaky TestPartialStop_FlushesRegistryToDisk on ARM64

[ddrthall]

Summary

Fixes AGNTLOG-568 — flaky TestPartialStop_FlushesRegistryToDisk on ARM64 CI (tests_macos_gitlab_arm64, tests_linux-arm64-py3).

Root cause: The test gated on metrics.LogsSent, which the TCP destination increments before forwarding the payload to the auditor's inputChan (output <- payload is ~13 lines later in tcp/destination.go). On slow ARM64 runners the test called partialStop() before the auditor received the ack, so Flush() wrote a registry missing the latest offset.

Fix:

• Replace the metrics.LogsSent polling gate with auditor.GetOffset(), which reads directly from the auditor's in-memory registry. This only returns a non-empty value after the auditor has processed the payload — closing the race completely.
• Increase stop_grace_period from 1s to 5s so the serial stopper can drain all components without hitting the force-close path on slower machines. (TestPartialStop_WithTimeout is unaffected — it explicitly overrides back to 1s.)

Test plan

• inv test --targets=./comp/logs/agent/agentimpl -x "-run=TestRestartTestSuite/TestPartialStop_FlushesRegistryToDisk -count=10" — 20/20 passed
• Full TestRestartTestSuite (13 tests) — all passed
• Verify no ARM64 CI failures after merge

[dd-octo-sts]

Files inventory check summary

File checks results against ancestor 141f1206:

Results for datadog-agent_7.79.0~devel.git.698.030f5e6.pipeline.107595168-1_amd64.deb:

No change detected

[cit-pr-commenter-54b7da]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: f8ae637d-7a6c-4d2b-b1ec-048ed503ca91

Baseline: 68ba423
Comparison: a5141ba
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	+2.69	[-0.36, +5.74]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	+2.69	[-0.36, +5.74]	1	Logs
➖	docker_containers_memory	memory utilization	+1.42	[+1.26, +1.58]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	+1.14	[+0.96, +1.33]	1	Logs
➖	ddot_metrics_sum_cumulative	memory utilization	+0.83	[+0.67, +0.98]	1	Logs
➖	file_tree	memory utilization	+0.68	[+0.62, +0.74]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	+0.44	[+0.37, +0.50]	1	Logs
➖	ddot_metrics	memory utilization	+0.16	[-0.02, +0.34]	1	Logs
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	+0.11	[-0.11, +0.33]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.08	[+0.05, +0.12]	1	Logs bounds checks dashboard
➖	uds_dogstatsd_to_api	ingress throughput	+0.03	[-0.18, +0.23]	1	Logs
➖	otlp_ingest_metrics	memory utilization	+0.02	[-0.13, +0.17]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.11, +0.12]	1	Logs
➖	uds_dogstatsd_to_api_v3	ingress throughput	-0.00	[-0.20, +0.20]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.03	[-0.46, +0.40]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.03	[-0.60, +0.53]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.05	[-0.18, +0.07]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.10	[-0.50, +0.30]	1	Logs
➖	ddot_metrics_sum_delta	memory utilization	-0.25	[-0.42, -0.09]	1	Logs
➖	ddot_logs	memory utilization	-0.26	[-0.32, -0.20]	1	Logs
➖	otlp_ingest_logs	memory utilization	-0.37	[-0.46, -0.28]	1	Logs
➖	quality_gate_idle	memory utilization	-0.43	[-0.48, -0.38]	1	Logs bounds checks dashboard
➖	quality_gate_metrics_logs	memory utilization	-0.88	[-1.11, -0.65]	1	Logs bounds checks dashboard
➖	quality_gate_logs	% cpu utilization	-1.37	[-2.99, +0.25]	1	Logs bounds checks dashboard

Bounds Checks: ❌ Failed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	docker_containers_cpu	simple_check_run	10/10	681 ≥ 26
✅	docker_containers_memory	memory_usage	10/10	275.41MiB ≤ 370MiB
✅	docker_containers_memory	simple_check_run	10/10	687 ≥ 26
✅	file_to_blackhole_0ms_latency	memory_usage	10/10	0.19GiB ≤ 1.20GiB
✅	file_to_blackhole_0ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10	0.25GiB ≤ 1.20GiB
✅	file_to_blackhole_1000ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_100ms_latency	memory_usage	10/10	0.20GiB ≤ 1.20GiB
✅	file_to_blackhole_100ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_500ms_latency	memory_usage	10/10	0.22GiB ≤ 1.20GiB
✅	file_to_blackhole_500ms_latency	missed_bytes	10/10	0B = 0B
❌	quality_gate_idle	intake_connections	0/10	4 > 3	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	176.22MiB ≤ 181MiB	bounds checks dashboard
❌	quality_gate_idle_all_features	intake_connections	5/10	4 > 3	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	495.75MiB ≤ 550MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	209.34MiB ≤ 220MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	363.42 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	446.79MiB ≤ 475MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

❌ Failed. Some Quality Gates were violated.

• quality_gate_idle_all_features, bounds check intake_connections: 5/10 replicas passed. Failed 5 which is > 0. Gate FAILED.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 0/10 replicas passed. Failed 10 which is > 0. Gate FAILED.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 58cabf0a06

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".