[CONTP-1569] KSM pod .total aggregation through a clc cluster_aggregates_only check

[zhuminyi]

What does this PR do?

Fixes under-reporting of the kubernetes_state.{container}.<cpu|memory|gpu>_{requested,limit}.total
family when the KSM check runs in pod_collection_mode: node_kubelet.

Motivation

In node_kubelet mode every node agent computes the .total family from its local pod view and emits it with a reduced tag set —[namespace, container, owner_kind, owner_name], with no host/pod/node tag.
Because every node emits a byte-identical series at (roughly) the same timestamp, the backend's same-tags/same-timestamp collision rule keeps only one node's value. Result: the cluster aggregation metrics are total under-reported, sum does not work either.

Count-style metrics (pod.count, etc.) are unaffected — they carry a node tag, so per-node series stay distinct and sum correctly. Only the tag-collapsed .total family breaks.

A new pod_collection_mode: cluster_aggregates_only watches all** pods and emits only the .total family. It will be run on clc runner but aggregate just the 4 owner-tagged source metrics.

Describe how you validated your changes

Suppression is enabled per-instance via the cluster_aggregates_enabled KSM check option, set on the node_kubelet and cluster_unassigned instances (the cluster_aggregates_only instance omits it).

For operator Datadog CR, related PR

apiVersion: datadoghq.com/v2alpha1
kind: DatadogAgent
metadata:
  name: datadog
  namespace: datadog
spec:
  global:
    credentials:
      apiSecret:
        secretName: datadog-secret
        keyName: api-key
  features:
    kubeStateMetricsCore:
      enabled: true
      conf:
        configData: |-
          cluster_check: true
          init_config:
          instances:
            # non-pod resources + unassigned pods
            - skip_leader_election: true
              pod_collection_mode: cluster_unassigned
              cluster_aggregates_enabled: true
            - skip_leader_election: true
              pod_collection_mode: cluster_aggregates_only
    clusterChecks:
      enabled: true
  override:
    nodeAgent:
      extraConfd:
        configDataMap:
          kubernetes_state_core.yaml: |-
            init_config:
            instances:
              - collectors:
                  - pods
                pod_collection_mode: node_kubelet
                cluster_aggregates_enabled: true

For Helm install

datadog:
  clusterChecks:
    enabled: true
  kubeStateMetricsCore:
    enabled: true

  # node agents → node_kubelet (scheduled pods)
  confd:
    kubernetes_state_core.yaml: |-
      init_config:
      instances:
        - collectors:
            - pods
          pod_collection_mode: node_kubelet
          cluster_aggregates_enabled: true

clusterAgent:
  confd:
    kubernetes_state_core.yaml: |-
      cluster_check: true
      init_config:
      instances:
        - skip_leader_election: true
          pod_collection_mode: cluster_unassigned
          cluster_aggregates_enabled: true
        - skip_leader_election: true
          pod_collection_mode: cluster_aggregates_only

Additional Notes

[datadog-datadog-us1-prod]

🎯 Code Coverage (details)
• Patch Coverage: 51.35%
• Overall Coverage: 51.45% (+0.11%)

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 85c2fce | Docs | Datadog PR Page | Give us feedback!}

[dd-octo-sts]

Files inventory check summary

File checks results against ancestor 1ec050b1:

Results for datadog-agent_7.82.0~devel.git.696.85c2fce.pipeline.123347734-1_amd64.deb:

No change detected

[dd-octo-sts]

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 1ec050b
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

	Quality gate	Change	Size (prev → curr → max)
✅	agent_deb_amd64	+3.89 KiB (0.00% increase, -0.04% of buffer)	748.568 → 748.572 → 758.200
✅	agent_rpm_amd64	+3.89 KiB (0.00% increase, -0.04% of buffer)	748.552 → 748.556 → 758.170
✅	agent_suse_amd64	+3.89 KiB (0.00% increase, -0.04% of buffer)	748.552 → 748.556 → 758.170
✅	docker_agent_amd64	+3.9 KiB (0.00% increase, -0.06% of buffer)	807.326 → 807.330 → 813.790
✅	docker_agent_jmx_amd64	+3.9 KiB (0.00% increase, -0.06% of buffer)	998.223 → 998.227 → 1004.550

27 successful checks with minimal change (< 2 KiB)

	Quality gate	Current Size
✅	agent_deb_amd64_fips	703.573 MiB
✅	agent_heroku_amd64	307.027 MiB
✅	agent_rpm_amd64_fips	703.556 MiB
✅	agent_rpm_arm64	723.831 MiB
✅	agent_rpm_arm64_fips	682.552 MiB
✅	agent_suse_amd64_fips	703.556 MiB
✅	agent_suse_arm64	723.831 MiB
✅	agent_suse_arm64_fips	682.552 MiB
✅	docker_agent_arm64	807.622 MiB
✅	docker_agent_jmx_arm64	987.171 MiB
✅	docker_cluster_agent_amd64	209.369 MiB
✅	docker_cluster_agent_arm64	222.451 MiB
✅	docker_cws_instrumentation_amd64	7.447 MiB
✅	docker_cws_instrumentation_arm64	6.877 MiB
✅	docker_dogstatsd_amd64	39.145 MiB
✅	docker_dogstatsd_arm64	37.242 MiB
✅	docker_host_profiler_amd64	302.477 MiB
✅	docker_host_profiler_arm64	314.024 MiB
✅	dogstatsd_deb_amd64	29.880 MiB
✅	dogstatsd_deb_arm64	27.920 MiB
✅	dogstatsd_rpm_amd64	29.880 MiB
✅	dogstatsd_suse_amd64	29.880 MiB
✅	iot_agent_deb_amd64	45.829 MiB
✅	iot_agent_deb_arm64	42.528 MiB
✅	iot_agent_deb_armhf	43.309 MiB
✅	iot_agent_rpm_amd64	45.830 MiB
✅	iot_agent_suse_amd64	45.828 MiB

[cit-pr-commenter-54b7da]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 6174180d-4679-45e9-b79a-43fb5562a364

Baseline: 322357e
Comparison: bb5bef8
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+1.65	[+0.58, +2.73]	1	Logs bounds checks dashboard
➖	quality_gate_metrics_logs	memory utilization	+0.37	[+0.12, +0.62]	1	Logs bounds checks dashboard
➖	quality_gate_idle	memory utilization	-0.01	[-0.06, +0.04]	1	Logs bounds checks dashboard
➖	quality_gate_security_mean_fs_load	memory utilization	-0.09	[-0.13, -0.05]	1	Logs bounds checks dashboard
➖	quality_gate_security_idle	memory utilization	-0.11	[-0.18, -0.05]	1	Logs bounds checks dashboard
➖	quality_gate_idle_all_features	memory utilization	-0.17	[-0.21, -0.14]	1	Logs bounds checks dashboard
➖	quality_gate_security_no_fs_load	memory utilization	-0.60	[-0.70, -0.50]	1	Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	quality_gate_idle	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	146.91MiB ≤ 154MiB	bounds checks dashboard
✅	quality_gate_idle	total_bytes_received	10/10	577.54KiB ≤ 819.20KiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	485.41MiB ≤ 495MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	total_bytes_received	10/10	0.89MiB ≤ 1.25MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	183.06MiB ≤ 195MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_logs	total_bytes_received	10/10	264.17MiB ≤ 292MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	334.55 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	3 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	390.33MiB ≤ 430MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	total_bytes_received	10/10	0.86GiB ≤ 1.04GiB	bounds checks dashboard
✅	quality_gate_security_idle	cpu_usage	10/10	29.56 ≤ 40	bounds checks dashboard
✅	quality_gate_security_idle	memory_usage	10/10	296.83MiB ≤ 330MiB	bounds checks dashboard
✅	quality_gate_security_mean_fs_load	cpu_usage	10/10	61.38 ≤ 80	bounds checks dashboard
✅	quality_gate_security_mean_fs_load	memory_usage	10/10	276.26MiB ≤ 310MiB	bounds checks dashboard
✅	quality_gate_security_no_fs_load	cpu_usage	10/10	22.01 ≤ 40	bounds checks dashboard
✅	quality_gate_security_no_fs_load	memory_usage	10/10	289.55MiB ≤ 320MiB	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment	Variant	Replicates	Failure	Logs	Debug Dashboard
experiment_with_failures	baseline	0 (x8) 1 (x6)	Oom killed		Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Profiling Replicate Execution Failures (ddprof)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment	Variant	Replicates	Failure	Debug Dashboard
quality_gate_idle	comparison	10	Oom killed	Debug Dashboard
quality_gate_idle_all_features	comparison	10	Oom killed	Debug Dashboard
quality_gate_logs	baseline	10	Oom killed	Debug Dashboard
quality_gate_logs	comparison	10	Oom killed	Debug Dashboard
quality_gate_metrics_logs	baseline	10	Oom killed	Debug Dashboard
quality_gate_metrics_logs	comparison	10	Oom killed	Debug Dashboard
quality_gate_security_idle	comparison	10	Oom killed	Debug Dashboard
quality_gate_security_mean_fs_load	baseline	10	Oom killed	Debug Dashboard
quality_gate_security_mean_fs_load	comparison	10	Oom killed	Debug Dashboard
quality_gate_security_no_fs_load	comparison	10	Oom killed	Debug Dashboard

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.