Skip to content

configfilesdiscovery: collect Spark driver env vars - #55877

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
marta/spark-driver-env-discovery
Sep 4, 2026
Merged

configfilesdiscovery: collect Spark driver env vars#55877
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
marta/spark-driver-env-discovery

Conversation

@martavicentenavarro

@martavicentenavarro martavicentenavarro commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds environment-variable discovery for Spark Standalone Drivers running in cluster deploy mode. The collector detects org.apache.spark.deploy.worker.DriverWrapper, collects a reviewed allowlist of non-sensitive SPARK_* metadata, and applies the shared secret-name filter.

Motivation

DSCVR-708

Describe how you validated your changes

  • Add unit test and E2E test.
  • Manually verified Agent Discovery delivery to Fake Intake using a Docker workload with a DriverWrapper-shaped command: allowed Spark environment variables were forwarded, while secrets and JVM options were excluded.

Additional Notes

@dd-octo-sts dd-octo-sts Bot added internal Identify a non-fork PR team/agent-discovery labels Sep 4, 2026
@github-actions github-actions Bot added the medium review PR review might take time label Sep 4, 2026
@martavicentenavarro

Copy link
Copy Markdown
Contributor Author

@codex

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI review by Codex (OpenAI) - workflow run

Patch is correct. The Spark collector is safely allowlisted, registered, unit-tested, and its user-visible fakeintake path has justified E2E coverage.

@martavicentenavarro martavicentenavarro added the changelog/no-changelog No changelog entry needed label Sep 4, 2026
@martavicentenavarro martavicentenavarro self-assigned this Sep 4, 2026
chatgpt-codex-connector[bot]

This comment was marked as outdated.

@martavicentenavarro martavicentenavarro added the qa/done QA done before merge and regressions are covered by tests label Sep 4, 2026
@datadog-official

datadog-official Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 96.55%
Overall Coverage: 55.30% (+0.03%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 465278f | Docs | View more details | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor 7d781729:

Results for datadog-agent_7.85.0~devel.git.8.465278f.pipeline.135456755-1_amd64.deb:

No change detected

Results for datadog-iot-agent_7.85.0~devel.git.8.465278f.pipeline.135456755-1_amd64.deb:

No change detected

@martavicentenavarro
martavicentenavarro force-pushed the marta/spark-driver-env-discovery branch from 5055520 to ab1f65e Compare September 4, 2026 11:39
@martavicentenavarro
martavicentenavarro force-pushed the marta/spark-driver-env-discovery branch from ab1f65e to 465278f Compare September 4, 2026 12:00
@martavicentenavarro
martavicentenavarro marked this pull request as ready for review September 4, 2026 12:24
@martavicentenavarro
martavicentenavarro requested a review from a team as a code owner September 4, 2026 12:24
@github-actions github-actions Bot deleted a comment from chatgpt-codex-connector Bot Sep 4, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI review by Codex (OpenAI) - workflow run

Patch is incorrect because the new Spark E2E workload cannot build its driver with the selected runtime image.

@datadog-official datadog-official Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

No reportable defect appears in the DriverWrapper process check, approved metadata list, or shared secret-name check. Production data is not available for this review.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit 465278f · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@martavicentenavarro

Copy link
Copy Markdown
Contributor Author

@codex

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 465278fe13

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread comp/core/configfilesdiscovery/impl/collectors/spark.go
@dd-octo-sts

dd-octo-sts Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 7d78172
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_deb_amd64 +8.89 KiB (0.00% increase, -0.31% of buffer) 768.463 → 768.472 → 771.220
agent_deb_amd64_fips +4.89 KiB (0.00% increase, -0.16% of buffer) 715.051 → 715.056 → 718.020
agent_msi +7.0 KiB (0.00% increase, -0.05% of buffer) 647.746 → 647.753 → 662.360
agent_rpm_amd64 +8.89 KiB (0.00% increase, -0.32% of buffer) 768.447 → 768.456 → 771.190
agent_rpm_amd64_fips +4.89 KiB (0.00% increase, -0.16% of buffer) 715.035 → 715.040 → 718.020
agent_rpm_arm64 +7.34 KiB (0.00% increase, -0.18% of buffer) 740.393 → 740.400 → 744.370
agent_rpm_arm64_fips +7.34 KiB (0.00% increase, -0.16% of buffer) 691.526 → 691.533 → 695.880
agent_suse_amd64 +8.89 KiB (0.00% increase, -0.32% of buffer) 768.447 → 768.456 → 771.190
agent_suse_amd64_fips +4.89 KiB (0.00% increase, -0.16% of buffer) 715.035 → 715.040 → 718.020
agent_suse_arm64 +7.34 KiB (0.00% increase, -0.18% of buffer) 740.393 → 740.400 → 744.370
agent_suse_arm64_fips +7.34 KiB (0.00% increase, -0.16% of buffer) 691.526 → 691.533 → 695.880
docker_agent_amd64 +8.89 KiB (0.00% increase, -0.87% of buffer) 827.426 → 827.435 → 828.420
docker_agent_arm64 +7.33 KiB (0.00% increase, -0.18% of buffer) 824.428 → 824.435 → 828.440
docker_agent_jmx_amd64 +8.89 KiB (0.00% increase, -0.67% of buffer) 1018.339 → 1018.347 → 1019.630
docker_agent_jmx_arm64 +7.34 KiB (0.00% increase, -0.18% of buffer) 1004.120 → 1004.127 → 1008.130
18 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_heroku_amd64 316.124 MiB
docker_cluster_agent_amd64 212.687 MiB
docker_cluster_agent_arm64 225.718 MiB
docker_cws_instrumentation_amd64 7.439 MiB
docker_cws_instrumentation_arm64 6.877 MiB
docker_dogstatsd_amd64 39.557 MiB
docker_dogstatsd_arm64 37.686 MiB
docker_host_profiler_amd64 307.574 MiB
docker_host_profiler_arm64 318.791 MiB
dogstatsd_deb_amd64 30.303 MiB
dogstatsd_deb_arm64 28.315 MiB
dogstatsd_rpm_amd64 30.303 MiB
dogstatsd_suse_amd64 30.303 MiB
iot_agent_deb_amd64 46.651 MiB
iot_agent_deb_arm64 43.280 MiB
iot_agent_deb_armhf 44.097 MiB
iot_agent_rpm_amd64 46.651 MiB
iot_agent_suse_amd64 46.650 MiB

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 4, 2026

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Job ID: df752541-eae6-4b4e-ab45-5a7a600d94ee

Baseline: e536526
Comparison: 1b09417
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_security_mean_fs_load memory utilization +0.24 [+0.19, +0.28] 1 Logs bounds checks dashboard
dsd_uds_10mb_3k_timestamped_contexts_memory memory utilization +0.10 [-0.13, +0.32] 1 Logs
quality_gate_idle_all_features memory utilization +0.01 [-0.03, +0.04] 1 Logs bounds checks dashboard
quality_gate_security_no_fs_load memory utilization -0.00 [-0.07, +0.07] 1 Logs bounds checks dashboard
quality_gate_security_idle memory utilization -0.05 [-0.08, -0.02] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -0.10 [-0.98, +0.78] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization -0.25 [-0.29, -0.21] 1 Logs bounds checks dashboard
dsd_uds_10mb_3k_timestamped_contexts_cpu % cpu utilization -0.77 [-1.00, -0.54] 1 Logs
quality_gate_private_action_runner memory utilization -1.11 [-1.24, -0.98] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization -2.28 [-2.51, -2.04] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
quality_gate_idle intake_connections 10/10 4 ≤ 5 bounds checks dashboard
quality_gate_idle memory_usage 10/10 174.63MiB ≤ 179MiB bounds checks dashboard
quality_gate_idle total_bytes_received 10/10 742.80KiB ≤ 819.20KiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 4 ≤ 5 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 525.87MiB ≤ 537MiB bounds checks dashboard
quality_gate_idle_all_features total_bytes_received 10/10 1.14MiB ≤ 1.25MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 17 ≤ 40 bounds checks dashboard
quality_gate_logs memory_usage 10/10 216.16MiB ≤ 228MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_logs total_bytes_received 10/10 263.23MiB ≤ 292MiB bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 370.31 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 19 ≤ 40 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 424.01MiB ≤ 455MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs total_bytes_received 10/10 0.94GiB ≤ 1.04GiB bounds checks dashboard
quality_gate_private_action_runner memory_usage 10/10 72.10MiB ≤ 75MiB bounds checks dashboard
quality_gate_security_idle cpu_usage 10/10 28.61 ≤ 100 bounds checks dashboard
quality_gate_security_idle memory_usage 10/10 327.31MiB ≤ 355MiB bounds checks dashboard
quality_gate_security_mean_fs_load cpu_usage 10/10 62.37 ≤ 200 bounds checks dashboard
quality_gate_security_mean_fs_load memory_usage 10/10 307.82MiB ≤ 335MiB bounds checks dashboard
quality_gate_security_no_fs_load cpu_usage 10/10 23.79 ≤ 100 bounds checks dashboard
quality_gate_security_no_fs_load memory_usage 10/10 319.15MiB ≤ 345MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@martavicentenavarro

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 4, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-04 15:20:38 UTC ℹ️ Start processing command /merge


2026-09-04 15:20:48 UTC ℹ️ MergeQueue: Pull request is not mergeable yet

It will be processed automatically as soon as GitHub reports it as mergeable. View in MergeQueue UI.

  • Run /code blockers to see what is blocking it.
  • Run /remove to cancel it.

2026-09-04 15:37:28 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 1h (p90).


2026-09-04 16:51:28 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 1b09417 into main Sep 4, 2026
314 of 316 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the marta/spark-driver-env-discovery branch September 4, 2026 16:51
@github-actions github-actions Bot added this to the 7.85.0 milestone Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-discovery

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants