Skip to content

DOJM databricks install script: update sys out log to quote the update GPUM env var - #55905

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
adrien.boitreaud/fix-databricks-gpu-monitoring-log-message
Sep 4, 2026
Merged

DOJM databricks install script: update sys out log to quote the update GPUM env var#55905
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
adrien.boitreaud/fix-databricks-gpu-monitoring-log-message

Conversation

@aboitreaud

Copy link
Copy Markdown
Contributor

What does this PR do?

Update the log from the old to the current env var. Note that the current env var is already used in code, this is just a comment cleanup to prevent customer confusion

Motivation

Describe how you validated your changes

Additional Notes

@aboitreaud
aboitreaud requested review from a team as code owners September 4, 2026 17:58
@dd-octo-sts dd-octo-sts Bot added the internal Identify a non-fork PR label Sep 4, 2026
@github-actions github-actions Bot added the short review PR is simple enough to be reviewed quickly label Sep 4, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI review by Codex (OpenAI) - workflow run

patch is correct — the log message now matches the environment variable actually used to enable GPU monitoring.

@datadog-datadog-prod-us1-2 datadog-datadog-prod-us1-2 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The log now names DD_GPU_ENABLED. This name agrees with the environment variable that enables GPU monitoring.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit 4d2818d · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@aboitreaud aboitreaud added changelog/no-changelog No changelog entry needed qa/done QA done before merge and regressions are covered by tests team/fleet labels Sep 4, 2026
@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 57.00% (+1.72%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 4d2818d | Docs | View more details | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor 1b09417d:

Results for datadog-agent_7.85.0~devel.git.18.4d2818d.pipeline.135563631-1_amd64.deb:

No change detected

Results for datadog-iot-agent_7.85.0~devel.git.18.4d2818d.pipeline.135563631-1_amd64.deb:

No change detected

@dd-octo-sts

dd-octo-sts Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 1b09417
📊 Static Quality Gates Dashboard
🔗 SQG Job

32 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64 768.471 MiB
agent_deb_amd64_fips 715.052 MiB
agent_heroku_amd64 316.120 MiB
agent_rpm_amd64 768.455 MiB
agent_rpm_amd64_fips 715.035 MiB
agent_rpm_arm64 740.392 MiB
agent_rpm_arm64_fips 691.525 MiB
agent_suse_amd64 768.455 MiB
agent_suse_amd64_fips 715.035 MiB
agent_suse_arm64 740.392 MiB
agent_suse_arm64_fips 691.525 MiB
docker_agent_amd64 827.435 MiB
docker_agent_arm64 824.427 MiB
docker_agent_jmx_amd64 1018.347 MiB
docker_agent_jmx_arm64 1004.119 MiB
docker_cluster_agent_amd64 212.686 MiB
docker_cluster_agent_arm64 225.718 MiB
docker_cws_instrumentation_amd64 7.439 MiB
docker_cws_instrumentation_arm64 6.877 MiB
docker_dogstatsd_amd64 39.557 MiB
docker_dogstatsd_arm64 37.623 MiB
docker_host_profiler_amd64 307.574 MiB
docker_host_profiler_arm64 318.792 MiB
dogstatsd_deb_amd64 30.303 MiB
dogstatsd_deb_arm64 28.315 MiB
dogstatsd_rpm_amd64 30.303 MiB
dogstatsd_suse_amd64 30.303 MiB
iot_agent_deb_amd64 46.651 MiB
iot_agent_deb_arm64 43.280 MiB
iot_agent_deb_armhf 44.094 MiB
iot_agent_rpm_amd64 46.651 MiB
iot_agent_suse_amd64 46.650 MiB

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 4, 2026

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Job ID: da9082ed-9bcc-49f4-bd55-cdd846d000aa

Baseline: 4f136f4
Comparison: 4949226
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_private_action_runner memory utilization +0.74 [+0.61, +0.87] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization +0.61 [-0.27, +1.49] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization +0.44 [+0.41, +0.48] 1 Logs bounds checks dashboard
quality_gate_security_no_fs_load memory utilization +0.29 [+0.22, +0.36] 1 Logs bounds checks dashboard
quality_gate_security_mean_fs_load memory utilization +0.27 [+0.23, +0.31] 1 Logs bounds checks dashboard
quality_gate_security_idle memory utilization +0.18 [+0.14, +0.21] 1 Logs bounds checks dashboard
dsd_uds_10mb_3k_timestamped_contexts_memory memory utilization -0.01 [-0.23, +0.21] 1 Logs
quality_gate_idle memory utilization -0.06 [-0.10, -0.02] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization -0.15 [-0.39, +0.08] 1 Logs bounds checks dashboard
dsd_uds_10mb_3k_timestamped_contexts_cpu % cpu utilization -0.75 [-0.99, -0.50] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
quality_gate_idle intake_connections 10/10 4 ≤ 5 bounds checks dashboard
quality_gate_idle memory_usage 10/10 173.05MiB ≤ 179MiB bounds checks dashboard
quality_gate_idle total_bytes_received 10/10 746.25KiB ≤ 819.20KiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 4 ≤ 5 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 521.24MiB ≤ 537MiB bounds checks dashboard
quality_gate_idle_all_features total_bytes_received 10/10 1.14MiB ≤ 1.25MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 17 ≤ 40 bounds checks dashboard
quality_gate_logs memory_usage 10/10 212.97MiB ≤ 228MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_logs total_bytes_received 10/10 263.47MiB ≤ 292MiB bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 359.17 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 19 ≤ 40 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 442.00MiB ≤ 455MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs total_bytes_received 10/10 0.94GiB ≤ 1.04GiB bounds checks dashboard
quality_gate_private_action_runner memory_usage 10/10 72.13MiB ≤ 75MiB bounds checks dashboard
quality_gate_security_idle cpu_usage 10/10 31.38 ≤ 100 bounds checks dashboard
quality_gate_security_idle memory_usage 10/10 323.78MiB ≤ 355MiB bounds checks dashboard
quality_gate_security_mean_fs_load cpu_usage 10/10 64.87 ≤ 200 bounds checks dashboard
quality_gate_security_mean_fs_load memory_usage 10/10 303.10MiB ≤ 335MiB bounds checks dashboard
quality_gate_security_no_fs_load cpu_usage 10/10 23.78 ≤ 100 bounds checks dashboard
quality_gate_security_no_fs_load memory_usage 10/10 308.30MiB ≤ 345MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 4949226 into main Sep 4, 2026
313 of 321 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the adrien.boitreaud/fix-databricks-gpu-monitoring-log-message branch September 4, 2026 20:20
@github-actions github-actions Bot added this to the 7.85.0 milestone Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/fleet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants