Skip to content

Fix concurrent access to enabled features in metrics forwarder #3412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gh-worker-dd-mergequeue-cf854d merged 1 commit into from
Sep 1, 2026
Merged

Fix concurrent access to enabled features in metrics forwarder #3412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion pkg/controller/utils/datadog/metrics_forwarder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import (
"errors"
"fmt"
"hash/fnv"
"maps"
"os"
"strings"
"sync"
Expand Down Expand Up @@ -438,7 +439,7 @@ func (mf *metricsForwarder) forwardMetrics() error {
}

// send feature metrics
for _, featuresList := range mf.EnabledFeatures {
for _, featuresList := range mf.snapshotEnabledFeatures() {
for _, feature := range featuresList {
mf.sendFeatureMetric(ctx, feature)
}
Expand All @@ -449,6 +450,12 @@ func (mf *metricsForwarder) forwardMetrics() error {
return nil
}

func (mf *metricsForwarder) snapshotEnabledFeatures() map[string][]string {
mf.RLock()
defer mf.RUnlock()
return maps.Clone(mf.EnabledFeatures)
}

// processReconcileError updates lastReconcileErr
// and sends reconcile metrics based on the reconcile errors
func (mf *metricsForwarder) processReconcileError(reconcileErr error) error {
Expand Down
Loading