-
Notifications
You must be signed in to change notification settings - Fork 310
Add dependency on Maven Central deployment to OCI publish jobs #9204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sarahchen6
wants to merge
3
commits into
master
Choose a base branch
from
sarahchen6/change-release-job-dependencies
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 11 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.1-SNAPSHOT~5e179f7e0f, baseline=1.51.1-SNAPSHOT~05a10a5f19
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.043 s) : 0, 1042800
Total [baseline] (8.579 s) : 0, 8578552
Agent [candidate] (1.046 s) : 0, 1045632
Total [candidate] (8.622 s) : 0, 8621907
section iast
Agent [baseline] (1.176 s) : 0, 1175766
Total [baseline] (9.321 s) : 0, 9320615
Agent [candidate] (1.181 s) : 0, 1180601
Total [candidate] (9.325 s) : 0, 9325406
gantt
title insecure-bank - break down per module: candidate=1.51.1-SNAPSHOT~5e179f7e0f, baseline=1.51.1-SNAPSHOT~05a10a5f19
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.437 ms) : 0, 1437
crashtracking [candidate] (1.438 ms) : 0, 1438
BytebuddyAgent [baseline] (729.759 ms) : 0, 729759
BytebuddyAgent [candidate] (731.34 ms) : 0, 731340
GlobalTracer [baseline] (241.753 ms) : 0, 241753
GlobalTracer [candidate] (242.181 ms) : 0, 242181
AppSec [baseline] (30.229 ms) : 0, 30229
AppSec [candidate] (30.535 ms) : 0, 30535
Debugger [baseline] (6.012 ms) : 0, 6012
Debugger [candidate] (5.965 ms) : 0, 5965
Remote Config [baseline] (655.067 µs) : 0, 655
Remote Config [candidate] (659.235 µs) : 0, 659
Telemetry [baseline] (11.983 ms) : 0, 11983
Telemetry [candidate] (12.507 ms) : 0, 12507
section iast
crashtracking [baseline] (1.438 ms) : 0, 1438
crashtracking [candidate] (1.44 ms) : 0, 1440
BytebuddyAgent [baseline] (849.201 ms) : 0, 849201
BytebuddyAgent [candidate] (852.983 ms) : 0, 852983
GlobalTracer [baseline] (231.796 ms) : 0, 231796
GlobalTracer [candidate] (232.542 ms) : 0, 232542
AppSec [baseline] (27.224 ms) : 0, 27224
AppSec [candidate] (25.757 ms) : 0, 25757
Debugger [baseline] (6.656 ms) : 0, 6656
Debugger [candidate] (8.256 ms) : 0, 8256
Remote Config [baseline] (604.504 µs) : 0, 605
Remote Config [candidate] (585.078 µs) : 0, 585
Telemetry [baseline] (8.095 ms) : 0, 8095
Telemetry [candidate] (8.093 ms) : 0, 8093
IAST [baseline] (29.835 ms) : 0, 29835
IAST [candidate] (29.91 ms) : 0, 29910
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.1-SNAPSHOT~5e179f7e0f, baseline=1.51.1-SNAPSHOT~05a10a5f19
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.043 s) : 0, 1043361
Total [baseline] (10.709 s) : 0, 10709422
Agent [candidate] (1.051 s) : 0, 1050928
Total [candidate] (10.74 s) : 0, 10740023
section appsec
Agent [baseline] (1.222 s) : 0, 1222374
Total [baseline] (10.836 s) : 0, 10836406
Agent [candidate] (1.226 s) : 0, 1226101
Total [candidate] (10.752 s) : 0, 10751954
section iast
Agent [baseline] (1.174 s) : 0, 1174054
Total [baseline] (10.917 s) : 0, 10917454
Agent [candidate] (1.175 s) : 0, 1174579
Total [candidate] (10.903 s) : 0, 10903427
section profiling
Agent [baseline] (1.195 s) : 0, 1195160
Total [baseline] (10.887 s) : 0, 10887123
Agent [candidate] (1.207 s) : 0, 1206757
Total [candidate] (10.935 s) : 0, 10935152
gantt
title petclinic - break down per module: candidate=1.51.1-SNAPSHOT~5e179f7e0f, baseline=1.51.1-SNAPSHOT~05a10a5f19
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.447 ms) : 0, 1447
BytebuddyAgent [baseline] (730.643 ms) : 0, 730643
BytebuddyAgent [candidate] (735.064 ms) : 0, 735064
GlobalTracer [baseline] (242.027 ms) : 0, 242027
GlobalTracer [candidate] (243.206 ms) : 0, 243206
AppSec [baseline] (30.324 ms) : 0, 30324
AppSec [candidate] (30.711 ms) : 0, 30711
Debugger [baseline] (5.992 ms) : 0, 5992
Debugger [candidate] (6.02 ms) : 0, 6020
Remote Config [baseline] (653.697 µs) : 0, 654
Remote Config [candidate] (653.29 µs) : 0, 653
Telemetry [baseline] (11.233 ms) : 0, 11233
Telemetry [candidate] (12.702 ms) : 0, 12702
section appsec
crashtracking [baseline] (1.432 ms) : 0, 1432
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (754.276 ms) : 0, 754276
BytebuddyAgent [candidate] (756.871 ms) : 0, 756871
GlobalTracer [baseline] (235.815 ms) : 0, 235815
GlobalTracer [candidate] (236.321 ms) : 0, 236321
AppSec [baseline] (169.84 ms) : 0, 169840
AppSec [candidate] (169.387 ms) : 0, 169387
Debugger [baseline] (7.244 ms) : 0, 7244
Debugger [candidate] (7.971 ms) : 0, 7971
Remote Config [baseline] (605.125 µs) : 0, 605
Remote Config [candidate] (607.26 µs) : 0, 607
Telemetry [baseline] (8.308 ms) : 0, 8308
Telemetry [candidate] (8.259 ms) : 0, 8259
IAST [baseline] (23.487 ms) : 0, 23487
IAST [candidate] (23.768 ms) : 0, 23768
section iast
crashtracking [baseline] (1.434 ms) : 0, 1434
crashtracking [candidate] (1.436 ms) : 0, 1436
BytebuddyAgent [baseline] (847.769 ms) : 0, 847769
BytebuddyAgent [candidate] (847.893 ms) : 0, 847893
GlobalTracer [baseline] (232.595 ms) : 0, 232595
GlobalTracer [candidate] (231.727 ms) : 0, 231727
AppSec [baseline] (27.281 ms) : 0, 27281
AppSec [candidate] (28.905 ms) : 0, 28905
Debugger [baseline] (6.522 ms) : 0, 6522
Debugger [candidate] (5.754 ms) : 0, 5754
Remote Config [baseline] (573.8 µs) : 0, 574
Remote Config [candidate] (583.8 µs) : 0, 584
Telemetry [baseline] (8.065 ms) : 0, 8065
Telemetry [candidate] (8.155 ms) : 0, 8155
IAST [baseline] (28.842 ms) : 0, 28842
IAST [candidate] (29.127 ms) : 0, 29127
section profiling
crashtracking [baseline] (1.42 ms) : 0, 1420
crashtracking [candidate] (1.424 ms) : 0, 1424
BytebuddyAgent [baseline] (761.786 ms) : 0, 761786
BytebuddyAgent [candidate] (771.032 ms) : 0, 771032
GlobalTracer [baseline] (221.393 ms) : 0, 221393
GlobalTracer [candidate] (222.673 ms) : 0, 222673
AppSec [baseline] (30.395 ms) : 0, 30395
AppSec [candidate] (30.87 ms) : 0, 30870
Debugger [baseline] (6.207 ms) : 0, 6207
Debugger [candidate] (6.344 ms) : 0, 6344
Remote Config [baseline] (673.145 µs) : 0, 673
Remote Config [candidate] (712.333 µs) : 0, 712
Telemetry [baseline] (15.244 ms) : 0, 15244
Telemetry [candidate] (16.138 ms) : 0, 16138
ProfilingAgent [baseline] (109.3 ms) : 0, 109300
ProfilingAgent [candidate] (108.288 ms) : 0, 108288
Profiling [baseline] (109.323 ms) : 0, 109323
Profiling [candidate] (108.312 ms) : 0, 108312
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 1 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~5e179f7e0f, baseline=1.51.1-SNAPSHOT~05a10a5f19
dateFormat X
axisFormat %s
section baseline
no_agent (38.159 ms) : 37848, 38470
. : milestone, 38159,
appsec (48.132 ms) : 47706, 48559
. : milestone, 48132,
code_origins (45.967 ms) : 45590, 46345
. : milestone, 45967,
iast (45.49 ms) : 45092, 45888
. : milestone, 45490,
profiling (46.944 ms) : 46509, 47379
. : milestone, 46944,
tracing (44.221 ms) : 43855, 44587
. : milestone, 44221,
section candidate
no_agent (38.398 ms) : 38076, 38720
. : milestone, 38398,
appsec (46.464 ms) : 46063, 46865
. : milestone, 46464,
code_origins (45.183 ms) : 44803, 45563
. : milestone, 45183,
iast (44.651 ms) : 44266, 45036
. : milestone, 44651,
profiling (46.058 ms) : 45607, 46508
. : milestone, 46058,
tracing (42.792 ms) : 42432, 43153
. : milestone, 42792,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~5e179f7e0f, baseline=1.51.1-SNAPSHOT~05a10a5f19
dateFormat X
axisFormat %s
section baseline
no_agent (4.355 ms) : 4306, 4403
. : milestone, 4355,
iast (9.463 ms) : 9308, 9618
. : milestone, 9463,
iast_FULL (13.974 ms) : 13698, 14250
. : milestone, 13974,
iast_GLOBAL (10.692 ms) : 10501, 10882
. : milestone, 10692,
profiling (8.67 ms) : 8539, 8800
. : milestone, 8670,
tracing (7.751 ms) : 7642, 7860
. : milestone, 7751,
section candidate
no_agent (4.239 ms) : 4190, 4288
. : milestone, 4239,
iast (9.606 ms) : 9447, 9765
. : milestone, 9606,
iast_FULL (14.79 ms) : 14489, 15091
. : milestone, 14790,
iast_GLOBAL (10.518 ms) : 10331, 10704
. : milestone, 10518,
profiling (8.548 ms) : 8411, 8685
. : milestone, 8548,
tracing (7.586 ms) : 7475, 7697
. : milestone, 7586,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~5e179f7e0f, baseline=1.51.1-SNAPSHOT~05a10a5f19
dateFormat X
axisFormat %s
section baseline
no_agent (15.05 s) : 15050000, 15050000
. : milestone, 15050000,
appsec (15.078 s) : 15078000, 15078000
. : milestone, 15078000,
iast (18.235 s) : 18235000, 18235000
. : milestone, 18235000,
iast_GLOBAL (17.954 s) : 17954000, 17954000
. : milestone, 17954000,
profiling (15.353 s) : 15353000, 15353000
. : milestone, 15353000,
tracing (14.834 s) : 14834000, 14834000
. : milestone, 14834000,
section candidate
no_agent (15.622 s) : 15622000, 15622000
. : milestone, 15622000,
appsec (14.881 s) : 14881000, 14881000
. : milestone, 14881000,
iast (18.812 s) : 18812000, 18812000
. : milestone, 18812000,
iast_GLOBAL (18.129 s) : 18129000, 18129000
. : milestone, 18129000,
profiling (15.365 s) : 15365000, 15365000
. : milestone, 15365000,
tracing (14.844 s) : 14844000, 14844000
. : milestone, 14844000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~5e179f7e0f, baseline=1.51.1-SNAPSHOT~05a10a5f19
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (3.642 ms) : 3428, 3856
. : milestone, 3642,
iast (2.196 ms) : 2133, 2258
. : milestone, 2196,
iast_GLOBAL (2.232 ms) : 2169, 2294
. : milestone, 2232,
profiling (2.025 ms) : 1975, 2076
. : milestone, 2025,
tracing (2.009 ms) : 1961, 2057
. : milestone, 2009,
section candidate
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (3.615 ms) : 3400, 3830
. : milestone, 3615,
iast (2.197 ms) : 2134, 2260
. : milestone, 2197,
iast_GLOBAL (2.239 ms) : 2175, 2302
. : milestone, 2239,
profiling (2.052 ms) : 2001, 2104
. : milestone, 2052,
tracing (2.007 ms) : 1958, 2055
. : milestone, 2007,
|
5fe307c
to
a7ccd00
Compare
a7ccd00
to
5e179f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
OCI publishing jobs (gated by the one-pipeline
publishing-gate
job) now depend on thedeploy_to_maven_central
job to succeed before continuing.Motivation
Previously, all OCI-related jobs were triggered as soon as the
build
step was successful. This gave little buffer between when a release begins and when OCI images are published. The additional dependency added in this PR helps to avoid prematurely publishing OCI images. The images can still be created (create-arch-specific-lib-injection-image
,create-multiarch-lib-injection-image
), internally published (oci-internal-publish
), and internally tested (oci-internal-test-publish
) as soon as thebuild
step succeeds. However, the publishing steps (dependent onpublishing-gate
) will only begin after the release artifacts are successfully deployed to Maven Central. In case something happens with the release and the Maven Central deployment fails, we don't want to release our OCI images and tags into customer prod envs either.Additional Notes
This PR can only be merged after the
publishing-gate
job goes in (https://github.com/DataDog/libdatadog-build/pull/130) and the one-pipeline ref is updated (#9229).Descriptions of one-pipeline jobs: https://github.com/DataDog/libdatadog-build/blob/main/README.md#job-descriptions
Also considered was to add another layer of security by making these publishing jobs manually triggered. However, that's not included in order to keep the release automated.
Example of release pipeline before this PR's changes: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-java/-/pipelines/70610397. Select

Group jobs by: Job dependencies
andShow dependencies
. Note the dependencies for the jobs below:Example pipeline for this PR: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-java/-/pipelines/71517090. Note that the
publishing-gate
job now depends ondeploy_to_maven_central
, and the jobs in the image above depend onpublishing-gate
.Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]