-
Notifications
You must be signed in to change notification settings - Fork 312
Custom build on top of v1.51.1 #9213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(cherry picked from commit 9a188f8)
…9177) * fix: avoid race conditions on feature discovery (cherry picked from commit ff2c775) * commit suggestion Co-authored-by: Nikita Tkachenko <[email protected]> (cherry picked from commit a304e94) * fix: spotless and issue with groovy mocking (cherry picked from commit 4e880c7) --------- Co-authored-by: Nikita Tkachenko <[email protected]>
* Avoid long to string conversion * Use synchronized
) * DSM optimizations - major refactoring to get rid of LinkedHashMap * Refactored DSM tags for all integrations * Removed tests which no longer needed * Fixed some more tests * Fixed payload writer tests * Fixed http tests * Removed DataStreamsTagsBuilder, updated all integraions and tests * Spotless apply * Fixed more tests * Add base hash support and service name overrides * Fixed more tests * Spotless apply * Added tests for tags * Improved coverage * Removed unused imports * Fixed even more tests * Updated multiple tests * Fixed more tests * Spotless apply * Fixed even more tests * Fixed http tests, improved test coverage * Spotless apply * One more refactoring * Some fixes in tests * Improved test coverage * Spotless apply * Removed unused import * Fixed all tags * Fixed kafka tests
BenchmarksStartupParameters
See matching parameters
SummaryFound 10 performance improvements and 3 performance regressions! Performance is the same for 30 metrics, 10 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.52.0-SNAPSHOT~da962336df, baseline=1.51.1-SNAPSHOT~766af685ed
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.035 s) : 0, 1035303
Total [baseline] (8.597 s) : 0, 8596773
Agent [candidate] (1.0 s) : 0, 1000187
Total [candidate] (8.553 s) : 0, 8553123
section iast
Agent [baseline] (1.181 s) : 0, 1180834
Total [baseline] (9.303 s) : 0, 9303156
Agent [candidate] (1.13 s) : 0, 1130249
Total [candidate] (9.271 s) : 0, 9270600
gantt
title insecure-bank - break down per module: candidate=1.52.0-SNAPSHOT~da962336df, baseline=1.51.1-SNAPSHOT~766af685ed
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (727.395 ms) : 0, 727395
BytebuddyAgent [candidate] (690.427 ms) : 0, 690427
GlobalTracer [baseline] (240.61 ms) : 0, 240610
GlobalTracer [candidate] (243.293 ms) : 0, 243293
AppSec [baseline] (30.294 ms) : 0, 30294
AppSec [candidate] (30.617 ms) : 0, 30617
Debugger [baseline] (5.951 ms) : 0, 5951
Debugger [candidate] (5.982 ms) : 0, 5982
Remote Config [baseline] (642.475 µs) : 0, 642
Remote Config [candidate] (685.796 µs) : 0, 686
Telemetry [baseline] (8.152 ms) : 0, 8152
Telemetry [candidate] (8.323 ms) : 0, 8323
crashtracking [baseline] (1.419 ms) : 0, 1419
section iast
BytebuddyAgent [baseline] (852.155 ms) : 0, 852155
BytebuddyAgent [candidate] (805.48 ms) : 0, 805480
GlobalTracer [baseline] (232.941 ms) : 0, 232941
GlobalTracer [candidate] (231.864 ms) : 0, 231864
IAST [baseline] (30.419 ms) : 0, 30419
IAST [candidate] (26.199 ms) : 0, 26199
AppSec [baseline] (28.321 ms) : 0, 28321
AppSec [candidate] (30.967 ms) : 0, 30967
Debugger [baseline] (5.845 ms) : 0, 5845
Debugger [candidate] (6.592 ms) : 0, 6592
Remote Config [baseline] (600.401 µs) : 0, 600
Remote Config [candidate] (577.158 µs) : 0, 577
Telemetry [baseline] (8.102 ms) : 0, 8102
Telemetry [candidate] (7.921 ms) : 0, 7921
crashtracking [baseline] (1.434 ms) : 0, 1434
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.52.0-SNAPSHOT~da962336df, baseline=1.51.1-SNAPSHOT~766af685ed
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.045 s) : 0, 1044989
Total [baseline] (10.7 s) : 0, 10699593
Agent [candidate] (1.0 s) : 0, 1000152
Total [candidate] (10.753 s) : 0, 10752933
section appsec
Agent [baseline] (1.216 s) : 0, 1216017
Total [baseline] (10.845 s) : 0, 10845100
Agent [candidate] (1.173 s) : 0, 1173282
Total [candidate] (10.719 s) : 0, 10718970
section iast
Agent [baseline] (1.173 s) : 0, 1172603
Total [baseline] (10.844 s) : 0, 10844304
Agent [candidate] (1.137 s) : 0, 1137114
Total [candidate] (10.801 s) : 0, 10801323
section profiling
Agent [baseline] (1.181 s) : 0, 1181172
Total [baseline] (10.877 s) : 0, 10876623
Agent [candidate] (1.241 s) : 0, 1241183
Total [candidate] (10.935 s) : 0, 10935407
gantt
title petclinic - break down per module: candidate=1.52.0-SNAPSHOT~da962336df, baseline=1.51.1-SNAPSHOT~766af685ed
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (734.063 ms) : 0, 734063
BytebuddyAgent [candidate] (690.171 ms) : 0, 690171
GlobalTracer [baseline] (242.666 ms) : 0, 242666
GlobalTracer [candidate] (243.454 ms) : 0, 243454
AppSec [baseline] (30.722 ms) : 0, 30722
AppSec [candidate] (30.743 ms) : 0, 30743
Debugger [baseline] (6.069 ms) : 0, 6069
Debugger [candidate] (6.032 ms) : 0, 6032
Remote Config [baseline] (657.201 µs) : 0, 657
Remote Config [candidate] (682.713 µs) : 0, 683
Telemetry [baseline] (8.282 ms) : 0, 8282
Telemetry [candidate] (8.262 ms) : 0, 8262
crashtracking [baseline] (1.445 ms) : 0, 1445
section appsec
BytebuddyAgent [baseline] (750.381 ms) : 0, 750381
BytebuddyAgent [candidate] (708.741 ms) : 0, 708741
GlobalTracer [baseline] (234.254 ms) : 0, 234254
GlobalTracer [candidate] (234.778 ms) : 0, 234778
IAST [baseline] (23.498 ms) : 0, 23498
IAST [candidate] (23.193 ms) : 0, 23193
AppSec [baseline] (167.804 ms) : 0, 167804
AppSec [candidate] (171.286 ms) : 0, 171286
Debugger [baseline] (8.648 ms) : 0, 8648
Debugger [candidate] (5.734 ms) : 0, 5734
Remote Config [baseline] (612.249 µs) : 0, 612
Remote Config [candidate] (610.644 µs) : 0, 611
Telemetry [baseline] (8.131 ms) : 0, 8131
Telemetry [candidate] (8.104 ms) : 0, 8104
crashtracking [baseline] (1.417 ms) : 0, 1417
section iast
BytebuddyAgent [baseline] (846.542 ms) : 0, 846542
BytebuddyAgent [candidate] (810.76 ms) : 0, 810760
GlobalTracer [baseline] (231.153 ms) : 0, 231153
GlobalTracer [candidate] (233.128 ms) : 0, 233128
IAST [baseline] (27.421 ms) : 0, 27421
IAST [candidate] (26.493 ms) : 0, 26493
AppSec [baseline] (28.176 ms) : 0, 28176
AppSec [candidate] (30.877 ms) : 0, 30877
Debugger [baseline] (8.437 ms) : 0, 8437
Debugger [candidate] (6.604 ms) : 0, 6604
Remote Config [baseline] (594.819 µs) : 0, 595
Remote Config [candidate] (577.255 µs) : 0, 577
Telemetry [baseline] (7.891 ms) : 0, 7891
Telemetry [candidate] (7.85 ms) : 0, 7850
crashtracking [baseline] (1.429 ms) : 0, 1429
section profiling
BytebuddyAgent [baseline] (758.195 ms) : 0, 758195
BytebuddyAgent [candidate] (675.9 ms) : 0, 675900
GlobalTracer [baseline] (220.097 ms) : 0, 220097
GlobalTracer [candidate] (360.542 ms) : 0, 360542
AppSec [baseline] (30.221 ms) : 0, 30221
AppSec [candidate] (35.223 ms) : 0, 35223
Debugger [baseline] (6.243 ms) : 0, 6243
Debugger [candidate] (9.107 ms) : 0, 9107
Remote Config [baseline] (658.135 µs) : 0, 658
Remote Config [candidate] (656.199 µs) : 0, 656
Telemetry [baseline] (12.425 ms) : 0, 12425
Telemetry [candidate] (7.951 ms) : 0, 7951
crashtracking [baseline] (1.394 ms) : 0, 1394
ProfilingAgent [baseline] (103.695 ms) : 0, 103695
ProfilingAgent [candidate] (103.353 ms) : 0, 103353
Profiling [baseline] (103.718 ms) : 0, 103718
Profiling [candidate] (103.379 ms) : 0, 103379
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 1 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~da962336df, baseline=1.51.1-SNAPSHOT~766af685ed
dateFormat X
axisFormat %s
section baseline
no_agent (4.348 ms) : 4295, 4401
. : milestone, 4348,
iast (9.163 ms) : 9002, 9323
. : milestone, 9163,
iast_FULL (14.394 ms) : 14105, 14684
. : milestone, 14394,
iast_GLOBAL (10.199 ms) : 10007, 10392
. : milestone, 10199,
profiling (9.374 ms) : 9199, 9548
. : milestone, 9374,
tracing (7.544 ms) : 7429, 7658
. : milestone, 7544,
section candidate
no_agent (4.48 ms) : 4430, 4530
. : milestone, 4480,
iast (9.432 ms) : 9276, 9588
. : milestone, 9432,
iast_FULL (14.036 ms) : 13758, 14314
. : milestone, 14036,
iast_GLOBAL (10.496 ms) : 10303, 10690
. : milestone, 10496,
profiling (8.807 ms) : 8659, 8954
. : milestone, 8807,
tracing (7.485 ms) : 7381, 7589
. : milestone, 7485,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~da962336df, baseline=1.51.1-SNAPSHOT~766af685ed
dateFormat X
axisFormat %s
section baseline
no_agent (37.261 ms) : 36958, 37563
. : milestone, 37261,
appsec (49.653 ms) : 49208, 50098
. : milestone, 49653,
code_origins (45.948 ms) : 45546, 46349
. : milestone, 45948,
iast (44.743 ms) : 44358, 45129
. : milestone, 44743,
profiling (50.231 ms) : 49768, 50694
. : milestone, 50231,
tracing (42.833 ms) : 42461, 43205
. : milestone, 42833,
section candidate
no_agent (38.425 ms) : 38108, 38742
. : milestone, 38425,
appsec (47.177 ms) : 46748, 47607
. : milestone, 47177,
code_origins (43.798 ms) : 43441, 44156
. : milestone, 43798,
iast (44.029 ms) : 43652, 44406
. : milestone, 44029,
profiling (48.645 ms) : 48179, 49112
. : milestone, 48645,
tracing (42.291 ms) : 41926, 42657
. : milestone, 42291,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~da962336df, baseline=1.51.1-SNAPSHOT~766af685ed
dateFormat X
axisFormat %s
section baseline
no_agent (15.488 s) : 15488000, 15488000
. : milestone, 15488000,
appsec (15.232 s) : 15232000, 15232000
. : milestone, 15232000,
iast (18.437 s) : 18437000, 18437000
. : milestone, 18437000,
iast_GLOBAL (17.757 s) : 17757000, 17757000
. : milestone, 17757000,
profiling (15.033 s) : 15033000, 15033000
. : milestone, 15033000,
tracing (14.818 s) : 14818000, 14818000
. : milestone, 14818000,
section candidate
no_agent (15.529 s) : 15529000, 15529000
. : milestone, 15529000,
appsec (14.94 s) : 14940000, 14940000
. : milestone, 14940000,
iast (18.269 s) : 18269000, 18269000
. : milestone, 18269000,
iast_GLOBAL (17.954 s) : 17954000, 17954000
. : milestone, 17954000,
profiling (15.105 s) : 15105000, 15105000
. : milestone, 15105000,
tracing (14.867 s) : 14867000, 14867000
. : milestone, 14867000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~da962336df, baseline=1.51.1-SNAPSHOT~766af685ed
dateFormat X
axisFormat %s
section baseline
no_agent (1.471 ms) : 1459, 1482
. : milestone, 1471,
appsec (3.676 ms) : 3458, 3894
. : milestone, 3676,
iast (2.191 ms) : 2129, 2254
. : milestone, 2191,
iast_GLOBAL (2.246 ms) : 2183, 2309
. : milestone, 2246,
profiling (2.038 ms) : 1987, 2089
. : milestone, 2038,
tracing (2.013 ms) : 1965, 2062
. : milestone, 2013,
section candidate
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (2.415 ms) : 2365, 2464
. : milestone, 2415,
iast (2.203 ms) : 2141, 2266
. : milestone, 2203,
iast_GLOBAL (2.238 ms) : 2175, 2300
. : milestone, 2238,
profiling (2.044 ms) : 1994, 2094
. : milestone, 2044,
tracing (2.02 ms) : 1971, 2069
. : milestone, 2020,
|
Kafka / consumer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved because all the commits have already been approved and merged in separate pull requests.
This is
v1.51.1
with the following PRs merged in:#9151
#9137
See this ticket for details.