-
Notifications
You must be signed in to change notification settings - Fork 311
Fix duplicate trace injection for SQL Server and Oracle DBM full propagation mode #9224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 12 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.1-SNAPSHOT~49207b33ee, baseline=1.51.1-SNAPSHOT~8fc887a655
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.044 s) : 0, 1043735
Total [baseline] (10.72 s) : 0, 10720140
Agent [candidate] (1.044 s) : 0, 1043921
Total [candidate] (10.689 s) : 0, 10688668
section appsec
Agent [baseline] (1.225 s) : 0, 1225217
Total [baseline] (10.763 s) : 0, 10763123
Agent [candidate] (1.216 s) : 0, 1216157
Total [candidate] (10.876 s) : 0, 10876343
section iast
Agent [baseline] (1.186 s) : 0, 1185702
Total [baseline] (10.986 s) : 0, 10985970
Agent [candidate] (1.172 s) : 0, 1172173
Total [candidate] (10.941 s) : 0, 10941195
section profiling
Agent [baseline] (1.194 s) : 0, 1193885
Total [baseline] (10.919 s) : 0, 10918629
Agent [candidate] (1.182 s) : 0, 1181840
Total [candidate] (10.861 s) : 0, 10860555
gantt
title petclinic - break down per module: candidate=1.51.1-SNAPSHOT~49207b33ee, baseline=1.51.1-SNAPSHOT~8fc887a655
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.445 ms) : 0, 1445
crashtracking [candidate] (1.439 ms) : 0, 1439
BytebuddyAgent [baseline] (730.633 ms) : 0, 730633
BytebuddyAgent [candidate] (733.386 ms) : 0, 733386
GlobalTracer [baseline] (241.596 ms) : 0, 241596
GlobalTracer [candidate] (242.541 ms) : 0, 242541
AppSec [baseline] (30.458 ms) : 0, 30458
AppSec [candidate] (30.551 ms) : 0, 30551
Debugger [baseline] (5.976 ms) : 0, 5976
Debugger [candidate] (6.022 ms) : 0, 6022
Remote Config [baseline] (654.175 µs) : 0, 654
Remote Config [candidate] (661.126 µs) : 0, 661
Telemetry [baseline] (11.855 ms) : 0, 11855
Telemetry [candidate] (8.218 ms) : 0, 8218
section appsec
crashtracking [baseline] (1.434 ms) : 0, 1434
crashtracking [candidate] (1.43 ms) : 0, 1430
BytebuddyAgent [baseline] (755.842 ms) : 0, 755842
BytebuddyAgent [candidate] (750.342 ms) : 0, 750342
GlobalTracer [baseline] (235.977 ms) : 0, 235977
GlobalTracer [candidate] (234.143 ms) : 0, 234143
IAST [baseline] (23.731 ms) : 0, 23731
IAST [candidate] (23.39 ms) : 0, 23390
AppSec [baseline] (170.653 ms) : 0, 170653
AppSec [candidate] (167.498 ms) : 0, 167498
Debugger [baseline] (7.224 ms) : 0, 7224
Debugger [candidate] (7.151 ms) : 0, 7151
Remote Config [baseline] (624.727 µs) : 0, 625
Remote Config [candidate] (600.786 µs) : 0, 601
Telemetry [baseline] (8.37 ms) : 0, 8370
Telemetry [candidate] (10.346 ms) : 0, 10346
section iast
crashtracking [baseline] (1.445 ms) : 0, 1445
crashtracking [candidate] (1.424 ms) : 0, 1424
BytebuddyAgent [baseline] (856.653 ms) : 0, 856653
BytebuddyAgent [candidate] (846.297 ms) : 0, 846297
GlobalTracer [baseline] (233.493 ms) : 0, 233493
GlobalTracer [candidate] (231.055 ms) : 0, 231055
IAST [baseline] (30.937 ms) : 0, 30937
IAST [candidate] (28.202 ms) : 0, 28202
AppSec [baseline] (26.664 ms) : 0, 26664
AppSec [candidate] (28.325 ms) : 0, 28325
Debugger [baseline] (6.692 ms) : 0, 6692
Debugger [candidate] (7.474 ms) : 0, 7474
Remote Config [baseline] (594.785 µs) : 0, 595
Remote Config [candidate] (585.391 µs) : 0, 585
Telemetry [baseline] (8.17 ms) : 0, 8170
Telemetry [candidate] (7.873 ms) : 0, 7873
section profiling
crashtracking [baseline] (1.393 ms) : 0, 1393
crashtracking [candidate] (1.397 ms) : 0, 1397
BytebuddyAgent [baseline] (761.266 ms) : 0, 761266
BytebuddyAgent [candidate] (757.349 ms) : 0, 757349
GlobalTracer [baseline] (221.182 ms) : 0, 221182
GlobalTracer [candidate] (220.021 ms) : 0, 220021
AppSec [baseline] (30.292 ms) : 0, 30292
AppSec [candidate] (30.066 ms) : 0, 30066
Debugger [baseline] (6.213 ms) : 0, 6213
Debugger [candidate] (6.257 ms) : 0, 6257
Remote Config [baseline] (680.832 µs) : 0, 681
Remote Config [candidate] (677.847 µs) : 0, 678
Telemetry [baseline] (15.191 ms) : 0, 15191
Telemetry [candidate] (15.438 ms) : 0, 15438
ProfilingAgent [baseline] (109.131 ms) : 0, 109131
ProfilingAgent [candidate] (102.192 ms) : 0, 102192
Profiling [baseline] (109.155 ms) : 0, 109155
Profiling [candidate] (102.214 ms) : 0, 102214
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.1-SNAPSHOT~49207b33ee, baseline=1.51.1-SNAPSHOT~8fc887a655
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1051237
Total [baseline] (8.624 s) : 0, 8624464
Agent [candidate] (1.039 s) : 0, 1038675
Total [candidate] (8.659 s) : 0, 8658774
section iast
Agent [baseline] (1.184 s) : 0, 1184469
Total [baseline] (9.42 s) : 0, 9420175
Agent [candidate] (1.17 s) : 0, 1170167
Total [candidate] (9.296 s) : 0, 9295551
gantt
title insecure-bank - break down per module: candidate=1.51.1-SNAPSHOT~49207b33ee, baseline=1.51.1-SNAPSHOT~8fc887a655
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.443 ms) : 0, 1443
crashtracking [candidate] (1.43 ms) : 0, 1430
BytebuddyAgent [baseline] (735.29 ms) : 0, 735290
BytebuddyAgent [candidate] (729.33 ms) : 0, 729330
GlobalTracer [baseline] (243.346 ms) : 0, 243346
GlobalTracer [candidate] (241.616 ms) : 0, 241616
AppSec [baseline] (30.761 ms) : 0, 30761
AppSec [candidate] (30.441 ms) : 0, 30441
Debugger [baseline] (6.002 ms) : 0, 6002
Debugger [candidate] (5.997 ms) : 0, 5997
Remote Config [baseline] (659.486 µs) : 0, 659
Remote Config [candidate] (647.314 µs) : 0, 647
Telemetry [baseline] (12.616 ms) : 0, 12616
Telemetry [candidate] (8.233 ms) : 0, 8233
section iast
crashtracking [baseline] (1.434 ms) : 0, 1434
crashtracking [candidate] (1.437 ms) : 0, 1437
BytebuddyAgent [baseline] (854.684 ms) : 0, 854684
BytebuddyAgent [candidate] (844.884 ms) : 0, 844884
GlobalTracer [baseline] (233.605 ms) : 0, 233605
GlobalTracer [candidate] (230.783 ms) : 0, 230783
IAST [baseline] (28.749 ms) : 0, 28749
IAST [candidate] (30.461 ms) : 0, 30461
AppSec [baseline] (28.514 ms) : 0, 28514
AppSec [candidate] (27.4 ms) : 0, 27400
Debugger [baseline] (7.555 ms) : 0, 7555
Debugger [candidate] (5.795 ms) : 0, 5795
Remote Config [baseline] (610.347 µs) : 0, 610
Remote Config [candidate] (622.839 µs) : 0, 623
Telemetry [baseline] (8.285 ms) : 0, 8285
Telemetry [candidate] (7.926 ms) : 0, 7926
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~49207b33ee, baseline=1.51.1-SNAPSHOT~8fc887a655
dateFormat X
axisFormat %s
section baseline
no_agent (4.473 ms) : 4416, 4529
. : milestone, 4473,
iast (9.433 ms) : 9276, 9591
. : milestone, 9433,
iast_FULL (13.549 ms) : 13279, 13819
. : milestone, 13549,
iast_GLOBAL (10.289 ms) : 10109, 10468
. : milestone, 10289,
profiling (8.961 ms) : 8824, 9098
. : milestone, 8961,
tracing (7.532 ms) : 7425, 7639
. : milestone, 7532,
section candidate
no_agent (4.291 ms) : 4242, 4340
. : milestone, 4291,
iast (9.429 ms) : 9276, 9583
. : milestone, 9429,
iast_FULL (13.957 ms) : 13679, 14235
. : milestone, 13957,
iast_GLOBAL (10.603 ms) : 10415, 10790
. : milestone, 10603,
profiling (8.67 ms) : 8535, 8806
. : milestone, 8670,
tracing (7.468 ms) : 7356, 7581
. : milestone, 7468,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~49207b33ee, baseline=1.51.1-SNAPSHOT~8fc887a655
dateFormat X
axisFormat %s
section baseline
no_agent (38.284 ms) : 37972, 38596
. : milestone, 38284,
appsec (47.646 ms) : 47224, 48068
. : milestone, 47646,
code_origins (46.01 ms) : 45611, 46409
. : milestone, 46010,
iast (44.758 ms) : 44366, 45151
. : milestone, 44758,
profiling (48.803 ms) : 48342, 49263
. : milestone, 48803,
tracing (43.306 ms) : 42933, 43678
. : milestone, 43306,
section candidate
no_agent (36.67 ms) : 36380, 36960
. : milestone, 36670,
appsec (48.638 ms) : 48206, 49071
. : milestone, 48638,
code_origins (45.394 ms) : 45004, 45785
. : milestone, 45394,
iast (43.474 ms) : 43089, 43859
. : milestone, 43474,
profiling (48.039 ms) : 47597, 48480
. : milestone, 48039,
tracing (43.017 ms) : 42652, 43383
. : milestone, 43017,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~49207b33ee, baseline=1.51.1-SNAPSHOT~8fc887a655
dateFormat X
axisFormat %s
section baseline
no_agent (1.48 ms) : 1469, 1492
. : milestone, 1480,
appsec (3.697 ms) : 3478, 3917
. : milestone, 3697,
iast (2.221 ms) : 2158, 2283
. : milestone, 2221,
iast_GLOBAL (2.251 ms) : 2188, 2314
. : milestone, 2251,
profiling (2.062 ms) : 2011, 2114
. : milestone, 2062,
tracing (2.041 ms) : 1992, 2090
. : milestone, 2041,
section candidate
no_agent (1.486 ms) : 1474, 1498
. : milestone, 1486,
appsec (3.657 ms) : 3440, 3875
. : milestone, 3657,
iast (2.207 ms) : 2145, 2270
. : milestone, 2207,
iast_GLOBAL (2.254 ms) : 2191, 2318
. : milestone, 2254,
profiling (2.074 ms) : 2022, 2127
. : milestone, 2074,
tracing (2.045 ms) : 1995, 2094
. : milestone, 2045,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~49207b33ee, baseline=1.51.1-SNAPSHOT~8fc887a655
dateFormat X
axisFormat %s
section baseline
no_agent (15.424 s) : 15424000, 15424000
. : milestone, 15424000,
appsec (14.722 s) : 14722000, 14722000
. : milestone, 14722000,
iast (18.328 s) : 18328000, 18328000
. : milestone, 18328000,
iast_GLOBAL (18.06 s) : 18060000, 18060000
. : milestone, 18060000,
profiling (15.186 s) : 15186000, 15186000
. : milestone, 15186000,
tracing (14.883 s) : 14883000, 14883000
. : milestone, 14883000,
section candidate
no_agent (15.677 s) : 15677000, 15677000
. : milestone, 15677000,
appsec (15.103 s) : 15103000, 15103000
. : milestone, 15103000,
iast (18.498 s) : 18498000, 18498000
. : milestone, 18498000,
iast_GLOBAL (18.158 s) : 18158000, 18158000
. : milestone, 18158000,
profiling (15.771 s) : 15771000, 15771000
. : milestone, 15771000,
tracing (15.21 s) : 15210000, 15210000
. : milestone, 15210000,
|
Is this PR related to issue? |
@AlexeyKuznetsov-DD No that's a separate issue |
What Does This Do
Fixes duplicate trace context injection for SQL Server and Oracle databases when using DBM full propagation mode.
Motivation
SQL Server and Oracle use alternative methods for trace propagation:
When DBM propagation mode is set to "full", these databases were incorrectly getting trace context injected both through their native methods and through SQL comments. This causes high occurrence of SQL hard parsing causing CPU issues.
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: