Replace `shipkit-auto-version` by custom version plugin #9228

bric3 · 2025-07-23T17:58:28Z

What Does This Do

Supersedes #9149 by using custom version plugin. shipkit-auto-version works well, but doesn't allow to configure which part of the version to bump, in our case the minor version or the patch version depending on the branch.

On any branch, get last tag
- if no additional commit use this tag for version.
- if additional commit use this tag for version, and increment minor
On release/v* branch, get last tag
- if no additional commit use this tag for version.
- if additional commit use this tag for version, and increment patch
If on CI don't check dirtyness
If local (not on CI), check dirtyness
Handles git worktree
Handles non git repo (e.g. repository zip archive), by emitting 0.1.0-SNAPSHOT

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

github-actions · 2025-07-23T17:58:38Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

pr-commenter · 2025-07-23T18:35:15Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bdu/custom-auto-version
git_commit_date	1754058594	1754063180
git_commit_sha	`023e525`	`fa7617c`
release_version	1.51.1-SNAPSHOT~023e5251a6	1.52.0-SNAPSHOT~fa7617cfc5

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1754065041	1754065041
ci_job_id	1060458251	1060458251
ci_pipeline_id	72450696	72450696
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-2-dubwuekf 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-2-dubwuekf 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 11 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.52.0-SNAPSHOT~fa7617cfc5, baseline=1.51.1-SNAPSHOT~023e5251a6

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.043 s) : 0, 1042716
Total [baseline] (8.618 s) : 0, 8617700
Agent [candidate] (1.041 s) : 0, 1041324
Total [candidate] (8.574 s) : 0, 8574256
section iast
Agent [baseline] (1.19 s) : 0, 1190255
Total [baseline] (9.366 s) : 0, 9365617
Agent [candidate] (1.171 s) : 0, 1171092
Total [candidate] (9.327 s) : 0, 9326686

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.043 s	-
Agent	iast	1.19 s	147.539 ms (14.1%)
Total	tracing	8.618 s	-
Total	iast	9.366 s	747.917 ms (8.7%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.041 s	-
Agent	iast	1.171 s	129.768 ms (12.5%)
Total	tracing	8.574 s	-
Total	iast	9.327 s	752.431 ms (8.8%)

gantt
    title insecure-bank - break down per module: candidate=1.52.0-SNAPSHOT~fa7617cfc5, baseline=1.51.1-SNAPSHOT~023e5251a6

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.424 ms) : 0, 1424
crashtracking [candidate] (1.423 ms) : 0, 1423
BytebuddyAgent [baseline] (728.541 ms) : 0, 728541
BytebuddyAgent [candidate] (728.227 ms) : 0, 728227
GlobalTracer [baseline] (242.218 ms) : 0, 242218
GlobalTracer [candidate] (241.581 ms) : 0, 241581
AppSec [baseline] (30.246 ms) : 0, 30246
AppSec [candidate] (29.881 ms) : 0, 29881
Debugger [baseline] (6.071 ms) : 0, 6071
Debugger [candidate] (6.017 ms) : 0, 6017
Remote Config [baseline] (654.89 µs) : 0, 655
Remote Config [candidate] (649.805 µs) : 0, 650
Telemetry [baseline] (12.661 ms) : 0, 12661
Telemetry [candidate] (12.554 ms) : 0, 12554
section iast
crashtracking [baseline] (1.458 ms) : 0, 1458
crashtracking [candidate] (1.429 ms) : 0, 1429
BytebuddyAgent [baseline] (861.552 ms) : 0, 861552
BytebuddyAgent [candidate] (845.785 ms) : 0, 845785
GlobalTracer [baseline] (233.726 ms) : 0, 233726
GlobalTracer [candidate] (230.711 ms) : 0, 230711
IAST [baseline] (27.678 ms) : 0, 27678
IAST [candidate] (28.074 ms) : 0, 28074
AppSec [baseline] (28.151 ms) : 0, 28151
AppSec [candidate] (27.832 ms) : 0, 27832
Debugger [baseline] (7.599 ms) : 0, 7599
Debugger [candidate] (7.59 ms) : 0, 7590
Remote Config [baseline] (598.752 µs) : 0, 599
Remote Config [candidate] (600.797 µs) : 0, 601
Telemetry [baseline] (8.243 ms) : 0, 8243
Telemetry [candidate] (8.055 ms) : 0, 8055

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.52.0-SNAPSHOT~fa7617cfc5, baseline=1.51.1-SNAPSHOT~023e5251a6

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.044 s) : 0, 1044170
Total [baseline] (10.786 s) : 0, 10786177
Agent [candidate] (1.043 s) : 0, 1042793
Total [candidate] (10.665 s) : 0, 10665334
section appsec
Agent [baseline] (1.221 s) : 0, 1221422
Total [baseline] (10.758 s) : 0, 10758237
Agent [candidate] (1.221 s) : 0, 1221191
Total [candidate] (10.732 s) : 0, 10731643
section iast
Agent [baseline] (1.181 s) : 0, 1180547
Total [baseline] (11.009 s) : 0, 11009020
Agent [candidate] (1.192 s) : 0, 1191777
Total [candidate] (10.978 s) : 0, 10978458
section profiling
Agent [baseline] (1.191 s) : 0, 1191156
Total [baseline] (10.888 s) : 0, 10888079
Agent [candidate] (1.192 s) : 0, 1191652
Total [candidate] (10.872 s) : 0, 10872167

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.044 s	-
Agent	appsec	1.221 s	177.252 ms (17.0%)
Agent	iast	1.181 s	136.377 ms (13.1%)
Agent	profiling	1.191 s	146.986 ms (14.1%)
Total	tracing	10.786 s	-
Total	appsec	10.758 s	-27.94 ms (-0.3%)
Total	iast	11.009 s	222.843 ms (2.1%)
Total	profiling	10.888 s	101.901 ms (0.9%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.043 s	-
Agent	appsec	1.221 s	178.398 ms (17.1%)
Agent	iast	1.192 s	148.984 ms (14.3%)
Agent	profiling	1.192 s	148.859 ms (14.3%)
Total	tracing	10.665 s	-
Total	appsec	10.732 s	66.31 ms (0.6%)
Total	iast	10.978 s	313.125 ms (2.9%)
Total	profiling	10.872 s	206.833 ms (1.9%)

gantt
    title petclinic - break down per module: candidate=1.52.0-SNAPSHOT~fa7617cfc5, baseline=1.51.1-SNAPSHOT~023e5251a6

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.43 ms) : 0, 1430
crashtracking [candidate] (1.439 ms) : 0, 1439
BytebuddyAgent [baseline] (732.224 ms) : 0, 732224
BytebuddyAgent [candidate] (730.629 ms) : 0, 730629
GlobalTracer [baseline] (241.29 ms) : 0, 241290
GlobalTracer [candidate] (241.291 ms) : 0, 241291
AppSec [baseline] (30.161 ms) : 0, 30161
AppSec [candidate] (29.872 ms) : 0, 29872
Debugger [baseline] (6.065 ms) : 0, 6065
Debugger [candidate] (6.049 ms) : 0, 6049
Remote Config [baseline] (653.711 µs) : 0, 654
Remote Config [candidate] (650.512 µs) : 0, 651
Telemetry [baseline] (11.257 ms) : 0, 11257
Telemetry [candidate] (11.162 ms) : 0, 11162
section appsec
crashtracking [baseline] (1.435 ms) : 0, 1435
crashtracking [candidate] (1.444 ms) : 0, 1444
BytebuddyAgent [baseline] (754.681 ms) : 0, 754681
BytebuddyAgent [candidate] (753.763 ms) : 0, 753763
GlobalTracer [baseline] (235.13 ms) : 0, 235130
GlobalTracer [candidate] (235.373 ms) : 0, 235373
IAST [baseline] (23.734 ms) : 0, 23734
IAST [candidate] (23.675 ms) : 0, 23675
AppSec [baseline] (168.748 ms) : 0, 168748
AppSec [candidate] (169.803 ms) : 0, 169803
Debugger [baseline] (7.806 ms) : 0, 7806
Debugger [candidate] (7.224 ms) : 0, 7224
Remote Config [baseline] (606.189 µs) : 0, 606
Remote Config [candidate] (609.911 µs) : 0, 610
Telemetry [baseline] (8.204 ms) : 0, 8204
Telemetry [candidate] (8.217 ms) : 0, 8217
section iast
crashtracking [baseline] (1.436 ms) : 0, 1436
crashtracking [candidate] (1.473 ms) : 0, 1473
BytebuddyAgent [baseline] (853.311 ms) : 0, 853311
BytebuddyAgent [candidate] (861.188 ms) : 0, 861188
GlobalTracer [baseline] (231.854 ms) : 0, 231854
GlobalTracer [candidate] (233.998 ms) : 0, 233998
IAST [baseline] (29.402 ms) : 0, 29402
IAST [candidate] (26.562 ms) : 0, 26562
AppSec [baseline] (27.927 ms) : 0, 27927
AppSec [candidate] (30.762 ms) : 0, 30762
Debugger [baseline] (6.661 ms) : 0, 6661
Debugger [candidate] (7.528 ms) : 0, 7528
Remote Config [baseline] (597.448 µs) : 0, 597
Remote Config [candidate] (606.231 µs) : 0, 606
Telemetry [baseline] (8.196 ms) : 0, 8196
Telemetry [candidate] (8.3 ms) : 0, 8300
section profiling
crashtracking [baseline] (1.407 ms) : 0, 1407
crashtracking [candidate] (1.402 ms) : 0, 1402
BytebuddyAgent [baseline] (759.147 ms) : 0, 759147
BytebuddyAgent [candidate] (759.274 ms) : 0, 759274
GlobalTracer [baseline] (220.678 ms) : 0, 220678
GlobalTracer [candidate] (220.978 ms) : 0, 220978
AppSec [baseline] (29.852 ms) : 0, 29852
AppSec [candidate] (29.871 ms) : 0, 29871
Debugger [baseline] (6.215 ms) : 0, 6215
Debugger [candidate] (6.324 ms) : 0, 6324
Remote Config [baseline] (693.44 µs) : 0, 693
Remote Config [candidate] (660.353 µs) : 0, 660
Telemetry [baseline] (16.057 ms) : 0, 16057
Telemetry [candidate] (16.021 ms) : 0, 16021
ProfilingAgent [baseline] (107.678 ms) : 0, 107678
ProfilingAgent [candidate] (107.822 ms) : 0, 107822
Profiling [baseline] (108.316 ms) : 0, 108316
Profiling [candidate] (108.481 ms) : 0, 108481

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bdu/custom-auto-version
git_commit_date	1754058594	1754063180
git_commit_sha	`023e525`	`fa7617c`
release_version	1.51.1-SNAPSHOT~023e5251a6	1.52.0-SNAPSHOT~fa7617cfc5

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1754064626	1754064626
ci_job_id	1060458252	1060458252
ci_pipeline_id	72450696	72450696
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-2-iujc3pk8 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-2-iujc3pk8 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 2 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:iast:high_load	better [-641.530µs; -305.816µs] or [-6.735%; -3.211%]	unstable [-57.357op/s; +77.095op/s] or [-11.770%; +15.821%]	9.051ms	497.182op/s	9.525ms	487.312op/s
scenario:load:insecure-bank:profiling:high_load	worse [+193.328µs; +505.788µs] or [+2.232%; +5.838%]	unstable [-111.350op/s; +39.640op/s] or [-20.805%; +7.406%]	9.013ms	499.364op/s	8.663ms	535.219op/s
scenario:load:petclinic:no_agent:high_load	worse [+0.746ms; +1.377ms] or [+2.098%; +3.872%]	unstable [-13.635op/s; +2.633op/s] or [-10.246%; +1.978%]	36.637ms	127.575op/s	35.575ms	133.076op/s

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~fa7617cfc5, baseline=1.51.1-SNAPSHOT~023e5251a6
    dateFormat X
    axisFormat %s
section baseline
no_agent (35.575 ms) : 35289, 35861
.   : milestone, 35575,
appsec (46.994 ms) : 46563, 47426
.   : milestone, 46994,
code_origins (44.639 ms) : 44260, 45018
.   : milestone, 44639,
iast (44.697 ms) : 44307, 45088
.   : milestone, 44697,
profiling (48.139 ms) : 47663, 48615
.   : milestone, 48139,
tracing (44.185 ms) : 43809, 44561
.   : milestone, 44185,
section candidate
no_agent (36.637 ms) : 36337, 36937
.   : milestone, 36637,
appsec (47.044 ms) : 46621, 47466
.   : milestone, 47044,
code_origins (44.97 ms) : 44585, 45355
.   : milestone, 44970,
iast (45.31 ms) : 44923, 45697
.   : milestone, 45310,
profiling (48.499 ms) : 48058, 48941
.   : milestone, 48499,
tracing (43.536 ms) : 43169, 43903
.   : milestone, 43536,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	35.575 ms [35.289 ms, 35.861 ms]	-
appsec	46.994 ms [46.563 ms, 47.426 ms]	11.419 ms (32.1%)
code_origins	44.639 ms [44.26 ms, 45.018 ms]	9.064 ms (25.5%)
iast	44.697 ms [44.307 ms, 45.088 ms]	9.122 ms (25.6%)
profiling	48.139 ms [47.663 ms, 48.615 ms]	12.564 ms (35.3%)
tracing	44.185 ms [43.809 ms, 44.561 ms]	8.61 ms (24.2%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	36.637 ms [36.337 ms, 36.937 ms]	-
appsec	47.044 ms [46.621 ms, 47.466 ms]	10.407 ms (28.4%)
code_origins	44.97 ms [44.585 ms, 45.355 ms]	8.333 ms (22.7%)
iast	45.31 ms [44.923 ms, 45.697 ms]	8.673 ms (23.7%)
profiling	48.499 ms [48.058 ms, 48.941 ms]	11.862 ms (32.4%)
tracing	43.536 ms [43.169 ms, 43.903 ms]	6.899 ms (18.8%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~fa7617cfc5, baseline=1.51.1-SNAPSHOT~023e5251a6
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.532 ms) : 4478, 4586
.   : milestone, 4532,
iast (9.525 ms) : 9360, 9690
.   : milestone, 9525,
iast_FULL (14.24 ms) : 13959, 14521
.   : milestone, 14240,
iast_GLOBAL (10.284 ms) : 10106, 10463
.   : milestone, 10284,
profiling (8.663 ms) : 8523, 8804
.   : milestone, 8663,
tracing (7.593 ms) : 7485, 7701
.   : milestone, 7593,
section candidate
no_agent (4.404 ms) : 4356, 4453
.   : milestone, 4404,
iast (9.051 ms) : 8905, 9197
.   : milestone, 9051,
iast_FULL (14.627 ms) : 14332, 14923
.   : milestone, 14627,
iast_GLOBAL (10.029 ms) : 9840, 10218
.   : milestone, 10029,
profiling (9.013 ms) : 8863, 9163
.   : milestone, 9013,
tracing (7.768 ms) : 7648, 7887
.   : milestone, 7768,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.532 ms [4.478 ms, 4.586 ms]	-
iast	9.525 ms [9.36 ms, 9.69 ms]	4.993 ms (110.2%)
iast_FULL	14.24 ms [13.959 ms, 14.521 ms]	9.708 ms (214.2%)
iast_GLOBAL	10.284 ms [10.106 ms, 10.463 ms]	5.752 ms (126.9%)
profiling	8.663 ms [8.523 ms, 8.804 ms]	4.131 ms (91.2%)
tracing	7.593 ms [7.485 ms, 7.701 ms]	3.061 ms (67.5%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.404 ms [4.356 ms, 4.453 ms]	-
iast	9.051 ms [8.905 ms, 9.197 ms]	4.647 ms (105.5%)
iast_FULL	14.627 ms [14.332 ms, 14.923 ms]	10.223 ms (232.1%)
iast_GLOBAL	10.029 ms [9.84 ms, 10.218 ms]	5.625 ms (127.7%)
profiling	9.013 ms [8.863 ms, 9.163 ms]	4.609 ms (104.6%)
tracing	7.768 ms [7.648 ms, 7.887 ms]	3.363 ms (76.4%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bdu/custom-auto-version
git_commit_date	1754058594	1754063180
git_commit_sha	`023e525`	`fa7617c`
release_version	1.51.1-SNAPSHOT~023e5251a6	1.52.0-SNAPSHOT~fa7617cfc5

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1754065138	1754065138
ci_job_id	1060458253	1060458253
ci_pipeline_id	72450696	72450696
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-3-nopvykv3 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-3-nopvykv3 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~fa7617cfc5, baseline=1.51.1-SNAPSHOT~023e5251a6
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.476 ms) : 1464, 1487
.   : milestone, 1476,
appsec (3.663 ms) : 3448, 3879
.   : milestone, 3663,
iast (2.196 ms) : 2133, 2258
.   : milestone, 2196,
iast_GLOBAL (2.237 ms) : 2174, 2300
.   : milestone, 2237,
profiling (2.475 ms) : 2310, 2640
.   : milestone, 2475,
tracing (2.011 ms) : 1962, 2059
.   : milestone, 2011,
section candidate
no_agent (1.476 ms) : 1464, 1487
.   : milestone, 1476,
appsec (3.574 ms) : 3363, 3784
.   : milestone, 3574,
iast (2.203 ms) : 2141, 2266
.   : milestone, 2203,
iast_GLOBAL (2.239 ms) : 2176, 2302
.   : milestone, 2239,
profiling (2.062 ms) : 2010, 2113
.   : milestone, 2062,
tracing (2.027 ms) : 1978, 2076
.   : milestone, 2027,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.476 ms [1.464 ms, 1.487 ms]	-
appsec	3.663 ms [3.448 ms, 3.879 ms]	2.188 ms (148.3%)
iast	2.196 ms [2.133 ms, 2.258 ms]	720.191 µs (48.8%)
iast_GLOBAL	2.237 ms [2.174 ms, 2.3 ms]	761.407 µs (51.6%)
profiling	2.475 ms [2.31 ms, 2.64 ms]	999.328 µs (67.7%)
tracing	2.011 ms [1.962 ms, 2.059 ms]	535.163 µs (36.3%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.476 ms [1.464 ms, 1.487 ms]	-
appsec	3.574 ms [3.363 ms, 3.784 ms]	2.098 ms (142.2%)
iast	2.203 ms [2.141 ms, 2.266 ms]	727.73 µs (49.3%)
iast_GLOBAL	2.239 ms [2.176 ms, 2.302 ms]	763.219 µs (51.7%)
profiling	2.062 ms [2.01 ms, 2.113 ms]	585.773 µs (39.7%)
tracing	2.027 ms [1.978 ms, 2.076 ms]	551.445 µs (37.4%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~fa7617cfc5, baseline=1.51.1-SNAPSHOT~023e5251a6
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.06 s) : 15060000, 15060000
.   : milestone, 15060000,
appsec (14.879 s) : 14879000, 14879000
.   : milestone, 14879000,
iast (18.523 s) : 18523000, 18523000
.   : milestone, 18523000,
iast_GLOBAL (17.904 s) : 17904000, 17904000
.   : milestone, 17904000,
profiling (15.456 s) : 15456000, 15456000
.   : milestone, 15456000,
tracing (15.039 s) : 15039000, 15039000
.   : milestone, 15039000,
section candidate
no_agent (14.943 s) : 14943000, 14943000
.   : milestone, 14943000,
appsec (14.835 s) : 14835000, 14835000
.   : milestone, 14835000,
iast (18.852 s) : 18852000, 18852000
.   : milestone, 18852000,
iast_GLOBAL (18.089 s) : 18089000, 18089000
.   : milestone, 18089000,
profiling (15.309 s) : 15309000, 15309000
.   : milestone, 15309000,
tracing (14.85 s) : 14850000, 14850000
.   : milestone, 14850000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.06 s [15.06 s, 15.06 s]	-
appsec	14.879 s [14.879 s, 14.879 s]	-181.0 ms (-1.2%)
iast	18.523 s [18.523 s, 18.523 s]	3.463 s (23.0%)
iast_GLOBAL	17.904 s [17.904 s, 17.904 s]	2.844 s (18.9%)
profiling	15.456 s [15.456 s, 15.456 s]	396.0 ms (2.6%)
tracing	15.039 s [15.039 s, 15.039 s]	-21.0 ms (-0.1%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.943 s [14.943 s, 14.943 s]	-
appsec	14.835 s [14.835 s, 14.835 s]	-108.0 ms (-0.7%)
iast	18.852 s [18.852 s, 18.852 s]	3.909 s (26.2%)
iast_GLOBAL	18.089 s [18.089 s, 18.089 s]	3.146 s (21.1%)
profiling	15.309 s [15.309 s, 15.309 s]	366.0 ms (2.4%)
tracing	14.85 s [14.85 s, 14.85 s]	-93.0 ms (-0.6%)

PerfectSlayer

Quick review. Happy to have another pair of eyes on it.

A quick question remains: can we test it in some way? 🤷
No pushing hard for testing, but interested to know if there would be a way 🤔

PerfectSlayer · 2025-07-24T07:15:14Z

buildSrc/src/main/kotlin/datadog/gradle/plugin/version/GitDescribeValueSource.kt

+      "--abbrev=8",
+      "--tags",
+      "--first-parent",
+      "--match=$tagPrefix[0-9].[0-9]*.[0-9]",


Suggested change

"--match=$tagPrefix[0-9].[0-9]*.[0-9]",

"--match=$tagPrefix[0-9].[0-9]*.[0-9]*",

Don't under estimate how many patches a release can have 😅

I've looked at the tags, and I didn't see any version with more digits. However I did notice some pre-release labels like -PROF1-SNAPSHOT, -alpha, -RC1.

I believe this is currently fine as the goal of describe is to look at the latest GA version. And maybe increment from it. Supporting semver pre-release could be added if needed ?

buildSrc/src/main/kotlin/datadog/gradle/plugin/version/TracerVersionPlugin.kt

bric3 · 2025-07-24T11:17:15Z

A quick question remains: can we test it in some way?

I can probably take a look at testing it next week.

# Conflicts: # build.gradle

…ests

buildSrc/src/integTest/kotlin/datadog/gradle/plugin/version/TracerVersionIntegrationTest.kt

buildSrc/src/main/kotlin/datadog/gradle/plugin/version/TracerVersionPlugin.kt

sarahchen6 · 2025-07-30T19:49:23Z

I'm not totally familiar with the implementation details, but based on the test cases and their results, looks good!

bric3

thx for the review @sarahchen6

buildSrc/src/integTest/kotlin/datadog/gradle/plugin/version/TracerVersionIntegrationTest.kt

buildSrc/src/main/kotlin/datadog/gradle/plugin/version/TracerVersionPlugin.kt

buildSrc/src/integTest/kotlin/datadog/gradle/plugin/version/TracerVersionIntegrationTest.kt

PerfectSlayer

Looking great! Lots of improvement compared to the original solution (the axiom thing)
Left few comments 🗒️

buildSrc/src/main/kotlin/datadog/gradle/plugin/version/GitCommandValueSource.kt

PerfectSlayer · 2025-07-31T14:22:03Z

buildSrc/src/main/kotlin/datadog/gradle/plugin/version/GitCommandValueSource.kt

+    when {
+      result.exitValue == 128 &&
+        (output.startsWith("fatal: not a git repository")
+          || output.startsWith("fatal: No names found, cannot describe anything."))


Question: where the "no names" thing come from?

Good question, it's git messages. The issue is that when the process fails, here git, it fails with a statuscode, git "handled" failure exists with 128, but there might be various reasons.

I identified two messages that I think are ok to return the default version. And I choose to fail in other cases.

Frankly, this is not great, and a bit fragile for internalized git messages. But since we are using company laptop I assume all company laptops use english. Also, I expect these errors should be rare enough.

buildSrc/src/main/kotlin/datadog/gradle/plugin/version/TracerVersionPlugin.kt

gradle/libs.versions.toml

buildSrc/build.gradle.kts

datadog-datadog-prod-us1 · 2025-07-31T15:49:33Z

Code coverage: total 57.09%, patch 100.00% (view details)

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: fa7617c | Docs | Was this helpful? Give us feedback!}

PerfectSlayer

Thanks for the follow up updates 👍

bric3 requested a review from a team as a code owner July 23, 2025 17:58

bric3 requested a review from dougqh July 23, 2025 17:58

bric3 added tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Jul 23, 2025

bric3 requested a review from PerfectSlayer July 23, 2025 18:03

PerfectSlayer reviewed Jul 24, 2025

View reviewed changes

bric3 force-pushed the bdu/custom-auto-version branch from d1625a0 to dc5ebd9 Compare July 24, 2025 11:09

bric3 changed the title ~~Replace shipkit-auto-version by custom version plugin~~ Replace shipkit-auto-version by custom version plugin Jul 28, 2025

bric3 force-pushed the bdu/custom-auto-version branch 2 times, most recently from 8261595 to 1cd9c1e Compare July 30, 2025 13:08

bric3 added 5 commits July 30, 2025 15:50

chore: Replace shipkit-auto-version by custom version plugin

5ca8d3b

# Conflicts: # build.gradle

chore: Tracer version increments patch when on "release/v* branch

9c67028

chore: Tracer version detects dirtiness on local builds, not on CI

9a8ba7b

chore: Tracer version plugin tests

a5431e5

chore: Make the property ignore buildSrc test only, not integration t…

a44e3a1

…ests

bric3 force-pushed the bdu/custom-auto-version branch from 1cd9c1e to a44e3a1 Compare July 30, 2025 13:51

sarahchen6 reviewed Jul 30, 2025

View reviewed changes

buildSrc/src/integTest/kotlin/datadog/gradle/plugin/version/TracerVersionIntegrationTest.kt Show resolved Hide resolved

sarahchen6 reviewed Jul 30, 2025

View reviewed changes

buildSrc/src/integTest/kotlin/datadog/gradle/plugin/version/TracerVersionIntegrationTest.kt Outdated Show resolved Hide resolved

sarahchen6 reviewed Jul 30, 2025

View reviewed changes

buildSrc/src/main/kotlin/datadog/gradle/plugin/version/TracerVersionPlugin.kt Outdated Show resolved Hide resolved

bric3 commented Jul 30, 2025

View reviewed changes

bric3 added 2 commits July 31, 2025 01:46

chore: Apply PR suggestions from code review

d01b8f3

Merge branch 'master' into bdu/custom-auto-version

539e33a

sarahchen6 approved these changes Jul 31, 2025

View reviewed changes

PerfectSlayer reviewed Jul 31, 2025

View reviewed changes

chore: Suggestions from code review

f937869

bric3 added 3 commits August 1, 2025 15:40

Merge branch 'master' into bdu/custom-auto-version

3c28831

chore: Don't declare the assertj library in the main catalog just yet

f6457f1

Merge branch 'master' into bdu/custom-auto-version

fa7617c

PerfectSlayer approved these changes Aug 4, 2025

View reviewed changes

bric3 merged commit 7b908a5 into master Aug 4, 2025
692 of 694 checks passed

bric3 deleted the bdu/custom-auto-version branch August 4, 2025 10:59

github-actions bot added this to the 1.52.0 milestone Aug 4, 2025

	"--match=$tagPrefix[0-9].[0-9]*.[0-9]",
	"--match=$tagPrefix[0-9].[0-9].[0-9]",

Replace shipkit-auto-version by custom version plugin #9228

Replace shipkit-auto-version by custom version plugin #9228

Uh oh!

Conversation

bric3 commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

github-actions bot commented Jul 23, 2025

Uh oh!

pr-commenter bot commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

PerfectSlayer left a comment

Choose a reason for hiding this comment

Uh oh!

PerfectSlayer Jul 24, 2025

Choose a reason for hiding this comment

Uh oh!

bric3 Jul 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bric3 commented Jul 24, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sarahchen6 commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bric3 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PerfectSlayer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

PerfectSlayer Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

bric3 Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

datadog-datadog-prod-us1 bot commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PerfectSlayer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Replace `shipkit-auto-version` by custom version plugin #9228

Replace `shipkit-auto-version` by custom version plugin #9228

bric3 commented Jul 23, 2025 •

edited

Loading

pr-commenter bot commented Jul 23, 2025 •

edited

Loading

sarahchen6 commented Jul 30, 2025 •

edited

Loading

bric3 Jul 31, 2025 •

edited

Loading

datadog-datadog-prod-us1 bot commented Jul 31, 2025 •

edited

Loading