Skip to content

Conversation

mhlidd
Copy link
Contributor

@mhlidd mhlidd commented Jul 24, 2025

What Does This Do

As part of Config Inversion, we want to emit Telemetry metrics for all environment variables set that are DD related but not documented in the supported-configurations.json file. This PR introduces the Telemetry metrics component for Config Inversion. Given that the ConfigHelper and supported-configurations.json file do not exist yet, testing is done with a lightweight "Mock" helper that has a list of "supported configurations", and emits a telemetry metric if an environment variable is passed in that is not "supported".

Motivation

Config Inversion RFC

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@pr-commenter
Copy link

pr-commenter bot commented Jul 24, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mhlidd/config_inversion_telemetry
git_commit_date 1754414697 1754417782
git_commit_sha 2f4f626 ab574be
release_version 1.53.0-SNAPSHOT~2f4f626e8e 1.52.0-SNAPSHOT~ab574be87d
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1754419496 1754419496
ci_job_id 1065500266 1065500266
ci_pipeline_id 72765939 72765939
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-0k3o62sf 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-0k3o62sf 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 10 unstable metrics.

Startup time reports for insecure-bank
gantt
    title insecure-bank - global startup overhead: candidate=1.52.0-SNAPSHOT~ab574be87d, baseline=1.53.0-SNAPSHOT~2f4f626e8e

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1056370
Total [baseline] (8.696 s) : 0, 8695892
Agent [candidate] (1.046 s) : 0, 1045713
Total [candidate] (8.584 s) : 0, 8583826
section iast
Agent [baseline] (1.173 s) : 0, 1173483
Total [baseline] (9.325 s) : 0, 9325029
Agent [candidate] (1.175 s) : 0, 1174863
Total [candidate] (9.311 s) : 0, 9311439
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.056 s -
Agent iast 1.173 s 117.113 ms (11.1%)
Total tracing 8.696 s -
Total iast 9.325 s 629.137 ms (7.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.046 s -
Agent iast 1.175 s 129.15 ms (12.4%)
Total tracing 8.584 s -
Total iast 9.311 s 727.614 ms (8.5%)
gantt
    title insecure-bank - break down per module: candidate=1.52.0-SNAPSHOT~ab574be87d, baseline=1.53.0-SNAPSHOT~2f4f626e8e

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.438 ms) : 0, 1438
crashtracking [candidate] (1.425 ms) : 0, 1425
BytebuddyAgent [baseline] (739.345 ms) : 0, 739345
BytebuddyAgent [candidate] (730.174 ms) : 0, 730174
GlobalTracer [baseline] (243.763 ms) : 0, 243763
GlobalTracer [candidate] (242.439 ms) : 0, 242439
AppSec [baseline] (30.491 ms) : 0, 30491
AppSec [candidate] (30.122 ms) : 0, 30122
Debugger [baseline] (6.083 ms) : 0, 6083
Debugger [candidate] (6.037 ms) : 0, 6037
Remote Config [baseline] (651.787 µs) : 0, 652
Remote Config [candidate] (643.786 µs) : 0, 644
Telemetry [baseline] (13.496 ms) : 0, 13496
Telemetry [candidate] (13.957 ms) : 0, 13957
section iast
crashtracking [baseline] (1.424 ms) : 0, 1424
crashtracking [candidate] (1.42 ms) : 0, 1420
BytebuddyAgent [baseline] (847.254 ms) : 0, 847254
BytebuddyAgent [candidate] (848.053 ms) : 0, 848053
GlobalTracer [baseline] (232.439 ms) : 0, 232439
GlobalTracer [candidate] (232.109 ms) : 0, 232109
AppSec [baseline] (27.864 ms) : 0, 27864
AppSec [candidate] (27.768 ms) : 0, 27768
Debugger [baseline] (5.816 ms) : 0, 5816
Debugger [candidate] (5.828 ms) : 0, 5828
Remote Config [baseline] (585.536 µs) : 0, 586
Remote Config [candidate] (589.061 µs) : 0, 589
Telemetry [baseline] (8.12 ms) : 0, 8120
Telemetry [candidate] (8.294 ms) : 0, 8294
IAST [baseline] (29.043 ms) : 0, 29043
IAST [candidate] (29.852 ms) : 0, 29852
Loading
Startup time reports for petclinic
gantt
    title petclinic - global startup overhead: candidate=1.52.0-SNAPSHOT~ab574be87d, baseline=1.53.0-SNAPSHOT~2f4f626e8e

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1046464
Total [baseline] (10.756 s) : 0, 10756309
Agent [candidate] (1.046 s) : 0, 1045761
Total [candidate] (10.756 s) : 0, 10755527
section appsec
Agent [baseline] (1.219 s) : 0, 1218785
Total [baseline] (10.851 s) : 0, 10850993
Agent [candidate] (1.23 s) : 0, 1230313
Total [candidate] (10.815 s) : 0, 10815201
section iast
Agent [baseline] (1.183 s) : 0, 1182969
Total [baseline] (10.886 s) : 0, 10885715
Agent [candidate] (1.176 s) : 0, 1175856
Total [candidate] (10.956 s) : 0, 10956473
section profiling
Agent [baseline] (1.204 s) : 0, 1204394
Total [baseline] (10.901 s) : 0, 10901489
Agent [candidate] (1.193 s) : 0, 1192761
Total [candidate] (10.933 s) : 0, 10933438
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.046 s -
Agent appsec 1.219 s 172.321 ms (16.5%)
Agent iast 1.183 s 136.504 ms (13.0%)
Agent profiling 1.204 s 157.93 ms (15.1%)
Total tracing 10.756 s -
Total appsec 10.851 s 94.684 ms (0.9%)
Total iast 10.886 s 129.407 ms (1.2%)
Total profiling 10.901 s 145.18 ms (1.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.046 s -
Agent appsec 1.23 s 184.552 ms (17.6%)
Agent iast 1.176 s 130.095 ms (12.4%)
Agent profiling 1.193 s 147.0 ms (14.1%)
Total tracing 10.756 s -
Total appsec 10.815 s 59.673 ms (0.6%)
Total iast 10.956 s 200.946 ms (1.9%)
Total profiling 10.933 s 177.911 ms (1.7%)
gantt
    title petclinic - break down per module: candidate=1.52.0-SNAPSHOT~ab574be87d, baseline=1.53.0-SNAPSHOT~2f4f626e8e

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.429 ms) : 0, 1429
crashtracking [candidate] (1.463 ms) : 0, 1463
BytebuddyAgent [baseline] (731.558 ms) : 0, 731558
BytebuddyAgent [candidate] (731.495 ms) : 0, 731495
GlobalTracer [baseline] (242.183 ms) : 0, 242183
GlobalTracer [candidate] (242.31 ms) : 0, 242310
AppSec [baseline] (30.154 ms) : 0, 30154
AppSec [candidate] (30.035 ms) : 0, 30035
Debugger [baseline] (6.021 ms) : 0, 6021
Debugger [candidate] (6.007 ms) : 0, 6007
Remote Config [baseline] (648.334 µs) : 0, 648
Remote Config [candidate] (646.295 µs) : 0, 646
Telemetry [baseline] (13.39 ms) : 0, 13390
Telemetry [candidate] (12.791 ms) : 0, 12791
section appsec
crashtracking [baseline] (1.428 ms) : 0, 1428
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (751.702 ms) : 0, 751702
BytebuddyAgent [candidate] (759.226 ms) : 0, 759226
GlobalTracer [baseline] (234.854 ms) : 0, 234854
GlobalTracer [candidate] (237.079 ms) : 0, 237079
IAST [baseline] (23.504 ms) : 0, 23504
IAST [candidate] (23.842 ms) : 0, 23842
AppSec [baseline] (168.46 ms) : 0, 168460
AppSec [candidate] (168.801 ms) : 0, 168801
Debugger [baseline] (8.838 ms) : 0, 8838
Debugger [candidate] (8.71 ms) : 0, 8710
Remote Config [baseline] (617.428 µs) : 0, 617
Remote Config [candidate] (625.577 µs) : 0, 626
Telemetry [baseline] (8.363 ms) : 0, 8363
Telemetry [candidate] (9.311 ms) : 0, 9311
section iast
crashtracking [baseline] (1.441 ms) : 0, 1441
crashtracking [candidate] (1.423 ms) : 0, 1423
BytebuddyAgent [baseline] (855.025 ms) : 0, 855025
BytebuddyAgent [candidate] (847.017 ms) : 0, 847017
GlobalTracer [baseline] (233.333 ms) : 0, 233333
GlobalTracer [candidate] (233.177 ms) : 0, 233177
IAST [baseline] (28.864 ms) : 0, 28864
IAST [candidate] (30.114 ms) : 0, 30114
AppSec [baseline] (26.95 ms) : 0, 26950
AppSec [candidate] (27.402 ms) : 0, 27402
Debugger [baseline] (7.548 ms) : 0, 7548
Debugger [candidate] (6.738 ms) : 0, 6738
Remote Config [baseline] (586.755 µs) : 0, 587
Remote Config [candidate] (597.877 µs) : 0, 598
Telemetry [baseline] (8.144 ms) : 0, 8144
Telemetry [candidate] (8.383 ms) : 0, 8383
section profiling
crashtracking [baseline] (1.406 ms) : 0, 1406
crashtracking [candidate] (1.404 ms) : 0, 1404
BytebuddyAgent [baseline] (767.794 ms) : 0, 767794
BytebuddyAgent [candidate] (760.001 ms) : 0, 760001
GlobalTracer [baseline] (223.866 ms) : 0, 223866
GlobalTracer [candidate] (221.68 ms) : 0, 221680
AppSec [baseline] (30.286 ms) : 0, 30286
AppSec [candidate] (29.954 ms) : 0, 29954
Debugger [baseline] (6.35 ms) : 0, 6350
Debugger [candidate] (6.269 ms) : 0, 6269
Remote Config [baseline] (694.9 µs) : 0, 695
Remote Config [candidate] (690.789 µs) : 0, 691
Telemetry [baseline] (15.944 ms) : 0, 15944
Telemetry [candidate] (15.944 ms) : 0, 15944
ProfilingAgent [baseline] (108.232 ms) : 0, 108232
ProfilingAgent [candidate] (107.588 ms) : 0, 107588
Profiling [baseline] (108.866 ms) : 0, 108866
Profiling [candidate] (108.225 ms) : 0, 108225
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mhlidd/config_inversion_telemetry
git_commit_date 1754414697 1754417782
git_commit_sha 2f4f626 ab574be
release_version 1.53.0-SNAPSHOT~2f4f626e8e 1.52.0-SNAPSHOT~ab574be87d
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1754419173 1754419173
ci_job_id 1065500267 1065500267
ci_pipeline_id 72765939 72765939
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-um3adlz1 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-um3adlz1 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 2 performance improvements and 3 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:insecure-bank:iast_GLOBAL:high_load worse
[+204.576µs; +586.980µs] or [+2.089%; +5.994%]
unstable
[-75.004op/s; +38.442op/s] or [-15.814%; +8.105%]
10.189ms 456.000op/s 9.793ms 474.281op/s
scenario:load:insecure-bank:profiling:high_load better
[-890.464µs; -567.552µs] or [-9.538%; -6.079%]
unstable
[-27.813op/s; +110.875op/s] or [-5.593%; +22.298%]
8.607ms 538.781op/s 9.336ms 497.250op/s
scenario:load:petclinic:appsec:high_load better
[-2.701ms; -1.753ms] or [-5.424%; -3.519%]
unstable
[-2.795op/s; +11.495op/s] or [-2.972%; +12.224%]
47.572ms 98.388op/s 49.799ms 94.037op/s
scenario:load:petclinic:profiling:high_load worse
[+1.219ms; +2.122ms] or [+2.607%; +4.540%]
unstable
[-10.319op/s; +3.444op/s] or [-10.305%; +3.439%]
48.411ms 96.700op/s 46.741ms 100.138op/s
scenario:load:petclinic:tracing:high_load worse
[+2.014ms; +2.837ms] or [+4.683%; +6.596%]
unstable
[-13.230op/s; +1.680op/s] or [-12.164%; +1.544%]
45.440ms 102.987op/s 43.015ms 108.763op/s
Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~ab574be87d, baseline=1.53.0-SNAPSHOT~2f4f626e8e
    dateFormat X
    axisFormat %s
section baseline
no_agent (37.509 ms) : 37205, 37813
.   : milestone, 37509,
appsec (49.799 ms) : 49352, 50246
.   : milestone, 49799,
code_origins (44.289 ms) : 43894, 44684
.   : milestone, 44289,
iast (45.957 ms) : 45557, 46357
.   : milestone, 45957,
profiling (46.741 ms) : 46335, 47147
.   : milestone, 46741,
tracing (43.015 ms) : 42641, 43388
.   : milestone, 43015,
section candidate
no_agent (36.804 ms) : 36503, 37105
.   : milestone, 36804,
appsec (47.572 ms) : 47138, 48006
.   : milestone, 47572,
code_origins (44.592 ms) : 44198, 44986
.   : milestone, 44592,
iast (44.716 ms) : 44332, 45099
.   : milestone, 44716,
profiling (48.411 ms) : 47978, 48845
.   : milestone, 48411,
tracing (45.44 ms) : 45049, 45831
.   : milestone, 45440,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 37.509 ms [37.205 ms, 37.813 ms] -
appsec 49.799 ms [49.352 ms, 50.246 ms] 12.29 ms (32.8%)
code_origins 44.289 ms [43.894 ms, 44.684 ms] 6.78 ms (18.1%)
iast 45.957 ms [45.557 ms, 46.357 ms] 8.448 ms (22.5%)
profiling 46.741 ms [46.335 ms, 47.147 ms] 9.232 ms (24.6%)
tracing 43.015 ms [42.641 ms, 43.388 ms] 5.506 ms (14.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 36.804 ms [36.503 ms, 37.105 ms] -
appsec 47.572 ms [47.138 ms, 48.006 ms] 10.768 ms (29.3%)
code_origins 44.592 ms [44.198 ms, 44.986 ms] 7.788 ms (21.2%)
iast 44.716 ms [44.332 ms, 45.099 ms] 7.912 ms (21.5%)
profiling 48.411 ms [47.978 ms, 48.845 ms] 11.607 ms (31.5%)
tracing 45.44 ms [45.049 ms, 45.831 ms] 8.636 ms (23.5%)
Request duration reports for insecure-bank
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~ab574be87d, baseline=1.53.0-SNAPSHOT~2f4f626e8e
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.429 ms) : 4377, 4480
.   : milestone, 4429,
iast (9.393 ms) : 9234, 9552
.   : milestone, 9393,
iast_FULL (13.846 ms) : 13572, 14119
.   : milestone, 13846,
iast_GLOBAL (9.793 ms) : 9623, 9963
.   : milestone, 9793,
profiling (9.336 ms) : 9180, 9493
.   : milestone, 9336,
tracing (7.668 ms) : 7551, 7785
.   : milestone, 7668,
section candidate
no_agent (4.432 ms) : 4375, 4488
.   : milestone, 4432,
iast (9.244 ms) : 9096, 9393
.   : milestone, 9244,
iast_FULL (13.624 ms) : 13358, 13891
.   : milestone, 13624,
iast_GLOBAL (10.189 ms) : 10004, 10374
.   : milestone, 10189,
profiling (8.607 ms) : 8464, 8750
.   : milestone, 8607,
tracing (7.543 ms) : 7436, 7650
.   : milestone, 7543,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.429 ms [4.377 ms, 4.48 ms] -
iast 9.393 ms [9.234 ms, 9.552 ms] 4.964 ms (112.1%)
iast_FULL 13.846 ms [13.572 ms, 14.119 ms] 9.417 ms (212.6%)
iast_GLOBAL 9.793 ms [9.623 ms, 9.963 ms] 5.364 ms (121.1%)
profiling 9.336 ms [9.18 ms, 9.493 ms] 4.907 ms (110.8%)
tracing 7.668 ms [7.551 ms, 7.785 ms] 3.239 ms (73.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.432 ms [4.375 ms, 4.488 ms] -
iast 9.244 ms [9.096 ms, 9.393 ms] 4.812 ms (108.6%)
iast_FULL 13.624 ms [13.358 ms, 13.891 ms] 9.193 ms (207.4%)
iast_GLOBAL 10.189 ms [10.004 ms, 10.374 ms] 5.757 ms (129.9%)
profiling 8.607 ms [8.464 ms, 8.75 ms] 4.175 ms (94.2%)
tracing 7.543 ms [7.436 ms, 7.65 ms] 3.111 ms (70.2%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mhlidd/config_inversion_telemetry
git_commit_date 1754414697 1754417782
git_commit_sha 2f4f626 ab574be
release_version 1.53.0-SNAPSHOT~2f4f626e8e 1.52.0-SNAPSHOT~ab574be87d
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1754419635 1754419635
ci_job_id 1065500268 1065500268
ci_pipeline_id 72765939 72765939
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-t7jwzg1m 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-t7jwzg1m 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:dacapo:tomcat:appsec better
[-1.364ms; -1.022ms] or [-37.103%; -27.808%]
2.483ms 3.676ms
Execution time for tomcat
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~ab574be87d, baseline=1.53.0-SNAPSHOT~2f4f626e8e
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.483 ms) : 1471, 1494
.   : milestone, 1483,
appsec (3.676 ms) : 3458, 3894
.   : milestone, 3676,
iast (2.207 ms) : 2144, 2271
.   : milestone, 2207,
iast_GLOBAL (2.262 ms) : 2198, 2326
.   : milestone, 2262,
profiling (2.058 ms) : 2007, 2108
.   : milestone, 2058,
tracing (2.026 ms) : 1977, 2075
.   : milestone, 2026,
section candidate
no_agent (1.479 ms) : 1468, 1491
.   : milestone, 1479,
appsec (2.483 ms) : 2430, 2536
.   : milestone, 2483,
iast (2.225 ms) : 2161, 2288
.   : milestone, 2225,
iast_GLOBAL (2.253 ms) : 2189, 2316
.   : milestone, 2253,
profiling (2.05 ms) : 1999, 2102
.   : milestone, 2050,
tracing (2.035 ms) : 1986, 2084
.   : milestone, 2035,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.483 ms [1.471 ms, 1.494 ms] -
appsec 3.676 ms [3.458 ms, 3.894 ms] 2.194 ms (148.0%)
iast 2.207 ms [2.144 ms, 2.271 ms] 724.708 µs (48.9%)
iast_GLOBAL 2.262 ms [2.198 ms, 2.326 ms] 779.55 µs (52.6%)
profiling 2.058 ms [2.007 ms, 2.108 ms] 574.951 µs (38.8%)
tracing 2.026 ms [1.977 ms, 2.075 ms] 543.368 µs (36.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.479 ms [1.468 ms, 1.491 ms] -
appsec 2.483 ms [2.43 ms, 2.536 ms] 1.004 ms (67.9%)
iast 2.225 ms [2.161 ms, 2.288 ms] 745.408 µs (50.4%)
iast_GLOBAL 2.253 ms [2.189 ms, 2.316 ms] 773.597 µs (52.3%)
profiling 2.05 ms [1.999 ms, 2.102 ms] 571.254 µs (38.6%)
tracing 2.035 ms [1.986 ms, 2.084 ms] 555.53 µs (37.6%)
Execution time for biojava
gantt
    title biojava - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~ab574be87d, baseline=1.53.0-SNAPSHOT~2f4f626e8e
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.264 s) : 15264000, 15264000
.   : milestone, 15264000,
appsec (14.863 s) : 14863000, 14863000
.   : milestone, 14863000,
iast (18.412 s) : 18412000, 18412000
.   : milestone, 18412000,
iast_GLOBAL (18.231 s) : 18231000, 18231000
.   : milestone, 18231000,
profiling (15.303 s) : 15303000, 15303000
.   : milestone, 15303000,
tracing (14.899 s) : 14899000, 14899000
.   : milestone, 14899000,
section candidate
no_agent (15.327 s) : 15327000, 15327000
.   : milestone, 15327000,
appsec (14.701 s) : 14701000, 14701000
.   : milestone, 14701000,
iast (18.722 s) : 18722000, 18722000
.   : milestone, 18722000,
iast_GLOBAL (18.219 s) : 18219000, 18219000
.   : milestone, 18219000,
profiling (15.437 s) : 15437000, 15437000
.   : milestone, 15437000,
tracing (15.059 s) : 15059000, 15059000
.   : milestone, 15059000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.264 s [15.264 s, 15.264 s] -
appsec 14.863 s [14.863 s, 14.863 s] -401.0 ms (-2.6%)
iast 18.412 s [18.412 s, 18.412 s] 3.148 s (20.6%)
iast_GLOBAL 18.231 s [18.231 s, 18.231 s] 2.967 s (19.4%)
profiling 15.303 s [15.303 s, 15.303 s] 39.0 ms (0.3%)
tracing 14.899 s [14.899 s, 14.899 s] -365.0 ms (-2.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.327 s [15.327 s, 15.327 s] -
appsec 14.701 s [14.701 s, 14.701 s] -626.0 ms (-4.1%)
iast 18.722 s [18.722 s, 18.722 s] 3.395 s (22.2%)
iast_GLOBAL 18.219 s [18.219 s, 18.219 s] 2.892 s (18.9%)
profiling 15.437 s [15.437 s, 15.437 s] 110.0 ms (0.7%)
tracing 15.059 s [15.059 s, 15.059 s] -268.0 ms (-1.7%)

@mhlidd mhlidd marked this pull request as ready for review July 26, 2025 02:57
@mhlidd mhlidd requested review from a team as code owners July 26, 2025 02:57
@mhlidd mhlidd requested review from dougqh and removed request for a team July 26, 2025 02:57
Copy link
Contributor

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@mhlidd mhlidd requested a review from mcculls July 26, 2025 02:57
@mhlidd mhlidd added type: enhancement Enhancements and improvements comp: telemetry Telemetry labels Jul 28, 2025

class ConfigInversionMetricPeriodicActionTest extends Specification{

void 'test otel env var hiding metric'() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test name doesn't match what it tests

Copy link
Contributor

@mcculls mcculls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the test method name before merging - thanks

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Aug 5, 2025

Code coverage: total 57.25%, base diff 0.00%, patch 91.67% (view details)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: ab574be | Docs | Was this helpful? Give us feedback!

@mhlidd mhlidd merged commit d6b43cb into master Aug 5, 2025
505 checks passed
@mhlidd mhlidd deleted the mhlidd/config_inversion_telemetry branch August 5, 2025 19:49
@github-actions github-actions bot added this to the 1.53.0 milestone Aug 5, 2025
Comment on lines +1 to +4
kotlin version: 2.0.21
error message: The daemon has terminated unexpectedly on startup attempt #1 with error code: 0. The daemon process output:
1. Kotlin compile daemon is ready

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, is this file should be in Git?
Probably we need to add some new rule to .gitignore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh... good point. I'll open a PR to remove it and add to gitignore. Thanks for catching this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: telemetry Telemetry type: enhancement Enhancements and improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants