-
Notifications
You must be signed in to change notification settings - Fork 312
Adding Config Inversion Telemetry component #9244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 10 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.52.0-SNAPSHOT~ab574be87d, baseline=1.53.0-SNAPSHOT~2f4f626e8e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1056370
Total [baseline] (8.696 s) : 0, 8695892
Agent [candidate] (1.046 s) : 0, 1045713
Total [candidate] (8.584 s) : 0, 8583826
section iast
Agent [baseline] (1.173 s) : 0, 1173483
Total [baseline] (9.325 s) : 0, 9325029
Agent [candidate] (1.175 s) : 0, 1174863
Total [candidate] (9.311 s) : 0, 9311439
gantt
title insecure-bank - break down per module: candidate=1.52.0-SNAPSHOT~ab574be87d, baseline=1.53.0-SNAPSHOT~2f4f626e8e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.438 ms) : 0, 1438
crashtracking [candidate] (1.425 ms) : 0, 1425
BytebuddyAgent [baseline] (739.345 ms) : 0, 739345
BytebuddyAgent [candidate] (730.174 ms) : 0, 730174
GlobalTracer [baseline] (243.763 ms) : 0, 243763
GlobalTracer [candidate] (242.439 ms) : 0, 242439
AppSec [baseline] (30.491 ms) : 0, 30491
AppSec [candidate] (30.122 ms) : 0, 30122
Debugger [baseline] (6.083 ms) : 0, 6083
Debugger [candidate] (6.037 ms) : 0, 6037
Remote Config [baseline] (651.787 µs) : 0, 652
Remote Config [candidate] (643.786 µs) : 0, 644
Telemetry [baseline] (13.496 ms) : 0, 13496
Telemetry [candidate] (13.957 ms) : 0, 13957
section iast
crashtracking [baseline] (1.424 ms) : 0, 1424
crashtracking [candidate] (1.42 ms) : 0, 1420
BytebuddyAgent [baseline] (847.254 ms) : 0, 847254
BytebuddyAgent [candidate] (848.053 ms) : 0, 848053
GlobalTracer [baseline] (232.439 ms) : 0, 232439
GlobalTracer [candidate] (232.109 ms) : 0, 232109
AppSec [baseline] (27.864 ms) : 0, 27864
AppSec [candidate] (27.768 ms) : 0, 27768
Debugger [baseline] (5.816 ms) : 0, 5816
Debugger [candidate] (5.828 ms) : 0, 5828
Remote Config [baseline] (585.536 µs) : 0, 586
Remote Config [candidate] (589.061 µs) : 0, 589
Telemetry [baseline] (8.12 ms) : 0, 8120
Telemetry [candidate] (8.294 ms) : 0, 8294
IAST [baseline] (29.043 ms) : 0, 29043
IAST [candidate] (29.852 ms) : 0, 29852
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.52.0-SNAPSHOT~ab574be87d, baseline=1.53.0-SNAPSHOT~2f4f626e8e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1046464
Total [baseline] (10.756 s) : 0, 10756309
Agent [candidate] (1.046 s) : 0, 1045761
Total [candidate] (10.756 s) : 0, 10755527
section appsec
Agent [baseline] (1.219 s) : 0, 1218785
Total [baseline] (10.851 s) : 0, 10850993
Agent [candidate] (1.23 s) : 0, 1230313
Total [candidate] (10.815 s) : 0, 10815201
section iast
Agent [baseline] (1.183 s) : 0, 1182969
Total [baseline] (10.886 s) : 0, 10885715
Agent [candidate] (1.176 s) : 0, 1175856
Total [candidate] (10.956 s) : 0, 10956473
section profiling
Agent [baseline] (1.204 s) : 0, 1204394
Total [baseline] (10.901 s) : 0, 10901489
Agent [candidate] (1.193 s) : 0, 1192761
Total [candidate] (10.933 s) : 0, 10933438
gantt
title petclinic - break down per module: candidate=1.52.0-SNAPSHOT~ab574be87d, baseline=1.53.0-SNAPSHOT~2f4f626e8e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.429 ms) : 0, 1429
crashtracking [candidate] (1.463 ms) : 0, 1463
BytebuddyAgent [baseline] (731.558 ms) : 0, 731558
BytebuddyAgent [candidate] (731.495 ms) : 0, 731495
GlobalTracer [baseline] (242.183 ms) : 0, 242183
GlobalTracer [candidate] (242.31 ms) : 0, 242310
AppSec [baseline] (30.154 ms) : 0, 30154
AppSec [candidate] (30.035 ms) : 0, 30035
Debugger [baseline] (6.021 ms) : 0, 6021
Debugger [candidate] (6.007 ms) : 0, 6007
Remote Config [baseline] (648.334 µs) : 0, 648
Remote Config [candidate] (646.295 µs) : 0, 646
Telemetry [baseline] (13.39 ms) : 0, 13390
Telemetry [candidate] (12.791 ms) : 0, 12791
section appsec
crashtracking [baseline] (1.428 ms) : 0, 1428
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (751.702 ms) : 0, 751702
BytebuddyAgent [candidate] (759.226 ms) : 0, 759226
GlobalTracer [baseline] (234.854 ms) : 0, 234854
GlobalTracer [candidate] (237.079 ms) : 0, 237079
IAST [baseline] (23.504 ms) : 0, 23504
IAST [candidate] (23.842 ms) : 0, 23842
AppSec [baseline] (168.46 ms) : 0, 168460
AppSec [candidate] (168.801 ms) : 0, 168801
Debugger [baseline] (8.838 ms) : 0, 8838
Debugger [candidate] (8.71 ms) : 0, 8710
Remote Config [baseline] (617.428 µs) : 0, 617
Remote Config [candidate] (625.577 µs) : 0, 626
Telemetry [baseline] (8.363 ms) : 0, 8363
Telemetry [candidate] (9.311 ms) : 0, 9311
section iast
crashtracking [baseline] (1.441 ms) : 0, 1441
crashtracking [candidate] (1.423 ms) : 0, 1423
BytebuddyAgent [baseline] (855.025 ms) : 0, 855025
BytebuddyAgent [candidate] (847.017 ms) : 0, 847017
GlobalTracer [baseline] (233.333 ms) : 0, 233333
GlobalTracer [candidate] (233.177 ms) : 0, 233177
IAST [baseline] (28.864 ms) : 0, 28864
IAST [candidate] (30.114 ms) : 0, 30114
AppSec [baseline] (26.95 ms) : 0, 26950
AppSec [candidate] (27.402 ms) : 0, 27402
Debugger [baseline] (7.548 ms) : 0, 7548
Debugger [candidate] (6.738 ms) : 0, 6738
Remote Config [baseline] (586.755 µs) : 0, 587
Remote Config [candidate] (597.877 µs) : 0, 598
Telemetry [baseline] (8.144 ms) : 0, 8144
Telemetry [candidate] (8.383 ms) : 0, 8383
section profiling
crashtracking [baseline] (1.406 ms) : 0, 1406
crashtracking [candidate] (1.404 ms) : 0, 1404
BytebuddyAgent [baseline] (767.794 ms) : 0, 767794
BytebuddyAgent [candidate] (760.001 ms) : 0, 760001
GlobalTracer [baseline] (223.866 ms) : 0, 223866
GlobalTracer [candidate] (221.68 ms) : 0, 221680
AppSec [baseline] (30.286 ms) : 0, 30286
AppSec [candidate] (29.954 ms) : 0, 29954
Debugger [baseline] (6.35 ms) : 0, 6350
Debugger [candidate] (6.269 ms) : 0, 6269
Remote Config [baseline] (694.9 µs) : 0, 695
Remote Config [candidate] (690.789 µs) : 0, 691
Telemetry [baseline] (15.944 ms) : 0, 15944
Telemetry [candidate] (15.944 ms) : 0, 15944
ProfilingAgent [baseline] (108.232 ms) : 0, 108232
ProfilingAgent [candidate] (107.588 ms) : 0, 107588
Profiling [baseline] (108.866 ms) : 0, 108866
Profiling [candidate] (108.225 ms) : 0, 108225
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 3 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~ab574be87d, baseline=1.53.0-SNAPSHOT~2f4f626e8e
dateFormat X
axisFormat %s
section baseline
no_agent (37.509 ms) : 37205, 37813
. : milestone, 37509,
appsec (49.799 ms) : 49352, 50246
. : milestone, 49799,
code_origins (44.289 ms) : 43894, 44684
. : milestone, 44289,
iast (45.957 ms) : 45557, 46357
. : milestone, 45957,
profiling (46.741 ms) : 46335, 47147
. : milestone, 46741,
tracing (43.015 ms) : 42641, 43388
. : milestone, 43015,
section candidate
no_agent (36.804 ms) : 36503, 37105
. : milestone, 36804,
appsec (47.572 ms) : 47138, 48006
. : milestone, 47572,
code_origins (44.592 ms) : 44198, 44986
. : milestone, 44592,
iast (44.716 ms) : 44332, 45099
. : milestone, 44716,
profiling (48.411 ms) : 47978, 48845
. : milestone, 48411,
tracing (45.44 ms) : 45049, 45831
. : milestone, 45440,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~ab574be87d, baseline=1.53.0-SNAPSHOT~2f4f626e8e
dateFormat X
axisFormat %s
section baseline
no_agent (4.429 ms) : 4377, 4480
. : milestone, 4429,
iast (9.393 ms) : 9234, 9552
. : milestone, 9393,
iast_FULL (13.846 ms) : 13572, 14119
. : milestone, 13846,
iast_GLOBAL (9.793 ms) : 9623, 9963
. : milestone, 9793,
profiling (9.336 ms) : 9180, 9493
. : milestone, 9336,
tracing (7.668 ms) : 7551, 7785
. : milestone, 7668,
section candidate
no_agent (4.432 ms) : 4375, 4488
. : milestone, 4432,
iast (9.244 ms) : 9096, 9393
. : milestone, 9244,
iast_FULL (13.624 ms) : 13358, 13891
. : milestone, 13624,
iast_GLOBAL (10.189 ms) : 10004, 10374
. : milestone, 10189,
profiling (8.607 ms) : 8464, 8750
. : milestone, 8607,
tracing (7.543 ms) : 7436, 7650
. : milestone, 7543,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~ab574be87d, baseline=1.53.0-SNAPSHOT~2f4f626e8e
dateFormat X
axisFormat %s
section baseline
no_agent (1.483 ms) : 1471, 1494
. : milestone, 1483,
appsec (3.676 ms) : 3458, 3894
. : milestone, 3676,
iast (2.207 ms) : 2144, 2271
. : milestone, 2207,
iast_GLOBAL (2.262 ms) : 2198, 2326
. : milestone, 2262,
profiling (2.058 ms) : 2007, 2108
. : milestone, 2058,
tracing (2.026 ms) : 1977, 2075
. : milestone, 2026,
section candidate
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (2.483 ms) : 2430, 2536
. : milestone, 2483,
iast (2.225 ms) : 2161, 2288
. : milestone, 2225,
iast_GLOBAL (2.253 ms) : 2189, 2316
. : milestone, 2253,
profiling (2.05 ms) : 1999, 2102
. : milestone, 2050,
tracing (2.035 ms) : 1986, 2084
. : milestone, 2035,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~ab574be87d, baseline=1.53.0-SNAPSHOT~2f4f626e8e
dateFormat X
axisFormat %s
section baseline
no_agent (15.264 s) : 15264000, 15264000
. : milestone, 15264000,
appsec (14.863 s) : 14863000, 14863000
. : milestone, 14863000,
iast (18.412 s) : 18412000, 18412000
. : milestone, 18412000,
iast_GLOBAL (18.231 s) : 18231000, 18231000
. : milestone, 18231000,
profiling (15.303 s) : 15303000, 15303000
. : milestone, 15303000,
tracing (14.899 s) : 14899000, 14899000
. : milestone, 14899000,
section candidate
no_agent (15.327 s) : 15327000, 15327000
. : milestone, 15327000,
appsec (14.701 s) : 14701000, 14701000
. : milestone, 14701000,
iast (18.722 s) : 18722000, 18722000
. : milestone, 18722000,
iast_GLOBAL (18.219 s) : 18219000, 18219000
. : milestone, 18219000,
profiling (15.437 s) : 15437000, 15437000
. : milestone, 15437000,
tracing (15.059 s) : 15059000, 15059000
. : milestone, 15059000,
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
|
||
class ConfigInversionMetricPeriodicActionTest extends Specification{ | ||
|
||
void 'test otel env var hiding metric'() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test name doesn't match what it tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the test method name before merging - thanks
Code coverage: total 57.25%, base diff 0.00%, patch 91.67% (view details) This comment will be updated automatically if new data arrives.🔗 Commit SHA: ab574be | Docs | Was this helpful? Give us feedback! |
kotlin version: 2.0.21 | ||
error message: The daemon has terminated unexpectedly on startup attempt #1 with error code: 0. The daemon process output: | ||
1. Kotlin compile daemon is ready | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, is this file should be in Git?
Probably we need to add some new rule to .gitignore
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh... good point. I'll open a PR to remove it and add to gitignore. Thanks for catching this!
What Does This Do
As part of Config Inversion, we want to emit Telemetry metrics for all environment variables set that are DD related but not documented in the
supported-configurations.json
file. This PR introduces the Telemetry metrics component for Config Inversion. Given that theConfigHelper
andsupported-configurations.json
file do not exist yet, testing is done with a lightweight "Mock" helper that has a list of "supported configurations", and emits a telemetry metric if an environment variable is passed in that is not "supported".Motivation
Config Inversion RFC
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]