Skip to content

perf(prof): pre-reserve function name buffer #3445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

perf(prof): pre-reserve function name buffer #3445

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions profiling/src/profiling/stack_walking.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,20 @@ pub fn extract_function_name(func: &zend_function) -> Option<Cow<'static, str>>

// User functions do not have a "module". Maybe one day use composer info?
let module_name = func.module_name().unwrap_or(b"");
if !module_name.is_empty() {
let class_name = func.scope_name().unwrap_or(b"");

// Pre-reserving here avoids growing the vec in practice.
let (has_module, has_class) = (!module_name.is_empty(), !class_name.is_empty());
let module_len = has_module as usize * "|".len() + module_name.len();
let class_name_len = has_class as usize * "::".len() + class_name.len();
buffer.reserve(module_len + class_name_len + method_name.len());

if has_module {
buffer.extend_from_slice(module_name);
buffer.push(b'|');
}

let class_name = func.scope_name().unwrap_or(b"");
if !class_name.is_empty() {
if has_class {
buffer.extend_from_slice(class_name);
buffer.extend_from_slice(b"::");
}
Expand Down
Loading