-
Notifications
You must be signed in to change notification settings - Fork 167
feat(prof): build with panic=abort, std too #3478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
ecd9843 to
affd622
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3478 +/- ##
==========================================
+ Coverage 61.77% 61.79% +0.01%
==========================================
Files 142 142
Lines 12904 12904
Branches 1689 1689
==========================================
+ Hits 7972 7974 +2
+ Misses 4172 4169 -3
- Partials 760 761 +1 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
d951935 to
8576005
Compare
|
For reasons that are unclear, this comes out larger than merely doing |
These have rust-src in them. Although this PR doesn't build the std library with panic=abort, these are still the images being mirrored for our CI, so we should bump them.
042ce06 to
1f7212b
Compare
Benchmarks [ profiler ]Benchmark execution time: 2025-11-13 00:27:56 Comparing candidate commit 1f7212b in PR branch Found 0 performance improvements and 4 performance regressions! Performance is the same for 26 metrics, 6 unstable metrics. scenario:php-profiler-exceptions-control
scenario:php-profiler-timeline-memory-with-profiler-and-timeline
scenario:walk_stack/50
scenario:walk_stack/99
|
Benchmarks [ tracer ]Benchmark execution time: 2025-11-13 01:19:08 Comparing candidate commit 1f7212b in PR branch Found 2 performance improvements and 8 performance regressions! Performance is the same for 184 metrics, 0 unstable metrics. scenario:ComposerTelemetryBench/benchTelemetryParsing
scenario:ComposerTelemetryBench/benchTelemetryParsing-opcache
scenario:MessagePackSerializationBench/benchMessagePackSerialization
scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache
scenario:SamplingRuleMatchingBench/benchRegexMatching1
scenario:SamplingRuleMatchingBench/benchRegexMatching2
scenario:SamplingRuleMatchingBench/benchRegexMatching3
scenario:SamplingRuleMatchingBench/benchRegexMatching4
scenario:SpanBench/benchOpenTelemetryAPI
scenario:TraceSerializationBench/benchSerializeTrace
|
49411eb to
d4ba643
Compare
Description
This is an experiment that builds on Florian's feat(prof): switch panics to abort so that it also builds std with
panic_abort. This should give us more helpful stack traces on panics.Reviewer checklist