-
Notifications
You must be signed in to change notification settings - Fork 455
fix(redis): add compatibility with redis version 6.2.0 #14475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 291 ± 4 ms. The average import time from base is: 292 ± 6 ms. The import time difference between this PR and base is: -0.6 ± 0.2 ms. The difference is not statistically significant (z = -2.57). Import time breakdownThe following import paths have grown:
|
Performance SLOsCandidate: rachel.yang/redis-command-stack (00ea3ab) 🔵 No Baseline Data (24 suites)🔵 coreapiscenario - 12/12 (2 unstable)🔵 No baseline data available for this suite
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensuring that at least one test suite runs this test with the version of redis in question is important to ensure that the bug doesn't reoccur.
@emmettbutler Wouldn't the test run on every version of redis since I'm not limiting any versions of redis? |
@rachelyangdog looks like there's at least one instance of a test that runs with the relevant redis version, so we're fine. The lock files in
It would be helpful to understand why |
Github Issue: #13598
Checklist
Reviewer Checklist