Skip to content

Conversation

dd-octo-sts[bot]
Copy link
Contributor

@dd-octo-sts dd-octo-sts bot commented Sep 3, 2025

Backport 5b0b7c6 from #14480 to 3.10.

some of our tests hit our real staging endpoint, which itself could sometimes be flaky. following up soon with a real fix to record a response one time and serve it back (since these tests are just checking logging behavior).

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@dd-octo-sts dd-octo-sts bot requested a review from a team as a code owner September 3, 2025 13:57
@dd-octo-sts dd-octo-sts bot added the changelog/no-changelog A changelog entry is not required for this PR. label Sep 3, 2025
Copy link
Contributor

github-actions bot commented Sep 3, 2025

CODEOWNERS have been resolved as:

tests/llmobs/test_llmobs_eval_metric_agentless_writer.py                @DataDog/ml-observability
tests/llmobs/test_llmobs_evaluator_runner.py                            @DataDog/ml-observability

some of our tests hit our real staging endpoint, which itself could
sometimes be flaky. following up soon with a real fix to record a
response one time and serve it back (since these tests are just checking
logging behavior).

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 5b0b7c6)
@brettlangdon brettlangdon force-pushed the backport-14480-to-3.10 branch from b557c6c to 27cb3e0 Compare September 3, 2025 14:05
@brettlangdon brettlangdon enabled auto-merge (squash) September 3, 2025 14:06
Copy link
Contributor

github-actions bot commented Sep 3, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 279 ± 4 ms.

The average import time from base is: 280 ± 3 ms.

The import time difference between this PR and base is: -0.2 ± 0.1 ms.

The difference is not statistically significant (z = -1.45).

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.802 ms (0.65%)
ddtrace.bootstrap.sitecustomize 1.128 ms (0.40%)
ddtrace.bootstrap.preload 1.128 ms (0.40%)
ddtrace.internal.remoteconfig.client 0.615 ms (0.22%)
ddtrace 0.673 ms (0.24%)
ddtrace.internal._unpatched 0.030 ms (0.01%)
json 0.030 ms (0.01%)
json.decoder 0.030 ms (0.01%)
re 0.030 ms (0.01%)
enum 0.030 ms (0.01%)
types 0.030 ms (0.01%)

@pr-commenter
Copy link

pr-commenter bot commented Sep 3, 2025

Benchmarks

Benchmark execution time: 2025-09-03 14:56:21

Comparing candidate commit 27cb3e0 in PR branch backport-14480-to-3.10 with baseline commit 6932159 in branch 3.10.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 540 metrics, 2 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant