-
Notifications
You must be signed in to change notification settings - Fork 1.2k
AWS Lambda install page refresh #30832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ℹ️ Documentation Team ReviewNo documentation team review is required for this pull request. |
Preview links (active after the
|
Added a card for Editorial Review: DOCS-11775 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, just left some minor feedback.
Additionally, I noticed that the old addresses for the language-specific pages are giving 404
errors. Would it be possible to add aliases for the previous URLs, in case anyone has the previous locations bookmarked?
|
||
When segments of your asynchronous requests cannot propagate trace context, Datadog's [Span Auto-linking][52] feature automatically detects linked spans. | ||
|
||
To enable Span Auto-linking for [DynamoDB Change Streams][53]'s `PutItem` operation, configure primary key names for your tables. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To enable Span Auto-linking for [DynamoDB Change Streams][53]'s `PutItem` operation, configure primary key names for your tables. | |
To enable Span Auto-linking for [DynamoDB Change Streams][53]' `PutItem` operation, configure primary key names for your tables. |
{{% /tab %}} | ||
{{< /tabs >}} | ||
|
||
This enables DynamoDB `PutItem` calls to be instrumented with span pointers. Many DynamoDB API calls do not include the item's primary key fields as separate values, so they need to be provided to the tracer separately. This field is structured as a `dict` keyed by the table names as `str`. Each value is the set of primary key field names (as str) for the associated table. The set can have exactly one or two elements, depending on the table's primary key schema. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This enables DynamoDB `PutItem` calls to be instrumented with span pointers. Many DynamoDB API calls do not include the item's primary key fields as separate values, so they need to be provided to the tracer separately. This field is structured as a `dict` keyed by the table names as `str`. Each value is the set of primary key field names (as str) for the associated table. The set can have exactly one or two elements, depending on the table's primary key schema. | |
This enables DynamoDB `PutItem` calls to be instrumented with span pointers. Many DynamoDB API calls do not include the item's primary key fields as separate values, so they need to be provided to the tracer separately. The configuration above is structured as a dictionary (`dict`) or object keyed by the table names as strings (`str`). Each value is the set of primary key field names (as strings) for the associated table. The set can have exactly one or two elements, depending on the table's primary key schema. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More context on these suggestions:
- I'm not sure if it's necessary to have
dict
andstr
as literal values here, but I've spelled them out for greater accessibility - Changed
This field
toThe configuration above
because I initially thought it was referencing the primary key fields mentioned in the previous sentence. Feel free to update the wording here. - Added
or object
because Node.js doesn't have dictionaries
## Adding Custom Spans | ||
|
||
When using the [Datadog Lambda tracing layer for .NET](https://github.com/DataDog/dd-trace-dotnet-aws-lambda-layer), ensure that a second version of the .NET tracer is not also packaged with your application code. Add `ExcludeAssets` instruction to ensure this extra tracer is excluded. | ||
When using the [Datadog Lambda tracing layer for .NET][9], ensure that a second version of the .NET tracer is not also packaged with your application code. Add `ExcludeAssets` instruction to ensure this extra tracer is excluded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When using the [Datadog Lambda tracing layer for .NET][9], ensure that a second version of the .NET tracer is not also packaged with your application code. Add `ExcludeAssets` instruction to ensure this extra tracer is excluded. | |
When using the [Datadog Lambda tracing layer for .NET][9], ensure that a second version of the .NET tracer is not also packaged with your application code. Add the `ExcludeAssets` instruction to ensure this extra tracer is excluded. |
- Add custom tags to your telemetry by using the `DD_TAGS` environment variable | ||
- Configure [payload collection][11] to capture your functions' JSON request and response payloads | ||
- If you are using the Datadog Lambda Extension, turn off the Datadog Forwarder's Lambda logs | ||
- See [advanced configurations][5] for further capabilities |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- See [advanced configurations][5] for further capabilities | |
- See [Configure Serverless Monitoring for AWS Lambda][5] for further capabilities |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional suggestion here. I'm not sure if this page used to be called Advanced Configuration
, but if so, its title has changed (although it does still show Advanced Configuration
in the nav).
- Add custom tags to your telemetry by using the `DD_TAGS` environment variable | ||
- Configure [payload collection][8] to capture your functions' JSON request and response payloads | ||
- If you are using the Datadog Lambda Extension, turn off the Datadog Forwarder's Lambda logs | ||
- See [advanced configurations][3] for further capabilities |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional suggestion here to update the link text as mentioned for dotnet.md
.
- Add custom tags to your telemetry by using the `DD_TAGS` environment variable | ||
- Configure [payload collection][12] to capture your functions' JSON request and response payloads | ||
- If you are using the Datadog Lambda Extension, turn off the Datadog Forwarder's Lambda logs | ||
- See [advanced configurations][3] for further capabilities |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional suggestion here to update the link text as mentioned for dotnet.md
.
- Add custom tags to your telemetry by using the `DD_TAGS` environment variable | ||
- Configure [payload collection][12] to capture your functions' JSON request and response payloads | ||
- If you are using the Datadog Lambda Extension, turn off the Datadog Forwarder's Lambda logs | ||
- See [advanced configurations][3] for further capabilities |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional suggestion here to update the link text as mentioned for dotnet.md
.
@@ -16,19 +16,16 @@ further_reading: | |||
aliases: | |||
- /serverless/datadog_lambda_library/ruby/ | |||
- /serverless/installation/ruby | |||
- /serverless/aws_lambda/instrumentation/ruby |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- /serverless/aws_lambda/instrumentation/ruby | |
- /serverless/aws_lambda/installation/ruby |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is what's intended, but let me know if I'm missing something here
- filter or scrub sensitive information from logs or traces | ||
- Add custom tags to your telemetry by using the `DD_TAGS` environment variable | ||
- If you are using the Datadog Lambda Extension, turn off the Datadog Forwarder's Lambda logs | ||
- See [advanced configurations][6] for further capabilities |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional suggestion here to update the link text as mentioned for dotnet.md
.
|
||
## Advanced configurations | ||
|
||
After you're done with instrumentation and you've set up telemetry collection, you can use [advanced configurations][3] to: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional suggestion here to update the link text as mentioned for dotnet.md
.
What does this PR do? What is the motivation?
Updates install language pages under Serverless > AWS Lambda > Installation. Changes this section to be called Instrumentation, makes other edits to streamline.
Merge instructions
Merge readiness:
For Datadog employees:
Your branch name MUST follow the
<name>/<description>
convention and include the forward slash (/
). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.
Additional notes