-
Notifications
You must be signed in to change notification settings - Fork 1.2k
apm go: update compatible Go integrations #31418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Preview links (active after the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, just flagging some unexpected link behavior
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flagging one final link and also suggested a few updates for branding consistency. Otherwise LGTM!
| [Kafka (confluent)][53] | Fully Supported | [gopkg.in/DataDog/dd-trace-go.v1/contrib/confluentinc/confluent-kafka-go/kafka][54] | | ||
| [Kafka (confluent v2)][97] | Fully Supported | [gopkg.in/DataDog/dd-trace-go.v1/contrib/confluentinc/confluent-kafka-go/kafka.v2][98] | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| [Kafka (confluent)][53] | Fully Supported | [gopkg.in/DataDog/dd-trace-go.v1/contrib/confluentinc/confluent-kafka-go/kafka][54] | | |
| [Kafka (confluent v2)][97] | Fully Supported | [gopkg.in/DataDog/dd-trace-go.v1/contrib/confluentinc/confluent-kafka-go/kafka.v2][98] | | |
| [Kafka (Confluent)][53] | Fully Supported | [gopkg.in/DataDog/dd-trace-go.v1/contrib/confluentinc/confluent-kafka-go/kafka][54] | | |
| [Kafka (Confluent v2)][97] | Fully Supported | [gopkg.in/DataDog/dd-trace-go.v1/contrib/confluentinc/confluent-kafka-go/kafka.v2][98] | |
@@ -64,9 +64,14 @@ Supported frameworks have changed between v1 and v2 of the Go Tracer | |||
| [Gin][6] | Fully Supported | [github.com/DataDog/dd-trace-go/contrib/gin-gonic/gin/v2][80] | | |||
| [Gorilla Mux][8] | Fully Supported | [github.com/DataDog/dd-trace-go/contrib/gorilla/mux/v2][81] | | |||
| [gRPC][10] | Fully Supported | [github.com/DataDog/dd-trace-go/contrib/google.golang.org/grpc/v2][82] | | |||
| [chi][13] | Fully Supported | [github.com/DataDog/dd-trace-go/contrib/go-chi/chi/v2][83] | | |||
| [chi][13] | Fully Supported | [github.com/DataDog/dd-trace-go/contrib/go-chi/chi/v2][83] | | |||
| [chi v5][13] | Fully Supported | [github.com/DataDog/dd-trace-go/contrib/go-chi/chi.v5/v2][156] | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| [chi v5][13] | Fully Supported | [github.com/DataDog/dd-trace-go/contrib/go-chi/chi.v5/v2][156] | | |
| [chi v5][13] | Fully Supported | [github.com/DataDog/dd-trace-go/contrib/go-chi/chi.v5][156] | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this is the intended text, since appending /v2
here leads to a 404 page. Feel free to make a different correction if that's inaccurate.
| [Fiber][18] | Fully Supported | [github.com/DataDog/dd-trace-go/contrib/gofiber/fiber.v2/v2][85] | | ||
| [Fiber v2][18] | Fully Supported | [github.com/DataDog/dd-trace-go/contrib/gofiber/fiber.v2/v2][85] | | ||
| [HTTPTreeMux v5][115] | Fully Supported | [github.com/DataDog/dd-trace-go/contrib/dimfeld/httptreemux.v5/v2][116] | | ||
| [HTTP router][30] | Fully Supported | [github.com/DataDog/dd-trace-go/contrib/julienschmidt/httprouter/v2][91] | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| [HTTP router][30] | Fully Supported | [github.com/DataDog/dd-trace-go/contrib/julienschmidt/httprouter/v2][91] | | |
| [HttpRouter][30] | Fully Supported | [github.com/DataDog/dd-trace-go/contrib/julienschmidt/httprouter/v2][91] | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggesting this update for consistency with how this is written on the linked page
@@ -77,32 +82,44 @@ The Go tracer includes support for the following data stores and libraries. | |||
| [AWS SDK][20] | Fully Supported | [github.com/DataDog/dd-trace-go/contrib/aws/aws-sdk-go/aws/v2][86] | | |||
| [AWS SDK v2][75] | Fully Supported | [github.com/DataDog/dd-trace-go/contrib/aws/aws-sdk-go-v2/aws/v2][113] | | |||
| [Elasticsearch][22] | Fully Supported | [github.com/DataDog/dd-trace-go/contrib/olivere/elastic.v5/v2][87] | | |||
| [Elasticsearch (elastic) v6][125] | Fully Supported | [github.com/DataDog/dd-trace-go/contrib/elastic/go-elasticsearch.v6/v2][126] | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| [Elasticsearch (elastic) v6][125] | Fully Supported | [github.com/DataDog/dd-trace-go/contrib/elastic/go-elasticsearch.v6/v2][126] | | |
| [Elasticsearch (Elastic) v6][125] | Fully Supported | [github.com/DataDog/dd-trace-go/contrib/elastic/go-elasticsearch.v6/v2][126] | |
| [Kafka (confluent)][53] | Fully Supported | [github.com/DataDog/dd-trace-go/contrib/confluentinc/confluent-kafka-go/kafka/v2][103] | | ||
| [Kafka (confluent v2)][53] | Fully Supported | [github.com/DataDog/dd-trace-go/contrib/confluentinc/confluent-kafka-go/kafka.v2/v2][139] | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| [Kafka (confluent)][53] | Fully Supported | [github.com/DataDog/dd-trace-go/contrib/confluentinc/confluent-kafka-go/kafka/v2][103] | | |
| [Kafka (confluent v2)][53] | Fully Supported | [github.com/DataDog/dd-trace-go/contrib/confluentinc/confluent-kafka-go/kafka.v2/v2][139] | | |
| [Kafka (Confluent)][53] | Fully Supported | [github.com/DataDog/dd-trace-go/contrib/confluentinc/confluent-kafka-go/kafka/v2][103] | | |
| [Kafka (Confluent v2)][53] | Fully Supported | [github.com/DataDog/dd-trace-go/contrib/confluentinc/confluent-kafka-go/kafka.v2/v2][139] | |
What does this PR do? What is the motivation?
Updates our list of compatible integrations for the Go tracer, since the current list is extremely out of date.
Merge instructions
Merge after approval from Go IDM.
Merge readiness:
For Datadog employees:
Your branch name MUST follow the
<name>/<description>
convention and include the forward slash (/
). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.
Additional notes