Skip to content

Support configuring resources for the driver and registrar containers in the datadog-csi-driver chart - #2509

Closed
vbyrd wants to merge 12 commits into
DataDog:mainfrom
vbyrd:vbyrd-patch-1
Closed

vbyrd wants to merge 12 commits into
DataDog:mainfrom
vbyrd:vbyrd-patch-1

Conversation

@vbyrd

@vbyrd vbyrd commented Mar 24, 2026

Copy link
Copy Markdown

What this PR does / why we need it:

Well formed helm charts should allows setting resource request/limits per container. This is useful for node autoscalers such as Karpenter that rely on this information. This PR adds this functionality

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • All commits are signed and show as "Verified" on GitHub (see: signing commits)
  • Chart Version semver bump label has been added (use <chartName>/minor-version, <chartName>/patch-version, or <chartName>/no-version-bump)

GitHub CI takes care of the below, but are still required:

  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md

@vbyrd
vbyrd requested review from a team as code owners March 24, 2026 19:23

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 23b7ec3f64

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread test/datadog-csi-driver/manifests/added_resources.yaml Outdated
@adel121
adel121 self-requested a review March 25, 2026 15:07
@adel121

adel121 commented May 21, 2026

Copy link
Copy Markdown
Contributor

Closing as it is already implemented with: #2676

@adel121 adel121 closed this May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants