Document new DPA autoscaling metrics - #25105
Draft
clamoriniere wants to merge 1 commit into
Draft
Conversation
Co-authored-by: clamoriniere <cedric.lamoriniere@datadoghq.com>
Contributor
|
I can only run on private repositories. |
|
evalya-impact-summaryevalya impact analysis |
Contributor
Validation Report
Run Passed validations (20)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Documents three new Cluster Agent workload autoscaling metrics in
datadog_cluster_agent/metadata.csv:datadog.cluster_agent.autoscaling.workload.objective.target(from datadog-agent PR #54465) — target value configured in aDatadogPodAutoscaler'sspec.objectives, one point per objective. The unit column is intentionally left blank because the value is a percentage forvalue_type:utilization, millicores for absolute CPU, bytes for absolute memory, and the query-native unit for custom queries; the description spells this out.datadog.cluster_agent.autoscaling.workload.apply_mode(from datadog-agent PR #55475) — info-style gauge (always1) tagged withdpa_mode(apply/preview) anddpa_dimension(horizontal/vertical).datadog.cluster_agent.autoscaling.workload.vertical_scaling.controlled_resources(from datadog-agent PR #55475) — info-style gauge (always1), one point per container resource controlled by vertical autoscaling, usingkube_container_name:allfor wildcard or default container constraints.Rows were inserted to preserve the file's alphabetical ordering. No change to
METRIC_MAPindatadog_cluster_agent/datadog_checks/datadog_cluster_agent/check.pyis required: these metrics are emitted directly through the Cluster Agent metrics store rather than the Prometheus endpoint, like the sibling DPA constraints/status metrics already listed inmetadata.csv.Motivation
The metrics ship in the Cluster Agent but were not listed in the integration metadata, so they did not appear in the documented metric list that the integration README points users to.
Describe how you validated your changes
ddev validate metadata datadog_cluster_agentpasses.pkg/clusteragent/autoscaling/workload/metrics/generator.goandmetrics.mdat the merge commits of datadog-agent PRs #54465 and #55475.Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is mergedPR by Bits - View session in Datadog
Comment @DataDog to request changes