Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
BenchmarksComparisonCandidateCandidate benchmark detailsBaselineBaseline benchmark details |
|
✅ All CI checks and tests passed. 🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: c5eb117 | Docs | View more details | Give us feedback! |
cbeauchesne
reviewed
Oct 8, 2026
cbeauchesne
left a comment
cbeauchesne
left a comment
Contributor
There was a problem hiding this comment.
query to validate (the last line shows NA for main, it must be empty once the CI is finished.
VianneyRuhlmann
approved these changes
Oct 9, 2026
VianneyRuhlmann
left a comment
VianneyRuhlmann
left a comment
Contributor
There was a problem hiding this comment.
LGTM, You need to add the run-all-tests label if you want to properly validate with Charles' query
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It fixes missing source-file paths for FFI tests in JUnit reports, allowing their owners to be determined from CODEOWNERS.
Motivation
Investigating test ownership after #2622 (https://github.com/DataDog/libdatadog/pull/2622) revealed that FFI tests were missing source-file paths in their reports.
The tool checks the first target kind returned by Cargo. For
libdd-library-config-ffi, this isstaticlib, which was ignored even though the crate also produces alib. Consequently, its tests could appear unowned despite an existing CODEOWNERS rule.Additional Notes
Regression test added using actual workspace metadata.
How to test the change?
cargo test - p tools