Skip to content

Conversation

ichinaski
Copy link
Contributor

Motivation

This PR extends the Client-Side Stats test scenario to provide comprehensive validation of tracer implementations against the Client-Side Stats specification. The changes add multiple new test classes to validate critical aspects of the Client-Side Stats feature including agent feature detection, obfuscation, peer tags aggregation, transport headers, and time bucketing.

Changes

Test Coverage Added

  • Agent Info Endpoint Validation
  • SQL Resource Obfuscation Testing
  • Peer Tags Aggregation
  • Transport Headers Validation
  • Time Bucketing Validation

Schema Updates

Updated both library and agent stats request schemas to include additional fields required by the Client-Side Stats specification:

  • Added IsTraceRoot, SpanKind, PeerTags fields
  • Enhanced field descriptions and validation rules
  • Made schemas more comprehensive for proper validation

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@ichinaski ichinaski requested a review from a team as a code owner July 30, 2025 08:16
@ichinaski ichinaski changed the title Ichinaski/css tests [APM] Extend Client-Side Stats test scenario Jul 30, 2025
@ichinaski ichinaski changed the title [APM] Extend Client-Side Stats test scenario [APM] Extend Client-Side Stats test coverage Jul 30, 2025
Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing

@ichinaski ichinaski requested a review from cbeauchesne August 21, 2025 07:16
Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Framework usage: all good, just a non blocking comment, I let you decide what you prefer.

It'd be a good idea to get a review of test logic from a co-worker that's familiar with the RFC.. Done 7 minutes ago 😄

@ichinaski ichinaski merged commit 00276b1 into main Aug 21, 2025
1822 checks passed
@ichinaski ichinaski deleted the ichinaski/css-tests branch August 21, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants