Skip to content

Conversation

@rachelyangdog
Copy link
Contributor

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@rachelyangdog rachelyangdog requested review from a team as code owners November 17, 2025 17:57
@rachelyangdog rachelyangdog requested review from cecile75 and removed request for a team November 17, 2025 17:57
@rachelyangdog rachelyangdog marked this pull request as draft November 17, 2025 17:57
@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2025

CODEOWNERS have been resolved as:

manifests/php.yml                                                       @DataDog/apm-php @DataDog/asm-php
tests/parametric/test_otel_metrics.py                                   @DataDog/system-tests-core @DataDog/apm-sdk-capabilities
utils/_context/_scenarios/parametric.py                                 @DataDog/system-tests-core
utils/build/docker/php/parametric/Dockerfile                            @DataDog/apm-php @DataDog/system-tests-core
utils/build/docker/php/parametric/composer.json                         @DataDog/apm-php @DataDog/system-tests-core
utils/build/docker/php/parametric/server.php                            @DataDog/apm-php @DataDog/system-tests-core
utils/parametric/_library_client.py                                     @DataDog/system-tests-core
utils/build/docker/php/parametric/composer.lock                         @DataDog/apm-php @DataDog/system-tests-core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants