Skip to content

Conversation

@lloeki
Copy link
Member

@lloeki lloeki commented Nov 18, 2025

Motivation

Inconsistent rubygems (and bundler) versions for testing SSI: only rubygems 3.4+ (and bundler 2.4+) are supported.

Changes

Update all instances of rubygems to 3.4.22 and bundler to 2.4.22.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

CODEOWNERS have been resolved as:

lib-injection/build/docker/ruby/dd-lib-ruby-init-test-rails-bundle-deploy/Dockerfile  @DataDog/system-tests-core
lib-injection/build/docker/ruby/dd-lib-ruby-init-test-rails-conflict/Dockerfile  @DataDog/system-tests-core
lib-injection/build/docker/ruby/dd-lib-ruby-init-test-rails-explicit/Dockerfile  @DataDog/system-tests-core
lib-injection/build/docker/ruby/dd-lib-ruby-init-test-rails-explicit/Dockerfile.lib_init_validator  @DataDog/system-tests-core
lib-injection/build/docker/ruby/dd-lib-ruby-init-test-rails-gemsrb/Dockerfile  @DataDog/system-tests-core
lib-injection/build/docker/ruby/dd-lib-ruby-init-test-rails-gemsrb/Dockerfile.lib_init_validator  @DataDog/system-tests-core
lib-injection/build/docker/ruby/dd-lib-ruby-init-test-rails/Dockerfile  @DataDog/system-tests-core
lib-injection/build/docker/ruby/dd-lib-ruby-init-test-rails/Dockerfile.lib_init_validator  @DataDog/system-tests-core
lib-injection/build/docker/ruby/lib_injection_rails_app/Gemfile.lock    @DataDog/system-tests-core
utils/build/docker/ruby/rails52/Gemfile.lock                            @DataDog/ruby-guild @DataDog/asm-ruby @DataDog/system-tests-core
utils/build/virtual_machine/weblogs/ruby/provision_test-app-ruby.yml    @DataDog/system-tests-core
utils/build/virtual_machine/weblogs/ruby/test-app-ruby-container/Dockerfile.template  @DataDog/system-tests-core
utils/build/virtual_machine/weblogs/ruby/test-app-ruby-multialpine/Dockerfile.ruby_2_7-alpine  @DataDog/system-tests-core
utils/build/virtual_machine/weblogs/ruby/test-app-ruby-multialpine/Dockerfile.ruby_3_0-alpine  @DataDog/system-tests-core
utils/build/virtual_machine/weblogs/ruby/test-app-ruby-multialpine/Dockerfile.ruby_3_1-alpine  @DataDog/system-tests-core
utils/build/virtual_machine/weblogs/ruby/test-app-ruby-multialpine/Dockerfile.ruby_3_2-alpine  @DataDog/system-tests-core
utils/build/virtual_machine/weblogs/ruby/test-app-ruby-multicontainer/Dockerfile.ruby_2_7  @DataDog/system-tests-core
utils/build/virtual_machine/weblogs/ruby/test-app-ruby-multicontainer/Dockerfile.ruby_3_0  @DataDog/system-tests-core
utils/build/virtual_machine/weblogs/ruby/test-app-ruby-multicontainer/Dockerfile.ruby_3_1  @DataDog/system-tests-core
utils/build/virtual_machine/weblogs/ruby/test-app-ruby-multicontainer/Dockerfile.ruby_3_2  @DataDog/system-tests-core

@lloeki lloeki force-pushed the lloeki/update-rubygems-for-onboarding branch from 93f82f7 to 288abb1 Compare November 18, 2025 16:06
@lloeki lloeki force-pushed the lloeki/update-rubygems-for-onboarding branch 2 times, most recently from 2a962f4 to 2a196d9 Compare November 18, 2025 16:47
@lloeki
Copy link
Member Author

lloeki commented Nov 18, 2025

Ruby 2.6 fails with:

     > [ruby_2_6 10/10] RUN bundle install:
    8.066 Fetching gem metadata from https://rubygems.org/..........
    15.62 Resolving dependencies...
    16.78 Resolving dependencies...
    27.91 Could not find compatible versions
    27.91
    27.91 Because rails >= 7.0.0.alpha1, < 7.2.0.beta1 depends on Ruby >= 2.7.0
    27.91   and Gemfile depends on rails ~> 7.0.3,
    27.91   Ruby >= 2.7.0 is required.
    27.91 So, because current Ruby version is = 2.6.10,
    27.91   version solving has failed.
    ------
    Dockerfile.ruby_2_6:41

    --------------------

      39 |

      40 |     # Install gems

      41 | >>> RUN bundle install

      42 |

      43 |     # Set entrypoint

    --------------------

    target ruby_2_6: failed to solve: process "/bin/sh -c bundle install" did not complete successfully: exit code: 6

Which is sort of expected because this app is Rails 7.0 and that needs Ruby 2.7.

@lloeki
Copy link
Member Author

lloeki commented Nov 18, 2025

I'll split the Ruby version addition to a separate PR, in two:

  • One PR for Ruby 2.7 to 3.4
  • One PR for Ruby 2.6

@lloeki lloeki force-pushed the lloeki/update-rubygems-for-onboarding branch from 2a196d9 to 95ccfaf Compare November 19, 2025 08:41
@lloeki
Copy link
Member Author

lloeki commented Nov 19, 2025

@lloeki lloeki mentioned this pull request Nov 19, 2025
6 tasks
@lloeki lloeki marked this pull request as ready for review November 19, 2025 10:26
@lloeki lloeki requested review from a team as code owners November 19, 2025 10:26
@lloeki
Copy link
Member Author

lloeki commented Nov 19, 2025

Commit 95ccfaf will be removed before merging.

@robertomonteromiguel
Copy link
Collaborator

you are removing jobs frorm gitlab. I guess this PR is still in DRAFT.

@robertomonteromiguel robertomonteromiguel marked this pull request as draft November 19, 2025 10:41
@lloeki lloeki force-pushed the lloeki/update-rubygems-for-onboarding branch from 95ccfaf to 92f11bb Compare November 19, 2025 10:50
@lloeki
Copy link
Member Author

lloeki commented Nov 19, 2025

you are removing jobs frorm gitlab. I guess this PR is still in DRAFT.

As mentioned:

Commit 95ccfaf will be removed before merging.

The only reason I kept it is that I was waiting for a flaky test to retry, and I did not want to push again and cancel the whole CI / fail because the commit disappeared.

The reason I undrafted was to trigger a review before the whole of the unrelated CI completed.

Now that it has passed I have removed the commit and the whole CI is triggered again.

Undrafting.

@lloeki lloeki marked this pull request as ready for review November 19, 2025 10:53
Copy link
Collaborator

@robertomonteromiguel robertomonteromiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but, remember you should set the PR as ready for review only when actually the PR is ready for review.

@lloeki lloeki merged commit 8ce0bc4 into main Nov 19, 2025
952 checks passed
@lloeki lloeki deleted the lloeki/update-rubygems-for-onboarding branch November 19, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants