-
Notifications
You must be signed in to change notification settings - Fork 14
Update rubygems for onboarding
#5730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
93f82f7 to
288abb1
Compare
2a962f4 to
2a196d9
Compare
|
Ruby 2.6 fails with: Which is sort of expected because this app is Rails 7.0 and that needs Ruby 2.7. |
|
I'll split the Ruby version addition to a separate PR, in two:
|
2a196d9 to
95ccfaf
Compare
|
Commit 95ccfaf will be removed before merging. |
|
you are removing jobs frorm gitlab. I guess this PR is still in DRAFT. |
95ccfaf to
92f11bb
Compare
As mentioned:
The only reason I kept it is that I was waiting for a flaky test to retry, and I did not want to push again and cancel the whole CI / fail because the commit disappeared. The reason I undrafted was to trigger a review before the whole of the unrelated CI completed. Now that it has passed I have removed the commit and the whole CI is triggered again. Undrafting. |
robertomonteromiguel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but, remember you should set the PR as ready for review only when actually the PR is ready for review.
Motivation
Inconsistent rubygems (and bundler) versions for testing SSI: only rubygems 3.4+ (and bundler 2.4+) are supported.
Changes
Update all instances of rubygems to 3.4.22 and bundler to 2.4.22.
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present