Enhance feature extraction #104
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KiddoZhu
force-pushed
the
master
branch
11 times, most recently
from
7392070 to
e73d2c9
Compare
|
Hi @KiddoZhu ! What do you think about this extension? Best, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The feature extraction methods do not accept arguments. Sometimes it would be nice if one could run the same registered feature extraction method with different arguments (like for fingerprints)
Solution
Add dedicated
{node,edge,graph}_feature_kwargstofrom_moleculeandfrom_smilesand pass those to the the function call. Furthermore, let the already implemented feature extraction methods accept**kwargs.Test suite has been updated to test this functionality.