Skip to content

[Ascend] fix sub bug for ascend #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[Ascend] fix sub bug for ascend #905

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f1d1a60
fix sub bug for ascend
jingguo-st Jul 19, 2024
44d5c85
replace sync call in sub
jingguo-st Jul 19, 2024
f593ec9
fix bug
jingguo-st Jul 19, 2024
fad4275
fix sub check for alpha
jingguo-st Jul 19, 2024
54e2727
fix rsub unit test
jingguo-st Jul 20, 2024
5e37727
fix rsub impl
jingguo-st Jul 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions dipu/scripts/autogen_diopi_wrapper/diopi_functions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,28 @@
custom_code_at_the_beginning: |
return dipu_add__tensor(self, other, -alpha);

- schema: sub.Scalar(Tensor self, Scalar other, Scalar alpha=1) -> Tensor
custom_code_at_the_beginning: |
at::Tensor out = UnaryOpInferrer().infer_out(self);
interface: diopiSubScalar(ctx, out, self, other, alpha)

- schema: "sub.Tensor(Tensor self, Tensor other, *, Scalar alpha=1) -> Tensor"
dummy_call_diopi: True
ins: [selfTmp]
custom_code_at_the_beginning: |
at::native::sub_check(self, other);
auto out = BinaryOpInferrer().infer_out(self, other);
return dipu_add_out(self, other, -alpha, out);
if (is_scalar_on_cpu(other)) {
return dipu_sub_scalar(self, other.item(), alpha);
}

at::Tensor selfTmp = self;
if (is_scalar_on_cpu(selfTmp)) {
selfTmp = nodispatch::empty({1}, self.options().device(other.device()));
dipu_fill__scalar(selfTmp, self.item());
}

at::native::sub_check(selfTmp, other);
at::Tensor out = BinaryOpInferrer().infer_out(selfTmp, other);

interface: diopiSub(ctx, out, selfTmp, other, alpha)

- schema: "div.Scalar(Tensor self, Scalar other) -> Tensor"
custom_code_at_the_beginning: |
Expand Down