-
Notifications
You must be signed in to change notification settings - Fork 6.5k
Updated YieldBricks adapter to show stats more correctly #16740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The adapter at projects/yieldbricks exports TVL: |
projects/yieldbricks/index.js
Outdated
| tokens: TOKENS_YBR_ARBITRUM, | ||
| tvl: sumTokensExport({ | ||
| owners: ARB_STAKING_POOLS, | ||
| tokens: ARB_CONTRACTS_YBR, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any YBR TVL should be exported as staking like it was previously
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, how do we calculate the TVL ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you have no other TVL then use tvl: () => ({})
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do have tvl, that is why I would like it to be added to the tvl value. If I use tvl: () => ({}) then tvl will show wrong value (0 value)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any YBR TVL is exported as staking and will show as TVL depending on end user settings. Any core TVL can be added to this adapter with further changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@waynebruce0x I have now completed the changes that you commented and cleaned up the implementation. Please review again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good, one last thing, please move the YBR addresses from coreAssets file to inside your adapter file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@waynebruce0x - all done 🫡
|
The adapter at projects/yieldbricks exports TVL: |
|
The adapter at projects/yieldbricks exports TVL: |
|
@waynebruce0x please review |
Updated YieldBricks adapter to show stats more correctly. Added LP stats and ethereum as second chain.