Skip to content

fix: save condition on operator change in PolicyCondition.vue #1263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arjavdongaonkar
Copy link

Description

Fix policy condition operator changes not being saved automatically. Added missing change event handler to the operator dropdown to trigger saveCondition() when the operator value is modified, ensuring consistency with subject and value field behavior.

Addressed Issue

Fixes #[508] - Policy condition operator changes not being saved

Solution: Added v-on:change="saveCondition" to the operator select component, matching the pattern used by other form fields in the component.

Technical Details:

  • The fix is minimal and follows the existing component pattern
  • No additional logic was needed since saveCondition() already handles operator changes correctly
  • This ensures immediate persistence of operator changes without requiring additional user interaction

Before: Operator changes required modifying another field to trigger save
After: Operator changes are saved immediately upon selection

Checklist

@owasp-dt-bot
Copy link

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants