Skip to content

HtmlEditor: Get rid of getComputedStyles for table and cell prop fields (T1295949) #30385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Aug 11, 2025
Merged

HtmlEditor: Get rid of getComputedStyles for table and cell prop fields (T1295949) #30385

merged 23 commits into from
Aug 11, 2025

Conversation

marker-dao
Copy link
Contributor

@marker-dao marker-dao commented Jul 15, 2025 •
edited by ksercs
Loading

  1. BC: no more calculation of values for editors in Cell and Table properties forms (but only hardcoded hor and vert alignment default values). Related fix of cell format getting in devextreme-quill - Table Cell: formats method should consider values stored for the cell before child's format devextreme-quill#136
  2. Fix issue with "nullpx" value of dimension editors after applying empty value
  3. Fix parsing of "padding" style for tableLite cells

@marker-dao marker-dao requested a review from a team July 15, 2025 17:41
@marker-dao marker-dao self-assigned this Jul 15, 2025
@marker-dao marker-dao force-pushed the 25_2_T1295949_htmleditor_table_border branch from 1d60be3 to a3f1fa6 Compare July 16, 2025 15:25
@marker-dao marker-dao requested review from a team as code owners July 16, 2025 15:25
@marker-dao marker-dao force-pushed the 25_2_T1295949_htmleditor_table_border branch from a3f1fa6 to 4bd0b81 Compare July 16, 2025 15:27
@marker-dao marker-dao removed request for a team July 16, 2025 17:41
@marker-dao marker-dao changed the title HtmlEditor: Cell border width sets itself to 0 after cell properties dialog is closed (T1295949) HtmlEditor: Round cell border width (T1295949) Jul 16, 2025
@marker-dao marker-dao force-pushed the 25_2_T1295949_htmleditor_table_border branch from e1dce16 to 57f73b3 Compare July 18, 2025 11:56
@marker-dao marker-dao changed the title HtmlEditor: Round cell border width (T1295949) HtmlEditor: Get rid of getComputed styles for table and cell sizes (T1295949) Jul 21, 2025
@marker-dao marker-dao marked this pull request as draft July 21, 2025 07:54
@marker-dao marker-dao force-pushed the 25_2_T1295949_htmleditor_table_border branch from 937dead to 4aa7119 Compare July 21, 2025 11:17
@marker-dao marker-dao marked this pull request as ready for review July 21, 2025 11:22
@marker-dao marker-dao changed the title HtmlEditor: Get rid of getComputed styles for table and cell sizes (T1295949) HtmlEditor: Get rid of getComputedStyles for table and cell sizes (T1295949) Jul 21, 2025
r-farkhutdinov
r-farkhutdinov previously approved these changes Jul 21, 2025
View reviewed changes
@marker-dao marker-dao force-pushed the 25_2_T1295949_htmleditor_table_border branch 2 times, most recently from 00b3fe6 to 3d3b3c7 Compare July 24, 2025 09:57
@marker-dao marker-dao changed the title HtmlEditor: Get rid of getComputedStyles for table and cell sizes (T1295949) HtmlEditor: Get rid of getComputedStyles for table and cell prop fields (T1295949) Jul 24, 2025
@ksercs ksercs added the WIP Work in progress label Jul 25, 2025
marker dao ® and others added 22 commits July 28, 2025 11:22
test
ecb35de
stash
0edeb74
HtmlEditor: Round cell border width
79fba38
refactor && feat(pg && tests): Add tests
e373a02
refactor && feat(pg && tests): Add tests
4144bca
refactor(toolbarHelper): Typing
5ee7fc7
feat(toolbarHelper): Impreve typing
39eb216
revert(solution)
8eeffdc
feat(toolbarHelper): Get rid of getComputedStyles for sizes
9e2cdd8
refactor && feat(toolbarHelper): Fix for Table Props && Refactor types
e9a9e7b
stash
e753c2e
revart(pg)
9b555bc
feat(toolbarHelper): Add releted test
52b5ca7
feat(thelper): Set null as default
6a49a2a
feat(th - tests): Update
6d175f6
@ksercs
retrieve back default center alignment for header cells
5025acf
@ksercs
fix setting of "nullpx" excess values
74c154b
@ksercs
support new formats showing on popup reopening
1461af2
@ksercs
move dx-buttongroup to a constant
76c8cd6
@ksercs
revert applying in favor of fix in quill
afb8b01
@ksercs
register main table module after tableLite test
7ed3995
@ksercs
refactoring
4ba1342
@marker-dao marker-dao force-pushed the 25_2_T1295949_htmleditor_table_border branch from 1939ad6 to 4ba1342 Compare July 28, 2025 09:43
@ksercs ksercs removed the WIP Work in progress label Aug 11, 2025
@ksercs ksercs merged commit 689f6c8 into DevExpress:25_2 Aug 11, 2025
311 checks passed
@marker-dao marker-dao deleted the 25_2_T1295949_htmleditor_table_border branch August 11, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksercs ksercs ksercs approved these changes

@r-farkhutdinov r-farkhutdinov r-farkhutdinov left review comments

Assignees

@marker-dao marker-dao

Labels
25_2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marker-dao @r-farkhutdinov @ksercs