List, TreeView: remove the use of SearchBoxMixin #30413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/devextreme/js/__internal/ui/collection/m_search_box_mixin.ts
Outdated
Show resolved
Hide resolved
ksercs
reviewed
Jul 23, 2025
packages/devextreme/js/__internal/ui/hierarchical_collection/data_adapter.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/ui/drop_down_editor/m_drop_down_list.ts
Outdated
Show resolved
Hide resolved
… list options handling
packages/devextreme/js/__internal/grids/grid_core/header_filter/m_header_filter_core.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/grids/grid_core/header_filter/m_header_filter_core.ts
Show resolved
Hide resolved
packages/devextreme/js/__internal/grids/grid_core/header_filter/m_header_filter_core.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/ui/list/m_list.edit.search.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/ui/list/m_list.edit.search.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/ui/tree_view/m_tree_view.search.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/ui/tree_view/m_tree_view.search.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/ui/tree_view/m_tree_view.search.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/ui/collection/m_search_box_mixin.ts
Outdated
Show resolved
Hide resolved
… streamline option handling
… search-related options
…ces in search box integration
…tubComponent usage
| return super._getAriaTarget(); | ||
| } | ||
|
|
||
| getSearchBoxController(): SearchBoxController { |
There was a problem hiding this comment.
In all places, you can use this method instead of accessing the private field directly
There was a problem hiding this comment.
Not sure whether it's needed - this method is used only in grids as a WA and normally this class shouldn't provide an access to its private field
packages/devextreme/js/__internal/ui/collection/m_search_box_mixin.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/ui/collection/m_search_box_mixin.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/grids/grid_core/header_filter/m_header_filter_core.ts
Outdated
Show resolved
Hide resolved
EugeniyKiyashko
approved these changes
Jul 28, 2025
wdevfx
approved these changes
Jul 28, 2025
ksercs
approved these changes
Jul 28, 2025
pharret31
added a commit
to pharret31/DevExtreme
that referenced
this pull request
Jul 31, 2025
Co-authored-by: EugeniyKiyashko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.