Overlay: Fix ESLint issues and improve typing #30456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marker-dao
force-pushed
the
25_2_overlay_ts
branch
from
8c52b03 to
0089c6b
Compare
marker-dao
force-pushed
the
25_2_overlay_ts
branch
from
d9037b7 to
6b4728b
Compare
marker-dao
commented
Jul 24, 2025
| // @ts-ignore | ||
| if (tabbableElements.$first || tabbableElements.$last) { | ||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore expected: types Overlay<OverlayProperties> and this have no overlap |
There was a problem hiding this comment.
It can not be replaced with @ts-expect-error
pomahtri
approved these changes
Jul 24, 2025
packages/devextreme/js/__internal/grids/grid_core/validating/m_validating.ts
Show resolved
Hide resolved
marker-dao
force-pushed
the
25_2_overlay_ts
branch
from
b1d97e5 to
d44308c
Compare
marker-dao
force-pushed
the
25_2_overlay_ts
branch
from
4715a5c to
f159e95
Compare
EugeniyKiyashko
previously approved these changes
Jul 29, 2025
packages/devextreme/js/__internal/ui/overlay/m_overlay_position_controller.ts
Show resolved
Hide resolved
anna-shakhova
approved these changes
Jul 30, 2025
r-farkhutdinov
approved these changes
Jul 30, 2025
added 24 commits
July 30, 2025 14:39
marker-dao
force-pushed
the
25_2_overlay_ts
branch
from
da9cf7f to
b494c0c
Compare
Raushen
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.