Scheduler: Add "(No subject)" title to appointments without text #31739
Conversation
sjbur
changed the title
sjbur
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR adds a "(No subject)" placeholder text for scheduler appointments that have no title/text, improving the user experience by providing visual feedback instead of leaving the appointment title empty.
- Added localization key
dxScheduler-noSubjectwith value "(No subject)" across all supported language files - Updated scheduler code to display "(No subject)" when appointment text is empty or missing
- Added test coverage to verify the behavior
Reviewed Changes
Copilot reviewed 32 out of 36 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/devextreme/js/__internal/scheduler/m_subscribes.ts | Added messageLocalization import and updated createFormattedDateText and _createAppointmentTitle functions to use "(No subject)" fallback for empty appointment text |
| packages/devextreme/js/__internal/scheduler/appointment_popup/appointment_popup.test.ts | Added test to verify appointments without title display "(No subject)" while keeping the input field empty |
| packages/devextreme/js/localization/messages/*.json (31 files) | Added "dxScheduler-noSubject" key with "(No subject)" value to all language localization files |
| packages/devextreme/playground/jquery.html | Removed trailing whitespace from closing HTML tag |
packages/devextreme/js/__internal/scheduler/appointment_popup/appointment_popup.test.ts
Outdated
Show resolved
Hide resolved
| }); | ||
| }); | ||
|
|
||
| it('should display "(No subject)" for appointments without title', async () => { |
There was a problem hiding this comment.
I suggest to add a visual test to check that "(No subject)" is displayed correctly.
I know that there are already some screenshots that you've updated, but it seems that they are not directly related to appointments without subject.
What do you think?
There was a problem hiding this comment.
Since it is a BC it is a good idea. For such small functionality in other scenario I would consider it as overkill
There was a problem hiding this comment.
I just realized that we don't have visual test for appointment without subject. Maybe add a visual or jest test for appointment tooltip too?
packages/devextreme/js/__internal/scheduler/appointment_popup/appointment_popup.test.ts
Outdated
Show resolved
Hide resolved
sjbur
dismissed stale reviews from Tucchhaa and vladaskorohodova
via
b5aea28
4 participants
No description provided.