Update DataGrid demos to new syntax #31764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates DataGrid demo files to use a new, more explicit component selector syntax for Angular. The migration adds component-specific prefixes to all child component selectors to improve clarity and avoid naming conflicts.
- Updates all DataGrid child component selectors from generic names (e.g.,
dxo-filter-row) to prefixed names (e.g.,dxo-data-grid-filter-row) - Updates other component selectors (TabPanel, Bullet, Sparkline, Slider, Form) to use the same prefixed naming convention
- Maintains all functionality and properties - this is a pure refactoring with no behavioral changes
Reviewed Changes
Copilot reviewed 75 out of 75 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| WebAPIService/Angular/app/app.component.html | Updates DataGrid child components to prefixed syntax |
| VirtualScrolling/Angular/app/app.component.html | Updates scrolling, load-panel, and sorting components |
| Toolbar/Angular/app/app.component.html | Updates toolbar and toolbar items to prefixed syntax |
| StatePersistence/Angular/app/app.component.html | Updates selection, filter-row, pager, and column components |
| SimpleArray/Angular/app/app.component.html | Updates column component to prefixed syntax |
| SignalRService/Angular/app/app.component.html | Updates column definitions to prefixed syntax |
| RowSelection/Angular/app/app.component.html | Updates selection and column components |
| RowEditing/Angular/app/app.component.html | Updates paging, editing, lookup, and column components |
| Row/Angular/app/app.component.html | Updates column components to prefixed syntax |
| RightToLeftSupport/Angular/app/app.component.html | Updates paging, pager, search-panel, and column components |
| RemoteVirtualScrolling/Angular/app/app.component.html | Updates scrolling, paging, header-filter, and column components |
| RemoteReordering/Angular/app/app.component.html | Updates row-dragging, sorting, scrolling, lookup, and column components |
| RemoteGrouping/Angular/app/app.component.html | Updates scrolling, group-panel, grouping, summary, and column components |
| RemoteCRUDOperations/Angular/app/app.component.html | Updates scrolling, editing, lookup, summary, and column components |
| RecordPaging/Angular/app/app.component.html | Updates scrolling, paging, and pager components |
| RecordGrouping/Angular/app/app.component.html | Updates search-panel, paging, pager, group-panel, grouping, and column components |
| RecalculateWhileEditing/Angular/app/app.component.html | Updates editing, pager, summary, and column components |
| RealTimeUpdates/Angular/app/app.component.html | Updates paging, master-detail, summary, and column components; also updates slider tooltip |
| PopupEditing/Angular/app/app.component.html | Updates paging, editing, popup, form, form-item, lookup, and column components |
| PDFOverview/Angular/app/app.component.html | Updates selection, paging, pager, grouping, export, and column components |
| PDFHeaderAndFooter/Angular/app/app.component.html | Updates export, format, and column components |
| PDFExportMultipleGrids/Angular/app/app.component.html | Updates tab-panel-item and column components |
| PDFExportImages/Angular/app/app.component.html | Updates export and column components |
| PDFCellCustomization/Angular/app/app.component.html | Updates export, group-panel, grouping, sort-by-group-summary-info, summary, and column components |
| Overview/Angular/app/app.component.html | Updates paging, pager, search-panel, group-panel, grouping, and column components; also updates bullet child components |
| OdataService/Angular/app/app.component.html | Updates column components to prefixed syntax |
| NewRecordPosition/Angular/app/app.component.html | Updates scrolling, editing, pager, toolbar, validation-rule, button, and column components |
| MultipleSorting/Angular/app/app.component.html | Updates sorting and column components |
| MultipleRecordSelectionModes/Angular/app/app.component.html | Updates selection, paging, pager, filter-row, and column components |
| MultipleRecordSelectionAPI/Angular/app/app.component.html | Updates selection, toolbar, and column components |
| MultiRowHeadersBands/Angular/app/app.component.html | Updates column-chooser, format, and column components |
| MasterDetailView/Angular/app/app.component.html | Updates master-detail and column components |
| MasterDetailView/Angular/app/detail-grid/detail-grid.component.html | Updates column components to prefixed syntax |
| MasterDetailAPI/Angular/app/app.component.html | Updates selection, master-detail, and column components |
| LocalReordering/Angular/app/app.component.html | Updates row-dragging, scrolling, sorting, lookup, and column components |
| KeyboardNavigation/Angular/app/app.component.html | Updates editing, header-filter, filter-panel, filter-row, paging, pager, lookup, and column components |
| InfiniteScrolling/Angular/app/app.component.html | Updates load-panel, scrolling, and sorting components |
| HorizontalVirtualScrolling/Angular/app/app.component.html | Updates paging and scrolling components |
| GroupSummaries/Angular/app/app.component.html | Updates selection, pager, summary, sort-by-group-summary-info, and column components |
| GridSummaries/Angular/app/app.component.html | Updates selection, pager, summary, and column components |
| GridAdaptabilityOverview/Angular/app/app.component.html | Updates editing, grouping, group-panel, pager, paging, column-chooser, and column components |
| FormEditing/Angular/app/app.component.html | Updates paging, editing, lookup, form-item, and column components |
| FixedAndStickyColumns/Angular/app/app.component.html | Updates column-fixing and column components |
| FilteringAPI/Angular/app/app.component.html | Updates pager and column components |
| Filtering/Angular/app/app.component.html | Updates filter-row, header-filter, search-panel, pager, and column components |
| FilterPanel/Angular/app/app.component.html | Updates filter-panel, filter-builder, filter-builder-popup, filter-row, header-filter, scrolling, and column components |
| ExcelJSOverview/Angular/app/app.component.html | Updates group-panel, grouping, selection, export, and column components |
| ExcelJSHeaderAndFooter/Angular/app/app.component.html | Updates export, format, and column components |
| ExcelJSExportMultipleGrids/Angular/app/app.component.html | Updates tab-panel-item and column components |
| ExcelJSExportImages/Angular/app/app.component.html | Updates export and column components |
| ExcelJSCellCustomization/Angular/app/app.component.html | Updates group-panel, grouping, export, sort-by-group-summary-info, summary, and column components |
| EditStateManagement/Angular/app/app.component.html | Updates editing, pager, and column components |
| DnDBetweenGrids/Angular/app/app.component.html | Updates row-dragging, scrolling, lookup, and column components |
| DeferredSelection/Angular/app/app.component.html | Updates selection, filter-row, pager, and column components |
| DataValidation/Angular/app/app.component.html | Updates paging, editing, validation-rule, and column components |
| CustomizeKeyboardNavigation/Angular/app/app.component.html | Updates keyboard-navigation, paging, editing, lookup, and column components |
| CustomSummaries/Angular/app/app.component.html | Updates paging, selection, summary, and column components |
| CustomEditors/Angular/app/app.component.html | Updates paging, pager, header-filter, search-panel, editing, lookup, validation-rule, and column components |
| CustomDataSource/Angular/app/app.component.html | Updates paging, pager, and column components |
| CommandColumnConfiguration/Angular/app/app.component.html | Updates paging, editing, button, lookup, and column components |
| ColumnsHidingPriority/Angular/app/app.component.html | Updates column components to prefixed syntax |
| ColumnReordering/Angular/app/app.component.html | Updates column-fixing and column components |
| ColumnHeaderFilter/Angular/app/app.component.html | Updates header-filter, search, and column components |
| ColumnChooser/Angular/app/app.component.html | Updates column-chooser, position, search, selection, and column components |
| Column/Angular/app/app.component.html | Updates column components to prefixed syntax |
| CollaborativeEditing/Angular/app/app.component.html | Updates paging, editing, lookup, validation-rule, and column components |
| CellEditing/Angular/app/app.component.html | Updates paging, editing, selection, lookup, toolbar, and column components |
| Cell/Angular/app/app.component.html | Updates sorting, pager, paging, and column components; also updates sparkline child components |
| CascadingLookups/Angular/app/app.component.html | Updates editing, lookup, and column components |
| BatchUpdateRequest/Angular/app/app.component.html | Updates editing, pager, and column components |
| BatchEditing/Angular/app/app.component.html | Updates paging, editing, lookup, and column components |
| AutoPopulatedColumns/Angular/app/app.component.html | Updates pager component to prefixed syntax |
| Appearance/Angular/app/app.component.html | Updates column components to prefixed syntax |
| AdvancedMasterDetailView/Angular/app/detail-view/detail-view.component.html | Updates tab-panel-item, form-item, form-label, paging, summary, and column components |
| AdvancedMasterDetailView/Angular/app/app.component.html | Updates paging, pager, master-detail, and column components |
dxvladislavvolkov
approved these changes
Nov 19, 2025
dmirgaev
reviewed
Nov 21, 2025
Comment on lines
+17
to
+20
| <dxi-data-grid-column type="buttons" [width]="110"> | ||
| <dxi-data-grid-button name="edit"></dxi-data-grid-button> | ||
| <dxi-data-grid-button name="delete"></dxi-data-grid-button> | ||
| <dxi-data-grid-button |
Contributor
There was a problem hiding this comment.
It's better to use dxi-data-grid-column-button inside dxi-data-grid-column
dmirgaev
reviewed
Nov 21, 2025
Comment on lines
+24
to
+27
| <dxo-data-grid-header-filter | ||
| [groupInterval]="10000" | ||
| ></dxo-data-grid-header-filter> | ||
| </dxi-data-grid-column> |
Contributor
There was a problem hiding this comment.
Maybe dxo-data-grid-column-header-filter?
dmirgaev
reviewed
Nov 21, 2025
Comment on lines
+42
to
-40
| <dxo-data-grid-header-filter | ||
| [dataSource]="saleAmountHeaderFilter" | ||
| ></dxo-header-filter> | ||
| </dxi-column> |
Contributor
There was a problem hiding this comment.
Maybe dxo-data-grid-column-header-filter?
dmirgaev
reviewed
Nov 21, 2025
Comment on lines
+25
to
+28
| <dxo-data-grid-header-filter | ||
| [groupInterval]="10000" | ||
| ></dxo-data-grid-header-filter> | ||
| </dxi-data-grid-column> |
Contributor
There was a problem hiding this comment.
Maybe dxo-data-grid-column-header-filter?
dmirgaev
reviewed
Nov 21, 2025
Comment on lines
+36
to
+39
| <dxo-data-grid-header-filter | ||
| [dataSource]="orderHeaderFilter" | ||
| ></dxo-data-grid-header-filter> | ||
| </dxi-data-grid-column> |
Contributor
There was a problem hiding this comment.
Maybe dxo-data-grid-column-header-filter?
dmirgaev
reviewed
Nov 21, 2025
Comment on lines
+59
to
-52
| <dxo-data-grid-header-filter | ||
| [dataSource]="saleAmountHeaderFilter" | ||
| ></dxo-header-filter> | ||
| </dxi-column> |
Contributor
There was a problem hiding this comment.
Maybe dxo-data-grid-column-header-filter?
dmirgaev
reviewed
Nov 21, 2025
Comment on lines
+64
to
+65
| <dxi-data-grid-column dataField="CustomerStoreCity" caption="City"> | ||
| <dxo-data-grid-header-filter> |
Contributor
There was a problem hiding this comment.
Maybe dxo-data-grid-column-header-filter?
dmirgaev
reviewed
Nov 21, 2025
Comment on lines
+66
to
+68
| <dxo-data-grid-search [enabled]="true"></dxo-data-grid-search> | ||
| </dxo-data-grid-header-filter> | ||
| </dxi-data-grid-column> |
Contributor
There was a problem hiding this comment.
Looks like here should be dxo-data-grid-column-header-filter-search
dmirgaev
reviewed
Nov 21, 2025
Comment on lines
+28
to
+29
| <dxi-data-grid-column dataField="StateID" caption="State" [width]="125"> | ||
| <dxo-data-grid-lookup |
Contributor
There was a problem hiding this comment.
dxo-data-grid-column-lookup
dmirgaev
reviewed
Nov 21, 2025
Comment on lines
+39
to
+40
| <dxi-data-grid-column dataField="StateID" caption="State"> | ||
| <dxo-data-grid-lookup |
Contributor
There was a problem hiding this comment.
dxo-data-grid-column-lookup
dmirgaev
reviewed
Nov 21, 2025
Comment on lines
+17
to
+18
| <dxi-data-grid-column dataField="Owner" [width]="150"> | ||
| <dxo-data-grid-lookup |
Contributor
There was a problem hiding this comment.
dxo-data-grid-column-lookup
dmirgaev
reviewed
Nov 21, 2025
Comment on lines
+24
to
+29
| <dxi-data-grid-column | ||
| dataField="AssignedEmployee" | ||
| caption="Assignee" | ||
| [width]="150" | ||
| > | ||
| <dxo-data-grid-lookup |
Contributor
There was a problem hiding this comment.
dxo-data-grid-column-lookup
dmirgaev
reviewed
Nov 21, 2025
Comment on lines
+17
to
+18
| <dxi-data-grid-column dataField="CustomerID" caption="Customer"> | ||
| <dxo-data-grid-lookup |
Contributor
There was a problem hiding this comment.
dxo-data-grid-column-lookup
dmirgaev
reviewed
Nov 21, 2025
Comment on lines
+30
to
+35
| <dxi-data-grid-column | ||
| dataField="ShipVia" | ||
| caption="Shipping Company" | ||
| dataType="number" | ||
| > | ||
| <dxo-data-grid-lookup |
Contributor
There was a problem hiding this comment.
dxo-data-grid-column-lookup
dmirgaev
reviewed
Nov 21, 2025
Comment on lines
+15
to
+16
| <dxi-data-grid-column dataField="Owner" [width]="150"> | ||
| <dxo-data-grid-lookup |
Contributor
There was a problem hiding this comment.
dxo-data-grid-column-lookup
dmirgaev
reviewed
Nov 21, 2025
Comment on lines
+45
to
+48
| <dxo-data-grid-header-filter | ||
| [groupInterval]="1000" | ||
| ></dxo-data-grid-header-filter> | ||
| </dxi-data-grid-column> |
Contributor
There was a problem hiding this comment.
dxo-data-grid-column-header-filter
dmirgaev
reviewed
Nov 21, 2025
Comment on lines
+39
to
+40
| <dxi-data-grid-column dataField="StateID" caption="State" [width]="125"> | ||
| <dxo-data-grid-lookup |
Contributor
There was a problem hiding this comment.
dxo-data-grid-column-lookup
dmirgaev
reviewed
Nov 21, 2025
Comment on lines
+30
to
-32
| <dxo-data-grid-lookup | ||
| [dataSource]="customersData" | ||
| valueExpr="Value" | ||
| displayExpr="Text" | ||
| ></dxo-lookup> | ||
| </dxi-column> |
Contributor
There was a problem hiding this comment.
dxo-data-grid-column-lookup
dmirgaev
reviewed
Nov 21, 2025
Comment on lines
+42
to
+43
| <dxi-data-grid-column dataField="Freight"> | ||
| <dxo-data-grid-header-filter |
Contributor
There was a problem hiding this comment.
dxo-data-grid-column-header-filter
dmirgaev
reviewed
Nov 21, 2025
Comment on lines
+61
to
+66
| <dxi-data-grid-column | ||
| dataField="ShipVia" | ||
| caption="Shipping Company" | ||
| dataType="number" | ||
| > | ||
| <dxo-data-grid-lookup |
Contributor
There was a problem hiding this comment.
dxo-data-grid-column-lookup
dmirgaev
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.