Update Chart/Scheduler/DropdownBox/Lookup demos syntax #31772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajivanyandev
changed the title
Copilot finished reviewing on behalf of
ajivanyandev
November 19, 2025 14:02
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Angular demo syntax for Charts and Scheduler components to use a more explicit, prefixed naming convention. The changes improve code clarity by adding component-specific prefixes (e.g., dxi-view → dxi-scheduler-view, dxi-series → dxi-chart-series) to distinguish nested child components from their parent containers.
Key Changes:
- Scheduler components now use
scheduler-*prefix (e.g.,dxi-scheduler-view,dxo-scheduler-editing) - Chart components now use
chart-*prefix (e.g.,dxi-chart-series,dxo-chart-legend) - PieChart, PolarChart, TreeMap, Funnel, Sankey, Sparkline, Bullet, and RangeSelector components follow the same pattern
Reviewed Changes
Copilot reviewed 112 out of 112 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Scheduler demos (11 files) | Updated Scheduler component child elements to use scheduler-* prefix for views, editing, resources, scrolling, and appointment-dragging |
| Chart demos (80+ files) | Updated Chart component child elements to use chart-* prefix for series, axes, legends, tooltips, exports, panes, and other nested components |
| PieChart demos (10 files) | Updated PieChart component child elements to use pie-chart-* prefix |
| PolarChart demos (5 files) | Updated PolarChart component child elements to use polar-chart-* prefix |
| RangeSelector demos (4 files) | Updated RangeSelector component child elements to use range-selector-* prefix |
| TreeMap demos (4 files) | Updated TreeMap component child elements to use tree-map-* prefix |
| Funnel demos (2 files) | Updated Funnel component child elements to use funnel-* prefix |
| Sankey demos (1 file) | Updated Sankey component child elements to use sankey-* prefix |
| Sparkline demos (4 files) | Updated Sparkline tooltip to use sparkline-tooltip prefix |
| Bullet demos (1 file) | Updated Bullet tooltip to use bullet-tooltip prefix |
All changes are consistent with the new naming convention and improve code readability by making component hierarchies more explicit. No issues were found in the reviewed code.
anna-shakhova
approved these changes
Nov 20, 2025
dxvladislavvolkov
approved these changes
Nov 20, 2025
aleksei-semikozov
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.