-
Notifications
You must be signed in to change notification settings - Fork 659
Other UI: move files to .ts #31773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Other UI: move files to .ts #31773
Conversation
f754619 to
1592ee9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors several UI-related files from JavaScript to TypeScript by moving implementations to the __internal directory and converting the original .js files to re-export wrappers. The changes affect core UI components including themes, splitter control, editor factory mixin, filtering utilities, and accessibility helpers.
Key Changes:
- Migrated
themes.js,splitter_control.js,ui.editor_factory_mixin.js,filtering.js, andaccessibility.jsto TypeScript with proper type annotations - Created wrapper files in original locations that re-export from the new TypeScript implementations
- Updated import paths across consuming files to reference the new internal implementations
- Added TypeScript type definitions for splitter events and options
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/js/ui/themes.js | Wrapper file for themes module - missing init export |
| packages/devextreme/js/ui/splitter_control.js | Simple re-export wrapper |
| packages/devextreme/js/ui/shared/ui.editor_factory_mixin.js | Simple re-export wrapper |
| packages/devextreme/js/ui/shared/filtering.js | Simple re-export wrapper |
| packages/devextreme/js/ui/shared/accessibility.js | Named exports wrapper |
| packages/devextreme/js/__internal/ui/themes.ts | TypeScript implementation with full type annotations |
| packages/devextreme/js/__internal/ui/splitter_control.ts | TypeScript implementation with unsafe optional chaining |
| packages/devextreme/js/__internal/ui/shared/ui.editor_factory_mixin.ts | TypeScript implementation with name shadowing |
| packages/devextreme/js/__internal/ui/shared/filtering.ts | TypeScript implementation with proper typing |
| packages/devextreme/js/__internal/ui/shared/accessibility.ts | TypeScript implementation with name shadowing |
| packages/devextreme/js/__internal/ui/gantt/ui.gantt.ts | Updated to use destructuring for options |
| packages/devextreme/js/__internal/ui/gantt/ui.gantt.size_helper.ts | Updated with proper type imports and annotations |
| packages/devextreme/js/__internal/ui/file_manager/ui.file_manager.adaptivity.ts | Updated with imported types instead of local interfaces |
| packages/devextreme/js/__internal/pagination/content.tsx | Updated import path for accessibility helper |
| packages/devextreme/js/__internal/grids/grid_core/editor_factory/m_editor_factory.ts | Removed type assertion that may cause issues |
packages/devextreme/js/__internal/grids/grid_core/editor_factory/m_editor_factory.ts
Show resolved
Hide resolved
1592ee9 to
eabbef4
Compare
eabbef4 to
3409e6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 15 out of 15 changed files in this pull request and generated 5 comments.
No description provided.