Skip to content

Conversation

@pharret31
Copy link
Contributor

No description provided.

@pharret31 pharret31 self-assigned this Nov 19, 2025
@pharret31 pharret31 force-pushed the 25_2_2612-other-ui-move-files-to-ts branch 4 times, most recently from f754619 to 1592ee9 Compare November 19, 2025 18:13
@pharret31 pharret31 marked this pull request as ready for review November 19, 2025 19:00
@pharret31 pharret31 requested review from a team as code owners November 19, 2025 19:00
Copilot AI review requested due to automatic review settings November 19, 2025 19:00
Copilot finished reviewing on behalf of pharret31 November 19, 2025 19:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors several UI-related files from JavaScript to TypeScript by moving implementations to the __internal directory and converting the original .js files to re-export wrappers. The changes affect core UI components including themes, splitter control, editor factory mixin, filtering utilities, and accessibility helpers.

Key Changes:

  • Migrated themes.js, splitter_control.js, ui.editor_factory_mixin.js, filtering.js, and accessibility.js to TypeScript with proper type annotations
  • Created wrapper files in original locations that re-export from the new TypeScript implementations
  • Updated import paths across consuming files to reference the new internal implementations
  • Added TypeScript type definitions for splitter events and options

Reviewed Changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
packages/devextreme/js/ui/themes.js Wrapper file for themes module - missing init export
packages/devextreme/js/ui/splitter_control.js Simple re-export wrapper
packages/devextreme/js/ui/shared/ui.editor_factory_mixin.js Simple re-export wrapper
packages/devextreme/js/ui/shared/filtering.js Simple re-export wrapper
packages/devextreme/js/ui/shared/accessibility.js Named exports wrapper
packages/devextreme/js/__internal/ui/themes.ts TypeScript implementation with full type annotations
packages/devextreme/js/__internal/ui/splitter_control.ts TypeScript implementation with unsafe optional chaining
packages/devextreme/js/__internal/ui/shared/ui.editor_factory_mixin.ts TypeScript implementation with name shadowing
packages/devextreme/js/__internal/ui/shared/filtering.ts TypeScript implementation with proper typing
packages/devextreme/js/__internal/ui/shared/accessibility.ts TypeScript implementation with name shadowing
packages/devextreme/js/__internal/ui/gantt/ui.gantt.ts Updated to use destructuring for options
packages/devextreme/js/__internal/ui/gantt/ui.gantt.size_helper.ts Updated with proper type imports and annotations
packages/devextreme/js/__internal/ui/file_manager/ui.file_manager.adaptivity.ts Updated with imported types instead of local interfaces
packages/devextreme/js/__internal/pagination/content.tsx Updated import path for accessibility helper
packages/devextreme/js/__internal/grids/grid_core/editor_factory/m_editor_factory.ts Removed type assertion that may cause issues

@pharret31 pharret31 force-pushed the 25_2_2612-other-ui-move-files-to-ts branch from 1592ee9 to eabbef4 Compare November 19, 2025 21:08
Copilot AI review requested due to automatic review settings November 19, 2025 21:16
@pharret31 pharret31 force-pushed the 25_2_2612-other-ui-move-files-to-ts branch from eabbef4 to 3409e6f Compare November 19, 2025 21:16
Copilot finished reviewing on behalf of pharret31 November 19, 2025 21:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 5 comments.

@pharret31 pharret31 merged commit 1b4532f into DevExpress:25_2 Nov 20, 2025
129 of 131 checks passed
@pharret31 pharret31 deleted the 25_2_2612-other-ui-move-files-to-ts branch November 20, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants