Skip to content

Conversation

@Alyar666
Copy link
Contributor

No description provided.

@Alyar666 Alyar666 self-assigned this Nov 20, 2025
@Alyar666 Alyar666 requested a review from a team as a code owner November 20, 2025 00:34
Copilot AI review requested due to automatic review settings November 20, 2025 00:34
Copilot finished reviewing on behalf of Alyar666 November 20, 2025 00:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the AI Column module structure by reorganizing files into a clearer directory hierarchy and creating a barrel export pattern for better encapsulation and maintainability.

Key Changes:

  • Extracted AIPromptEditor class and related utilities into a separate ai_prompt_editor module at the grid_core level
  • Reorganized AI Column module into controllers/ and views/ subdirectories
  • Created a barrel export file (index.ts) to centralize exports from the AI Column module
  • Updated all import paths across DataGrid and TreeList to use the new module structure

Reviewed Changes

Copilot reviewed 13 out of 18 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/devextreme/js/__internal/grids/grid_core/ai_column/index.ts New barrel export file that centralizes exports for AIColumnController, AIPromptEditorViewController, columnHeadersViewExtender, and AIPromptEditorView
packages/devextreme/js/__internal/grids/grid_core/ai_prompt_editor/ai_prompt_editor.ts Newly extracted AIPromptEditor class with popup-based UI logic for AI prompt editing
packages/devextreme/js/__internal/grids/grid_core/ai_prompt_editor/types.ts Type definitions for AIPromptEditor, including AIPromptEditorOptions and AIPromptEditorAction
packages/devextreme/js/__internal/grids/grid_core/ai_prompt_editor/utils.ts Utility functions for prompt handling (getPrompt, isPromptChanged)
packages/devextreme/js/__internal/grids/grid_core/ai_prompt_editor/const.ts Constants for popup options, CSS classes, and button indices
packages/devextreme/js/__internal/grids/grid_core/ai_prompt_editor/ai_prompt_editor.integration.test.ts Comprehensive test suite for AIPromptEditor with 667 lines of tests covering all functionality
packages/devextreme/js/__internal/grids/grid_core/ai_column/views/m_ai_prompt_editor_view.ts Updated imports to reference AIPromptEditor from the new ai_prompt_editor module
packages/devextreme/js/__internal/grids/grid_core/ai_column/views/m_ai_prompt_editor_view.test.ts Updated test imports to match new module structure
packages/devextreme/js/__internal/grids/grid_core/ai_column/views/m_ai_column_view.ts Updated imports to reference controllers and utilities from reorganized structure
packages/devextreme/js/__internal/grids/grid_core/ai_column/controllers/m_ai_column_controller.ts Updated imports to use relative paths pointing to parent directories for grid_core modules
packages/devextreme/js/__internal/grids/grid_core/ai_column/controllers/m_ai_prompt_editor_view_controller.ts Updated imports to reference view from views subdirectory
packages/devextreme/js/__internal/grids/grid_core/ai_column/controllers/m_ai_column_integration_controller.ts Updated imports to use relative paths and reference types/utils from parent ai_column directory
packages/devextreme/js/__internal/grids/grid_core/ai_column/controllers/m_ai_column_cache_controller.ts Updated import to reference Controller from parent grid_core directory
packages/devextreme/js/__internal/grids/grid_core/ai_column/__tests__/ai_column.integration.test.ts Updated to import CLASSES from parent const.ts
packages/devextreme/js/__internal/grids/grid_core/ai_column/__tests__/unsupported_base_properties.integration.test.ts New comprehensive test file (395 lines) testing unsupported sorting and grouping properties for AI columns
packages/devextreme/js/__internal/grids/grid_core/m_types.ts Updated type definitions to reference controllers and views in their new subdirectories
packages/devextreme/js/__internal/grids/data_grid/module_not_extended/ai_column.ts Simplified imports using the new barrel export pattern
packages/devextreme/js/__internal/grids/tree_list/module_not_extended/ai_column.ts Simplified imports using the new barrel export pattern

@Alyar666 Alyar666 merged commit fbc6f5e into DevExpress:25_2 Nov 21, 2025
106 of 107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants