Mesh loaders kevin #199
Merged
Mesh loaders kevin #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
July 1, 2025 21:16
|
btw remove |
added 2 commits
July 25, 2025 17:34
Comment on lines
74
to
+83
| n0 = normalize(nbl::hlsl::spirv::unpackSnorm4x8(v0).xyz); | ||
| n1 = normalize(nbl::hlsl::spirv::unpackSnorm4x8(v1).xyz); | ||
| n2 = normalize(nbl::hlsl::spirv::unpackSnorm4x8(v2).xyz); | ||
| } | ||
| break; | ||
| case OT_SPHERE: | ||
| case OT_CYLINDER: | ||
| case OT_ARROW: | ||
| case OT_CONE: | ||
| case NT_R32G32B32_SFLOAT: | ||
| { | ||
| uint32_t v0 = vk::RawBufferLoad<uint32_t>(vertexBufferAddress + indices[0] * vertexStride); | ||
| uint32_t v1 = vk::RawBufferLoad<uint32_t>(vertexBufferAddress + indices[1] * vertexStride); | ||
| uint32_t v2 = vk::RawBufferLoad<uint32_t>(vertexBufferAddress + indices[2] * vertexStride); | ||
|
|
||
| n0 = normalize(unpackNormals3x10(v0)); | ||
| n1 = normalize(unpackNormals3x10(v1)); | ||
| n2 = normalize(unpackNormals3x10(v2)); | ||
| n0 = normalize(vk::RawBufferLoad<float3>(normalBufferAddress + indices[0] * 12)); | ||
| n1 = normalize(vk::RawBufferLoad<float3>(normalBufferAddress + indices[1] * 12)); | ||
| n2 = normalize(vk::RawBufferLoad<float3>(normalBufferAddress + indices[2] * 12)); |
There was a problem hiding this comment.
normalization could have been hosted outside the switch to happen later, but oh well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix example 9, 67, 71