Fix polygon manipulator aabb computation

[kevyuu]

Fix AABB computation on cpu polygon geometry

[devshgraphicsprogramming]

you're indexing the wrong thing, its not one view per vertex

its supposed to be

// precompute the count outside the lambda to optimize
const auto jointViewCount = geo->isSkinned() ? geo->getJointWeightViews().size():0;

for (auto j=0; j<jointViewCount; j++)
{
   hlsl::float32_t4 weight;
   jointWeightView.weights.decodeElement(vertex_i,weight);
   if (j==jointViewCount-1)
   {
      // can also precompute active channel mask on last view and use `hlsl::any(weight<promote<float32_t4>(0.f) && activeMask)`
      for (auto c=0; c<getChannelCount(jointWeightView.weights.format); c++)
      if (weight[c]>0.f)
          return true;
   }
   else if (hlsl::any(hlsl::promote<hlsl::float32_t4>(0.f)<weight))
      return true;
}
return false;

[devshgraphicsprogramming]

if you have Maximum of 1-4 bones affecting a vertex, you only have one joint view, if you have 5-8 you have two joint views (but all except last have formats with 4 components for index and weight, while the last has whatever remains to handle non multiple of 4 max simultaneous bone affections per vertex), etc.

[kevyuu]

Done.

[devshgraphicsprogramming]

huh ?

1. Misleading name, the joints per vertex is an upper bound, also it comes from format channel counts across the joint weight views
2. should be constexpr static inline otherwise you mess up linking
3. Wrong naming convention, capital snake case is for macros only, constants are capital starting camel case

[devshgraphicsprogramming]

actually just remove it

[devshgraphicsprogramming]

still a TODO

[kevyuu]

Done.

[devshgraphicsprogramming]

compute this at start of function outside the lambda

[kevyuu]

Done.

[devshgraphicsprogramming]

just do this for all views, I'm not sure I put a hard requirement that all weight and index views must have 4 component format (I just put a req that component count must match for each weight-index pair)

[kevyuu]

Done.