Remove flags doTCP and exactPathMatching from dnsdist listeners#55
Merged
Conversation
* The doTCP flag isn't expected neither on addTLSLocal nor on addDOHLocal. It used to be there on addLocal but was removed in 1.4.0. https://www.dnsdist.org/reference/config.html?highlight=dotcp#addLocal * The exactPathMatching flag only exists on addDOHLocal and not on addTLSLocal. It has been introduced in 1.6.0 to allow reverting a behavior change introduced in 1.5.0. No need to specify the default explicitly. https://www.dnsdist.org/reference/config.html?highlight=exactPathMatching#addDOHLocal Removal of those flags reduces log noise in noble. It doesn't change behavior in jammy.
Member
Author
|
Example of log spam due to these flags (when dnsdist is starting up): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removal of those flags reduces log noise in noble. It doesn't change behavior in jammy.