Skip to content

Solution #2379 - Mridul/Edited - 08/03/2025 #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mrid88
Copy link
Member

@mrid88 mrid88 commented Mar 8, 2025

added both the files, please check

@JRS296 JRS296 self-requested a review March 17, 2025 12:44
Copy link
Member

@JRS296 JRS296 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly improve the explanation.md files (Primarily the formatting using Markdown, as well as explanation of the Time and Space Complexity)

danzang100 added a commit to danzang100/LeetCode-Solutions that referenced this pull request Mar 18, 2025
Copy link
Member

@JRS296 JRS296 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly make the requested changes

Comment on lines +1 to +19
n: The length of the input string blocks.

b: A counter to keep track of the number of black blocks within a sliding window.

Max: To store the maximum number of black blocks found in any sliding window of length k.

This loop counts the number of black blocks ('B') in the first window of length k and assigns it to both b and Max.

This loop slides the window across the string from index 0 to n - k - 1.

It decreases the count b if the block at the start of the window is 'B'.

It increases the count b if the block at the end of the window is 'B'.

Updates Max to the maximum value between the current Max and b.

If Max becomes equal to or greater than k, it means we already have k consecutive black blocks, and hence, no recoloring is needed. The function returns 0.

If the loop completes without finding k consecutive black blocks, the function returns the difference between k and Max, which represents the minimum number of recolors needed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be much better! utilize Markdown

}
}

Max = b;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not use Capital letters for Variable names. This should be 'max'

@@ -0,0 +1,30 @@
class Solution {
public int minimumRecolors(String blocks, int k) {
int n = blocks.length(), b = 0, Max;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally try to have variable names one line after the other, so that it is more readable

Comment on lines +1 to +34
private static boolean[] isPrime = new boolean[1000001]; This boolean array is used to mark prime numbers up to 1000000. The size of the array is 1000001 to include the number 1000000.

Static Block:
The static block is used to initialize the isPrime array and precompute the prime numbers.

Arrays.fill(isPrime, true); This method sets all elements of the isPrime array to true, assuming all numbers are prime initially.

precompute(); This method is called to mark non-prime numbers in the isPrime array.

Method: precompute()
This method uses the Sieve of Eratosthenes algorithm to mark non-prime numbers in the isPrime array.

isPrime[0] = isPrime[1] = false; Numbers 0 and 1 are not prime.

A loop is used to iterate from 2 to sqrt(1000000).

If isPrime[i] is true, all multiples of i are marked as false (not prime) starting from i*i.

Method: closestPrimes(int left, int right)
This method finds the closest prime numbers within the range [left, right].

int prev = -1, minDiff = Integer.MAX_VALUE; Variables to track the previous prime number and the minimum difference between consecutive primes.

int num1 = -1, num2 = -1; Variables to store the closest prime numbers.

A loop iterates through the range [left, right].

If isPrime[i] is true, the number i is a prime.

If prev is not -1 and the difference (i - prev) is less than minDiff, update minDiff and set num1 to prev and num2 to i.

Update prev to i.

If no prime numbers are found, return new int[]{-1, -1}. Otherwise, return the closest prime numbers num1 and num2.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't have to use the actual implemnentations to explain everything. Instead of private statuc boolean[], you can just say that the static boolean array.

Try to think of how you would explain this to someone during an interview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants