Skip to content

fix: resolve footer alignment issues (#31) #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ankitkr104 wants to merge 2 commits into from
Closed

fix: resolve footer alignment issues (#31) #34

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2645958
fix: resolve footer alignment issues (#31)
ankitkr104 Feb 26, 2026
465d901
Merge branch 'main' into fix/footer-alignment-issue-31-clean
ankitkr104 May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
101 changes: 100 additions & 1 deletion src/App.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,4 +416,103 @@
a:nth-of-type(2) .logo {
animation: logo-spin infinite 20s linear;
}
}
}

/* Footer Styles */
.footer-container {
width: 100%;
padding: 1.5rem 0;
margin-top: 4rem;
background: rgba(21, 21, 21, 0.5);
border-top: 1px solid rgba(243, 193, 129, 0.1);
}

.footer-content {
display: flex;
align-items: center;
justify-content: space-between;
max-width: 100%;
padding: 0 2rem;
gap: 2rem;
}

.footer-copyright {
font-family: 'Montserrat', sans-serif;

@coderabbitai coderabbitai Bot Feb 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Remove quotes around font family name.

Stylelint reports font-family-name-quotes error. Per CSS conventions, generic font family names like Montserrat should not be quoted when they don't contain special characters.

🔧 Proposed fix 
 .footer-copyright {
-  font-family: 'Montserrat', sans-serif;
+  font-family: Montserrat, sans-serif;
   font-size: 14px;
   color: `#F9EBDB`;
   margin: 0;
 }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
font-family: 'Montserrat', sans-serif;
font-family: Montserrat, sans-serif;
🧰 Tools
🪛 Stylelint (17.3.0)

[error] 424-424: Unexpected quotes around "Montserrat" (font-family-name-quotes)

(font-family-name-quotes)

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@src/App.css` at line 424, The font-family declaration that uses a quoted
Montserrat triggers stylelint's font-family-name-quotes rule; update the
font-family property that currently lists Montserrat in quotes to use the
unquoted Montserrat while keeping the existing sans-serif fallback so the
declaration uses the unquoted font family name.

font-size: 14px;
color: #F9EBDB;
margin: 0;
}

.footer-brand {
display: flex;
align-items: center;
gap: 1rem;
}

.footer-brand img {
width: 32px;
height: auto;
}

.footer-title {
font-family: 'Space Mono', monospace;
font-size: 18px;
font-weight: 700;
color: #F9EBDB;
margin: 0;
white-space: nowrap;
}

.footer-social {
display: flex;
align-items: center;
gap: 1rem;
}

.footer-social a {
display: flex;
align-items: center;
justify-content: center;
width: 40px;
height: 40px;
padding: 0.5rem;
background: rgba(243, 193, 129, 0.1);
border: 1px solid rgba(243, 193, 129, 0.2);
border-radius: 50%;
transition: all 0.3s ease;
}

.footer-social a:hover {
background: rgba(243, 193, 129, 0.2);
border-color: rgba(243, 193, 129, 0.4);
transform: translateY(-2px);
box-shadow: 0 4px 12px rgba(243, 193, 129, 0.3);
}

.footer-social img {
width: 20px;
height: 20px;
object-fit: contain;
}

/* Footer Mobile Responsive */
@media screen and (max-width: 768px) {
.footer-content {
flex-direction: column;
text-align: center;
padding: 0 1rem;
}

.footer-copyright {
order: 3;
margin-top: 1rem;
}

.footer-brand {
order: 1;
}

.footer-social {
order: 2;
}
}