DYN-8303: Enable deferred node load #16337
Conversation
# Conflicts: # src/DynamoCoreWpf/Views/Core/NodeView.xaml # src/DynamoCoreWpf/Views/Core/NodeView.xaml.cs
…eNodeBackground
Introduced a new middleware to handle user authentication for protected routes. This ensures that only authenticated users can access certain endpoints, improving application security.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8303
There was a problem hiding this comment.
Pull Request Overview
This PR enables deferred node loading for large graphs, refactors node styling with converter bindings, adds embedded cached node images, and introduces a node load progress counter.
- Load nodes lazily when graph size exceeds threshold.
- Simplify fade‐style bindings to converters.
- Embed and display cached node images; show loading progress.
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/DynamoCoreWpf/Views/Core/NodeView.xaml.cs | Implements deferred node load, image caching, pixel arrays, style updates |
| src/DynamoCoreWpf/ViewModels/Core/WorkspaceViewModel.cs | Tracks node load progress, exposes LoadedNodesCount and NodesLoading |
| src/DynamoCoreWpf/Controls/NotificationsControl.xaml | Adds UI indicator for node loading progress |
| src/DynamoCoreWpf/DynamoCoreWpf.csproj | Embeds NodeCacheImages.resx |
| src/DynamoCoreWpf/PublicAPI.Unshipped.txt | Exposes new API entries for node image caching |
Comments suppressed due to low confidence (1)
src/DynamoCoreWpf/PublicAPI.Unshipped.txt:4465
- [nitpick] Exposing a UI helper method like
GetNodeImagein the public API may leak internal implementation details. Consider keeping it internal or moving caching logic to a dedicated service.
static Dynamo.Controls.NodeView.GetNodeImage(string nodeName) -> System.Windows.Media.Imaging.BitmapImage
| }; | ||
|
|
||
| Canvas.SetZIndex(renameIndicator, 5); | ||
| SetValue(Panel.ZIndexProperty, 5); |
There was a problem hiding this comment.
This call sets ZIndex on the NodeView itself rather than on renameIndicator. Use renameIndicator.SetValue(Panel.ZIndexProperty, 5); or Canvas.SetZIndex(renameIndicator, 5); instead.
| SetValue(Panel.ZIndexProperty, 5); | |
| renameIndicator.SetValue(Panel.ZIndexProperty, 5); |
Copilot uses AI. Check for mistakes.
Replaces the static node loading indicator with an animated progress spinner and detailed loading status in NotificationsControl.xaml. Makes LoadedNodesCount and NodesLoading properties public in WorkspaceViewModel for better data binding. Caches node images after conversion in NodeView.xaml.cs to improve performance.
DYN-8303: Static Field Optimizations
|
closing since the commit history got nuked by a bad merge created a new PR from a fresh branch #16361 |
2 participants
Purpose
This PR:
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Enable deferred node load
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of