Skip to content

DYN-7145: handle large package upload #16375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
+931 −61
Open

DYN-7145: handle large package upload #16375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6803408
async file loading
dnenov Jul 11, 2025
e415fd5
hooking up front end
dnenov Jul 11, 2025
173f0b3
hooked up frontend
dnenov Jul 14, 2025
a854a75
small null fix
dnenov Jul 14, 2025
9682521
revert change
dnenov Jul 15, 2025
6dcd1ca
tests, warnings
dnenov Jul 17, 2025
4569a5e
cleanup
dnenov Jul 17, 2025
36e046b
resources
dnenov Jul 17, 2025
09ed730
typo, resources to API
dnenov Jul 17, 2025
9c7059d
patch react version to 0.0.21
dnenov Jul 18, 2025
351bf2a
Merge remote-tracking branch 'upstream/master' into pm-large-packages
dnenov Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/DynamoCoreWpf/DynamoCoreWpf.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@

<Target Name="NpmRunBuildPMWizard" BeforeTargets="BeforeBuild">
<PropertyGroup>
<PackageVersion>0.0.21</PackageVersion>
<PackageVersion>0.0.22</PackageVersion>
<PackageName>PackageManagerWizard</PackageName>
</PropertyGroup>
Expand Down
18 changes: 18 additions & 0 deletions src/DynamoCoreWpf/Properties/Resources.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions src/DynamoCoreWpf/Properties/Resources.en-US.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1325,6 +1325,10 @@ You can always redownload the package.</value>
<value>Failed to add file: {0}</value>
<comment>Message box content</comment>
</data>
<data name="MessageFailedToAddMultipleFiles" xml:space="preserve">
<value>Failed to add the following files:\n\n {0}</value>
<comment>Message box content</comment>
</data>
<data name="MessageFailedToApplyCustomization" xml:space="preserve">
<value>Failed to apply NodeViewCustomization for {0}</value>
</data>
Expand Down Expand Up @@ -1581,6 +1585,9 @@ Next assemblies were loaded several times:
<data name="PackageDuplicateAssemblyWarning" xml:space="preserve">
<value>Due to limitations in the .NET framework, it is not possible to update your package assembly while it is already loaded. Please update the assembly while {0} is not running and try again.</value>
</data>
<data name="PackageDuplicateAssembliesFoundMessage" xml:space="preserve">
<value>\n\nDuplicate assemblies found: {0}</value>
</data>
<data name="PackageDuplicateAssemblyWarningTitle" xml:space="preserve">
<value>Cannot update assembly</value>
</data>
Expand Down
7 changes: 7 additions & 0 deletions src/DynamoCoreWpf/Properties/Resources.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2052,6 +2052,9 @@ Do you want to install the latest Dynamo update?</value>
<data name="PackageDuplicateAssemblyWarning" xml:space="preserve">
<value>Due to limitations in the .NET framework, it is not possible to update your package assembly while it is already loaded. Please update the assembly while {0} is not running and try again.</value>
</data>
<data name="PackageDuplicateAssembliesFoundMessage" xml:space="preserve">
<value>\n\nDuplicate assemblies found: {0}</value>
</data>
<data name="PackageDuplicateAssemblyWarningTitle" xml:space="preserve">
<value>Cannot update assembly</value>
</data>
Expand Down Expand Up @@ -2443,6 +2446,10 @@ Next assemblies were loaded several times:
<value>Failed to add file: {0}</value>
<comment>Message box content</comment>
</data>
<data name="MessageFailedToAddMultipleFiles" xml:space="preserve">
<value>Failed to add the following files:\n\n {0}</value>
<comment>Message box content</comment>
</data>
<data name="MessageConfirmToSaveReadOnlyCustomNode" xml:space="preserve">
<value>We can't save "{0}" because the file is read-only or contains unresolved or invalid nodes. To keep changes, would you like to "Save As..." with a different name or path?</value>
<comment>Message box content</comment>
Expand Down
8 changes: 7 additions & 1 deletion src/DynamoCoreWpf/PublicAPI.Unshipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1023,6 +1023,7 @@ Dynamo.PackageManager.PublishPackageViewModel.BaseVersionHeader.set -> void
Dynamo.PackageManager.PublishPackageViewModel.BuildVersion.get -> string
Dynamo.PackageManager.PublishPackageViewModel.BuildVersion.set -> void
Dynamo.PackageManager.PublishPackageViewModel.CancelCommand.get -> Prism.Commands.DelegateCommand
Dynamo.PackageManager.PublishPackageViewModel.CancelFileLoading() -> void
Dynamo.PackageManager.PublishPackageViewModel.CanEditName.get -> bool
Dynamo.PackageManager.PublishPackageViewModel.ClearMarkdownDirectoryCommand.get -> Prism.Commands.DelegateCommand
Dynamo.PackageManager.PublishPackageViewModel.CompatibilityMatrix.get -> System.Collections.Generic.ICollection<Greg.Requests.PackageCompatibility>
Expand Down Expand Up @@ -1123,6 +1124,7 @@ Dynamo.PackageManager.PublishPackageViewModel.UploadHandle.get -> Dynamo.Package
Dynamo.PackageManager.PublishPackageViewModel.UploadHandle.set -> void
Dynamo.PackageManager.PublishPackageViewModel.Uploading.get -> bool
Dynamo.PackageManager.PublishPackageViewModel.Uploading.set -> void
Dynamo.PackageManager.PublishPackageViewModel.UploadProgress -> System.Action<int, int, string>
Dynamo.PackageManager.PublishPackageViewModel.UploadState.get -> Dynamo.PackageManager.PackageUploadHandle.State
Dynamo.PackageManager.PublishPackageViewModel.UploadState.set -> void
Dynamo.PackageManager.PublishPackageViewModel.UploadType.get -> Dynamo.PackageManager.PackageUploadHandle.UploadType
Expand Down Expand Up @@ -1716,20 +1718,22 @@ Dynamo.UI.Views.ScriptObject.SignOut() -> bool
Dynamo.UI.Views.ScriptWizardObject
Dynamo.UI.Views.ScriptWizardObject.AddFileOrFolder(string fileOrFolder) -> void
Dynamo.UI.Views.ScriptWizardObject.ApplicationLoaded() -> void
Dynamo.UI.Views.ScriptWizardObject.CancelUpload() -> void
Dynamo.UI.Views.ScriptWizardObject.ClearMarkdownContent() -> void
Dynamo.UI.Views.ScriptWizardObject.LoadMarkdownContent() -> void
Dynamo.UI.Views.ScriptWizardObject.LogMessage(string message) -> void
Dynamo.UI.Views.ScriptWizardObject.OpenFolder(string path) -> void
Dynamo.UI.Views.ScriptWizardObject.Publish() -> void
Dynamo.UI.Views.ScriptWizardObject.RemoveFileOrFolder(string name) -> void
Dynamo.UI.Views.ScriptWizardObject.Reset() -> void
Dynamo.UI.Views.ScriptWizardObject.ScriptWizardObject(System.Action<string> requestAddFileOrFolder, System.Action<string> requestRemoveFileOrFolder, System.Action<bool> requestRetainFolderStructure, System.Action<string> requestUpdatePackageDetails, System.Action requestSubmit, System.Action requestPublish, System.Action requestReset, System.Action<string> requestToggleNodeLibraryOnItem, System.Action<string> requestOpenFolder, System.Action<string> requestUpdateCompatibilityMatrix, System.Action requestLoadMarkdownContent, System.Action requestClearMarkdownContent, System.Action<string> requestLogMessage, System.Action requestApplicationLoaded, System.Action<string, string> requestShowDialog) -> void
Dynamo.UI.Views.ScriptWizardObject.ScriptWizardObject(System.Action<string> requestAddFileOrFolder, System.Action<string> requestRemoveFileOrFolder, System.Action<bool> requestRetainFolderStructure, System.Action<string> requestUpdatePackageDetails, System.Action requestSubmit, System.Action requestPublish, System.Action requestReset, System.Action<string> requestToggleNodeLibraryOnItem, System.Action<string> requestOpenFolder, System.Action<string> requestUpdateCompatibilityMatrix, System.Action requestLoadMarkdownContent, System.Action requestClearMarkdownContent, System.Action<string> requestLogMessage, System.Action requestApplicationLoaded, System.Action<string, string> requestShowDialog, System.Action requestCancelUpload, System.Action<int, int, string> requestUploadProgress) -> void
Dynamo.UI.Views.ScriptWizardObject.ShowDialog(string title, string message) -> void
Dynamo.UI.Views.ScriptWizardObject.Submit() -> void
Dynamo.UI.Views.ScriptWizardObject.ToggleNodeLibraryOnItem(string name) -> void
Dynamo.UI.Views.ScriptWizardObject.ToggleRetainFolderStructure(bool flag) -> void
Dynamo.UI.Views.ScriptWizardObject.UpdateCompatibilityMatrix(string jsonPayload) -> void
Dynamo.UI.Views.ScriptWizardObject.UpdatePackageDetails(string jsonPayload) -> void
Dynamo.UI.Views.ScriptWizardObject.UploadProgress(int currentFile, int totalFiles, string currentFileName) -> void
Dynamo.UI.Views.SplashScreen
Dynamo.UI.Views.SplashScreen.CloseWasExplicit.get -> bool
Dynamo.UI.Views.SplashScreen.DynamicSplashScreenReady -> Dynamo.UI.Views.SplashScreen.DynamicSplashScreenReadyHandler
Expand Down Expand Up @@ -5055,6 +5059,7 @@ static Dynamo.Wpf.Properties.Resources.MessageErrorOpeningInvalidPath.get -> str
static Dynamo.Wpf.Properties.Resources.MessageExcessiveLoadTime.get -> string
static Dynamo.Wpf.Properties.Resources.MessageExcessiveLoadTimeTitle.get -> string
static Dynamo.Wpf.Properties.Resources.MessageFailedToAddFile.get -> string
static Dynamo.Wpf.Properties.Resources.MessageFailedToAddMultipleFiles.get -> string
static Dynamo.Wpf.Properties.Resources.MessageFailedToApplyCustomization.get -> string
static Dynamo.Wpf.Properties.Resources.MessageFailedToAttachToRowColumn.get -> string
static Dynamo.Wpf.Properties.Resources.MessageFailedToDelete.get -> string
Expand Down Expand Up @@ -5115,6 +5120,7 @@ static Dynamo.Wpf.Properties.Resources.NodeAutocomplete.get -> string
static Dynamo.Wpf.Properties.Resources.NodeAutocompleteDocumentationUriString.get -> string
static Dynamo.Wpf.Properties.Resources.NodeAutoCompleteNotAvailableForCollapsedGroups.get -> string
static Dynamo.Wpf.Properties.Resources.NodeAutoCompleteToolTip.get -> string
static Dynamo.Wpf.Properties.Resources.PackageDuplicateAssembliesFoundMessage.get -> string
static Dynamo.Wpf.Properties.Resources.PreferencesViewEnableNodeAutoCompleteNewUI.get -> string
static Dynamo.Wpf.Properties.Resources.PreferencesViewEnableNodeAutoCompleteNewUITooltipText.get -> string
static Dynamo.Wpf.Properties.Resources.NodeContextMenuEnablePeriodicUpdate.get -> string
Expand Down
Loading
Loading