-
Notifications
You must be signed in to change notification settings - Fork 665
DYN-9388 Make PythonNet3 default python engine in Dynamo 4.0 #16516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
DYN-9388 Make PythonNet3 default python engine in Dynamo 4.0 #16516
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9388
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request makes PythonNet3 the default Python engine in Dynamo 4.0, replacing CPython3. This is a major infrastructure change that affects the Python execution environment throughout the application.
Key changes include:
- Replaced the DSCPython library with DSPythonNet3 as the default Python engine
- Added automatic migration functionality to convert CPython3 nodes to PythonNet3 when opening older graphs
- Implemented user notification systems including toast messages and dialog boxes to inform users about the engine change
Reviewed Changes
Copilot reviewed 128 out of 138 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
test/settings/DynamoSettings-NewSettings.xml | Added setting to hide CPython3 notifications |
Multiple test .dyn files | Updated Python nodes from "CPython3" to "PythonNet3" engine |
Multiple test .cs files | Updated library references and engine names from DSCPython to DSPythonNet3 |
src/Libraries/DSPythonNet3/* | New Python engine implementation replacing DSCPython |
src/Libraries/DSCPython/* | Old Python engine files being removed/replaced |
src/Libraries/PythonNodeModels/* | Updated default engine and localization resources |
src/PythonMigrationViewExtension/* | Enhanced migration logic to handle CPython3 to PythonNet3 conversion |
src/DynamoCoreWpf/* | Added UI components for notifications and preferences |
Files not reviewed (4)
- src/DynamoCoreWpf/Properties/Resources.Designer.cs: Language not supported
- src/Libraries/DSCPython/Properties/Resources.Designer.cs: Language not supported
- src/Libraries/PythonNodeModels/Properties/Resources.Designer.cs: Language not supported
- src/PythonMigrationViewExtension/Properties/Resources.Designer.cs: Language not supported
Comments suppressed due to low confidence (9)
…honNet3-default-Python-engine-in-Dynamo-4.0-250924
Purpose
Now superseded by #16548
PR in response to DYN-9388.
Declarations
Check these if you believe they are true
Release Notes
Make PythonNet3 default python engine in Dynamo 4.0
Reviewers
@zeusongit
@DynamoDS/eidos
FYIs
@dnenov
@achintyabhat