Skip to content

Conversation

@chubakueno
Copy link
Contributor

@chubakueno chubakueno commented Sep 30, 2025

Purpose

Disable sign in on no network mode

Declarations

Check these if you believe they are true

Release Notes

Disable sign in on no network mode

Reviewers

@DynamoDS/eidos
@DynamoDS/synapse

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8974

@chubakueno chubakueno requested review from a team September 30, 2025 17:43
@zeusongit
Copy link
Contributor

error RS0016: Symbol 'SignInOfflineButtonContentToolTip.get' is not part of the declared public API

needs to be added

@QilongTang QilongTang requested a review from Copilot September 30, 2025 21:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR disables the sign-in functionality when Dynamo is running in "no network mode" to provide a better user experience by preventing failed authentication attempts when network connectivity is unavailable. The changes introduce logic to conditionally disable the login menu and provide appropriate user feedback.

  • Disables the login menu when NoNetworkMode is enabled
  • Updates tooltip text to inform users how to enable sign-in functionality
  • Ensures tooltip is visible even when the button is disabled

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
DynamoView.xaml.cs Adds logic to disable login menu when no network mode is active
ShortcutToolbar.xaml.cs Sets initial login menu state based on network mode during toolbar load
ShortcutToolbar.xaml Enables tooltips on disabled buttons and implements conditional tooltip content
Resources.resx Adds new tooltip text for offline sign-in state
Resources.en-US.resx Adds English localization for the new offline tooltip
Files not reviewed (1)
  • src/DynamoCoreWpf/Properties/Resources.Designer.cs: Language not supported

@chubakueno
Copy link
Contributor Author

error RS0016: Symbol 'SignInOfflineButtonContentToolTip.get' is not part of the declared public API

needs to be added

fixed!

@zeusongit zeusongit merged commit f4e0459 into DynamoDS:master Oct 1, 2025
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants