-
Notifications
You must be signed in to change notification settings - Fork 18
Make sure TensorFlow also works on offline machines #275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 16 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
deed7dd
First try to work around needing to download the dataset fom tensorfl…
laraPPr f4ecb2d
work in progress make tensorflow test also work ofline
laraPPr 6287c7d
Merge branch 'EESSI:main' into TensorFlow_offline
laraPPr 7bc7a52
use general path where to find downloaded files
laraPPr 230e097
make pyhton linter happy
laraPPr caeb24f
make pyhton linter happy
laraPPr b81c8d1
remove comment
laraPPr 5a5f921
remove double code
laraPPr 9bd0041
use EESSI_TEST_SUITE_DISABLE_DOWNLOAD
laraPPr be06cc1
use current_partition and current_system and set the neccesary env_vars
laraPPr b44b73f
use path= in mnist.load_data()
laraPPr 93da4f1
implement skip when data cannot be found
laraPPr e3d4c3f
split too long line
laraPPr 760ba53
remove unneccessary f-string
laraPPr a009ca9
Make sure that test-suite works when EXTRAS.INTERNET_ACCESS is not se…
laraPPr 4ee9ae6
use features instead of extras
laraPPr 9a0e41a
Make sure the test is not setup when running on an offline system wit…
laraPPr e69a372
We need this new constant in this feature branch in order to test it
919f4fd
Add -offline to valid_systems if a test requires nodes that are online
1019f21
Use FEATURES.OFFLINE in hooks (as we were supposed to). Also, make th…
27bd6e6
Fix a flake8 issue
ba0e4f8
random change
4c19d5c
Merge branch 'main' into pr275
5e73445
remove duplicate function
a405baf
use log_once function
28748e3
remove unneeded gobal usage
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See if we can move this check to the
after_initstate. If so, and if this path does not exist, add-offlineto thevalid_systems.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've now split the funtion up in two. The first runs after init to check if the data is their and will set the necessary environment variable if it is. If not valid_systems gets edited with the new hook from #279. The other function is still required to run after
setupbecause we needself.current_partition.features.