Skip to content

Conversation

@suriyahgit
Copy link
Collaborator

This PR introduces Part 2 of the Sentinel-2 Crop Type Classification workflow, including the main Jupyter notebook and its required assets.

Related Issues:-

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@review-notebook-app
Copy link

review-notebook-app bot commented Oct 27, 2025

View / edit / reply to this conversation on ReviewNB

clausmichele commented on 2025-10-27T14:56:02Z
----------------------------------------------------------------

Line #1.    def _raster_bounds_polygon_32631(ds):

This function would work for any UTM projection, it's just creating a polygon. No need to specify 32631 in the name and description


@review-notebook-app
Copy link

review-notebook-app bot commented Oct 27, 2025

View / edit / reply to this conversation on ReviewNB

clausmichele commented on 2025-10-27T14:56:03Z
----------------------------------------------------------------

Why climatologies? We are not working with climate data here. Monthly composites?


@review-notebook-app
Copy link

review-notebook-app bot commented Oct 27, 2025

View / edit / reply to this conversation on ReviewNB

clausmichele commented on 2025-10-27T14:56:04Z
----------------------------------------------------------------

Line #72.    ds = np.where(np.isin(total_scaled, [1, 2, 4, 8, 16]), total_scaled, 0)

Why are you defining colors for combination of classes if we don't use them?


@clausmichele clausmichele changed the base branch from main to dev November 5, 2025 08:28
@clausmichele clausmichele merged commit 4a7fefc into dev Nov 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants