-
Notifications
You must be signed in to change notification settings - Fork 340
ctsm5.3.083: Pass nutrient supplementation status to FATES #3348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test ERS_D_Ld60.f45_f45_mg37.I2000Clm50FatesCruRsGs.derecho_intel.clm-Fates all PASS, didn't compare with base yet |
|
I started aux_clm testing on Izumi. I'll start fates testing later after we see other results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CTSM changes are small and pretty straightforward. My main request is I think we should change CNAllocate_Carbon_only to Allocate_Carbon_only in order to use it both for CN/BGC and FATES. Otherwise it makes the code confusing as we explicitly have to choose between CN/BGC or FATES.
I have a suggestion for changes to comments that made it clearer to me, feel free to adjust as you see fit.
We should probably have a quick discussion on this if we can make that work.
Have the fates submodule point to the hash along the branch rather than the branch itself. This means we get a fixed version for testing rather than just the tip of the branch.
|
aux_clm passed as expected on Izumi. Everything there was b4b. We're now pointing to a FATES tag. @rgknox and I will create a baseline with ctsm5.3.082 and then compare to it for these changes. |
…pset longname violates the expected fail, so we can't have it uncommented yet
|
OK, the baselines are now all done and looking as expected. Ryan will do the ChangeLog files and we'll tag after that's done. |
…p' into fates-l2fr-supp
Description of changes
This set of changes passes nitrogen supplementation status to FATES. This status is needed when deciding whether or not to dynamically adjust leaf to fine root ratios based on nutrient storage. This status prevents plants from reducing root mass while soils have artificially high nitrogen during supplementation.
Specific notes
This is coupled with FATES PR: 1443
Contributors other than yourself, if any: @sharma-bharat @glemieux @walkeranthonyp
CTSM Issues Fixed (include github issue #):
Are answers expected to change (and if so in what way)? No, this should have not impact on answers on any configuration. This will only be relevant when we fully couple FATES-CLM-CN.
Any User Interface Changes (namelist or namelist defaults changes)?
No
Does this create a need to change or add documentation? Did you do so?
Not yet needed, no N limitations with FATES
Testing performed, if any:
(List what testing you did to show your changes worked as expected)
(This can be manual testing or running of the different test suites)
(Documentation on system testing is here: https://github.com/ESCOMP/ctsm/wiki/System-Testing-Guide)
(aux_clm on derecho for intel/gnu and izumi for intel/gnu/nag/nvhpc is the standard for tags on master)
NOTE: Be sure to check your coding style against the standard
(https://github.com/ESCOMP/ctsm/wiki/CTSM-coding-guidelines) and review
the list of common problems to watch out for
(https://github.com/ESCOMP/CTSM/wiki/List-of-common-problems).