Skip to content

Conversation

@rgknox
Copy link
Collaborator

@rgknox rgknox commented Jul 24, 2025

Description of changes

This set of changes passes nitrogen supplementation status to FATES. This status is needed when deciding whether or not to dynamically adjust leaf to fine root ratios based on nutrient storage. This status prevents plants from reducing root mass while soils have artificially high nitrogen during supplementation.

Specific notes

This is coupled with FATES PR: 1443

Contributors other than yourself, if any: @sharma-bharat @glemieux @walkeranthonyp
CTSM Issues Fixed (include github issue #):

Are answers expected to change (and if so in what way)? No, this should have not impact on answers on any configuration. This will only be relevant when we fully couple FATES-CLM-CN.

Any User Interface Changes (namelist or namelist defaults changes)?

No

Does this create a need to change or add documentation? Did you do so?

Not yet needed, no N limitations with FATES

Testing performed, if any:
(List what testing you did to show your changes worked as expected)
(This can be manual testing or running of the different test suites)
(Documentation on system testing is here: https://github.com/ESCOMP/ctsm/wiki/System-Testing-Guide)
(aux_clm on derecho for intel/gnu and izumi for intel/gnu/nag/nvhpc is the standard for tags on master)

NOTE: Be sure to check your coding style against the standard
(https://github.com/ESCOMP/ctsm/wiki/CTSM-coding-guidelines) and review
the list of common problems to watch out for
(https://github.com/ESCOMP/CTSM/wiki/List-of-common-problems).

@rgknox rgknox added FATES API update Changes to the FATES version that also REQUIRE an API change in CTSM bfb bit-for-bit labels Jul 24, 2025
@rgknox
Copy link
Collaborator Author

rgknox commented Jul 24, 2025

Test ERS_D_Ld60.f45_f45_mg37.I2000Clm50FatesCruRsGs.derecho_intel.clm-Fates all PASS, didn't compare with base yet

@glemieux glemieux moved this from Under Review to Stuck in FATES Pull Request Planning and Status Aug 22, 2025
@wwieder wwieder moved this to In progress - master in CTSM: Upcoming tags Oct 16, 2025
@glemieux glemieux moved this from Hold to Final Testing in FATES Pull Request Planning and Status Oct 20, 2025
@ekluzek ekluzek changed the title Pass nutrient supplementation status to FATES ctsm5.3.083: Pass nutrient supplementation status to FATES Oct 20, 2025
@ekluzek
Copy link
Collaborator

ekluzek commented Oct 27, 2025

I started aux_clm testing on Izumi. I'll start fates testing later after we see other results.

Copy link
Collaborator

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CTSM changes are small and pretty straightforward. My main request is I think we should change CNAllocate_Carbon_only to Allocate_Carbon_only in order to use it both for CN/BGC and FATES. Otherwise it makes the code confusing as we explicitly have to choose between CN/BGC or FATES.

I have a suggestion for changes to comments that made it clearer to me, feel free to adjust as you see fit.

We should probably have a quick discussion on this if we can make that work.

ekluzek and others added 2 commits October 28, 2025 15:49
Have the fates submodule point to the hash along the branch rather than the branch itself. This means we get a fixed version for testing rather than just the tip of the branch.
@ekluzek
Copy link
Collaborator

ekluzek commented Oct 29, 2025

aux_clm passed as expected on Izumi. Everything there was b4b.

We're now pointing to a FATES tag. @rgknox and I will create a baseline with ctsm5.3.082 and then compare to it for these changes.

…pset longname violates the expected fail, so we can't have it uncommented yet
@ekluzek
Copy link
Collaborator

ekluzek commented Oct 29, 2025

OK, the baselines are now all done and looking as expected. Ryan will do the ChangeLog files and we'll tag after that's done.

@ekluzek ekluzek merged commit f4b5699 into ESCOMP:master Oct 29, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from In progress - master to Done (non release/external) in CTSM: Upcoming tags Oct 29, 2025
@github-project-automation github-project-automation bot moved this from Final Testing to Ready to Integrate in FATES Pull Request Planning and Status Oct 29, 2025
@ekluzek ekluzek deleted the fates-l2fr-supp branch October 29, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bfb bit-for-bit FATES API update Changes to the FATES version that also REQUIRE an API change in CTSM

Projects

Status: Done (non release/external)

Development

Successfully merging this pull request may close these issues.

2 participants