-
Notifications
You must be signed in to change notification settings - Fork 141
Rust doesn't use the Bitcode loader, so don't build it #2405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
this is fine, but also could you add the fix for the bcloader on llvm21 (presumably BC->setTargetTriple(""); becomes BC->setTargetTriple(llvm::Triple("")); ) |
also probably add LLVM 21 integration test CI, so then this will be caught in the future? |
I've added your fix, it works locally from LLVM15 onwards, but somehow Julia seems unhappy. So I just limited the fix to 21+. |
9225129
to
a8487db
Compare
can you also add the LLVM21 test to confirm this builds as expected? |
We don't have LLVM-21 CI, and touching enzyme CI is a bit beyond the time I have atm. |
it should just be adding it to the relevant yml file |
a8487db
to
6dbee0e
Compare
ping @wsmoses this keeps comming up |
thx |
Rust recently updated to llvm 21: rust-lang/rust#143684
This caused build failures in the BCLoader.
The failure should be fixed independently, but afaik on the Rust side we don't use the BCloader, so I think there is no reason to build it in the first place. With this patch, rust bootstrap works again, so I merged rust-lang#29 for now, but would like to upstream it.
Relatedly, I should probably disable the following:
(The toolchain size increase of ~9 MiB through Enzyme currently is the only reason why std::autodiff isn't enabled in nightly by default, so that's somewhat relevant.)